[incubator-devlake] branch main updated: fix: display error messages of failed task (#3971)

[likyh]

This is an automated email from the ASF dual-hosted git repository.

likyh pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git


The following commit(s) were added to refs/heads/main by this push:
     new bddb02d30 fix: display error messages of failed task (#3971)
bddb02d30 is described below

commit bddb02d300be9d4a63849c288d7b65b94ff19288
Author: mindlesscloud <liang.zh...@merico.dev>
AuthorDate: Mon Dec 19 19:32:07 2022 +0800

    fix: display error messages of failed task (#3971)
---
 runner/run_pipeline.go | 4 +++-
 runner/run_task.go     | 3 ---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/runner/run_pipeline.go b/runner/run_pipeline.go
index f7d6f491e..c964ad27c 100644
--- a/runner/run_pipeline.go
+++ b/runner/run_pipeline.go
@@ -84,7 +84,9 @@ func runPipelineTasks(
                err = runTasks(row)
                if err != nil {
                        log.Error(err, "run tasks failed")
-                       return err
+                       if !dbPipeline.SkipOnFail {
+                               return err
+                       }
                }
 
                // update finishedTasks
diff --git a/runner/run_task.go b/runner/run_task.go
index 09528a6cc..1b4ef6a9c 100644
--- a/runner/run_task.go
+++ b/runner/run_task.go
@@ -123,9 +123,6 @@ func RunTask(
                task,
                progress,
        )
-       if dbPipeline.SkipOnFail {
-               return nil
-       }
        return err
 }