mindlesscloud commented on code in PR #3976:
URL:
https://github.com/apache/incubator-devlake/pull/3976#discussion_r1053011098
##########
plugins/dbt/tasks/convertor.go:
##########
@@ -55,11 +55,7 @@ func DbtConverter(taskCtx core.SubTaskContext) errors.Error {
profilesPath := data.Options.ProfilesPath
profile := data.Options.Profile
- err := errors.Convert(os.Chdir(projectPath))
- if err != nil {
- return err
- }
- _, err = errors.Convert01(os.Stat("profiles.yml"))
+ _, err := errors.Convert01(os.Stat(projectPath + "/profiles.yml"))
Review Comment:
The `filepath.Join()` is a better way to construct the file path from path
elements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
