klesh commented on code in PR #4083:
URL:
https://github.com/apache/incubator-devlake/pull/4083#discussion_r1060342799
##########
plugins/github/tasks/comment_collector.go:
##########
@@ -56,6 +56,9 @@ func CollectApiComments(taskCtx core.SubTaskContext)
errors.Error {
query.Set("state", "all")
// if data.CreatedDateAfter != nil, we set since once
if data.CreatedDateAfter != nil {
+ // Actually we should use create instead of
since, but this api only has since as query param
Review Comment:
Note that `since` is for filtering records by the `updated` time which is
not ideal for semantic reasons and would result in slightly more records than
expected. But we have no choice since it is the only available field we could
exploit from the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
