[incubator-devlake] branch release-v0.14 updated: fix: close pg conn (#4271)

[abeizn]

This is an automated email from the ASF dual-hosted git repository.

abeizn pushed a commit to branch release-v0.14
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git


The following commit(s) were added to refs/heads/release-v0.14 by this push:
     new 794cca067 fix: close pg conn (#4271)
794cca067 is described below

commit 794cca067036e8898269adebaff89c0e20be28d0
Author: long2ice <jinlong.p...@merico.dev>
AuthorDate: Mon Jan 30 16:18:25 2023 +0800

    fix: close pg conn (#4271)
---
 plugins/starrocks/tasks.go | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/plugins/starrocks/tasks.go b/plugins/starrocks/tasks.go
index 4ccb55b57..38c59b524 100644
--- a/plugins/starrocks/tasks.go
+++ b/plugins/starrocks/tasks.go
@@ -184,16 +184,20 @@ func createTmpTable(starrocks *sql.DB, db dal.Dal, 
starrocksTable string, starro
        firstcm := ""
        firstcmName := ""
        var rowsInStarRocks *sql.Rows
+       var rowsInPostgres *sql.Rows
        defer func() {
                if rowsInStarRocks != nil {
                        rowsInStarRocks.Close()
                }
+               if rowsInPostgres != nil {
+                       rowsInPostgres.Close()
+               }
        }()
        for _, cm := range columnMetas {
                name := cm.Name()
                if name == updateColumn {
                        // check update column to detect skip or not
-                       rows, err := db.Cursor(
+                       rowsInPostgres, err = db.Cursor(
                                dal.From(table),
                                dal.Select(updateColumn),
                                dal.Limit(1),
@@ -203,8 +207,8 @@ func createTmpTable(starrocks *sql.DB, db dal.Dal, 
starrocksTable string, starro
                                return nil, "", false, err
                        }
                        var updatedFrom time.Time
-                       if rows.Next() {
-                               err = errors.Convert(rows.Scan(&updatedFrom))
+                       if rowsInPostgres.Next() {
+                               err = 
errors.Convert(rowsInPostgres.Scan(&updatedFrom))
                                if err != nil {
                                        return nil, "", false, err
                                }