[GitHub] [incubator-devlake] klesh opened a new issue, #4298: [Refactor][apihelper] Simplify and Unify ApiClient Creation Logic

Thu, 02 Feb 2023 02:06:05 -0800 


klesh opened a new issue, #4298:
URL: https://github.com/apache/incubator-devlake/issues/4298

   ## What and why to refactor
   All of our data source plugins have 2 places that need `ApiClient`: 
`api.TestConnection` and `tasks.CreateApiClient`
   
   
![image](https://user-images.githubusercontent.com/61080/216293704-01f059b5-8b3e-4ea1-86a5-0304227635c1.png)
   
   
![image](https://user-images.githubusercontent.com/61080/216293895-ae0a5ade-4c58-40b6-8227-ff32098c3514.png)
   
   We can clearly see that there is redundant code.
   
   ## Describe the solution you'd like
   
   The plan is to offer a **unified helper function** to help plugins create 
`ApiClient` with ease, and avoid that redundant code in the first place.
   
   
   ## Related issues
   #4027 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to