keon94 opened a new issue, #4351:
URL: https://github.com/apache/incubator-devlake/issues/4351

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   
https://github.com/apache/incubator-devlake/blob/7bb73a96da41bd96deb857718ffe732fb5f40f44/backend/plugins/github_graphql/impl/impl.go#L165
   uses a simple concactenation of endpoint and "graphql", but assumes the 
endpoint ends with a slash. This breaks the client and the subtasks will fail.
   
   ### What do you expect to happen
   
   The code should use filepath.Join(x,y) to defend against this case.
   
   ### How to reproduce
   
   Use "https://api.github.com"; as the endpoint and hit the graphql plugin 
directly.
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   main
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to