klesh opened a new pull request, #4442:
URL: https://github.com/apache/incubator-devlake/pull/4442

   ### Summary
   github runs collector supports timeFilter/diffSync
   
   Due to the fact that github runs API doesn't support `since`(filter by 
updated_at) parameter, 
   this PR uses another approach to support timeFilter and diffSync:
   
   1. Collect newly added records by examining the `created_at` field
   2. Load unfinished records in the database and collect their details from 
API if diffSync is in action
   
   
   ### Does this close any open issues?
   Part of #4403
   
   ### Self test:
   
   I took the following steps to verify:
   
   1. I set the `timeAfter`, and collect data, and observed the database, it 
worked as expected
   2. I then return the task with the same parameters as the previous step, and 
no data changed which is correct
   3. I then modified the `timeAfter` parameter to a later date and the 
database stay the same which is correct
   4. lastly, I pushed `timeAfter` to a older date and records increased as 
expected
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to