klesh commented on code in PR #4491:
URL:
https://github.com/apache/incubator-devlake/pull/4491#discussion_r1115223416
##########
backend/plugins/github_graphql/tasks/issue_collector.go:
##########
@@ -130,7 +137,8 @@ func CollectIssue(taskCtx plugin.SubTaskContext)
errors.Error {
results := make([]interface{}, 0, 1)
isFinish := false
for _, issue := range issues {
- if data.TimeAfter != nil &&
!data.TimeAfter.Before(issue.CreatedAt) {
+ // collect all data even though in increment
mode because of existing data extracting
+ if collectorWithState.TimeAfter != nil &&
!collectorWithState.TimeAfter.Before(issue.UpdatedAt) {
Review Comment:
Since we are sorting records by UpdatedAt in descending order, I think we
could support diffSync in the same manner, no?
##########
backend/plugins/github_graphql/tasks/check_run_collector.go:
##########
@@ -101,7 +101,7 @@ func CollectCheckRun(taskCtx plugin.SubTaskContext)
errors.Error {
db := taskCtx.GetDal()
data := taskCtx.GetData().(*githubTasks.GithubTaskData)
- collectorWithState, err :=
helper.NewApiCollectorWithState(helper.RawDataSubTaskArgs{
Review Comment:
Please rename this collector to `job_collector`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
