likyh commented on code in PR #4542:
URL:
https://github.com/apache/incubator-devlake/pull/4542#discussion_r1119797991
##########
backend/plugins/gitlab/tasks/job_collector.go:
##########
@@ -35,16 +49,72 @@ var CollectApiJobsMeta = plugin.SubTaskMeta{
func CollectApiJobs(taskCtx plugin.SubTaskContext) errors.Error {
rawDataSubTaskArgs, data := CreateRawDataSubTaskArgs(taskCtx,
RAW_JOB_TABLE)
-
- collector, err := helper.NewApiCollector(helper.ApiCollectorArgs{
+ db := taskCtx.GetDal()
+ collector, err :=
helper.NewStatefulApiCollectorForFinalizableEntity(helper.FinalizableApiCollectorArgs{
RawDataSubTaskArgs: *rawDataSubTaskArgs,
ApiClient: data.ApiClient,
- PageSize: 100,
- Incremental: false,
- UrlTemplate: "projects/{{ .Params.ProjectId }}/jobs",
- Query: GetQuery,
- ResponseParser: GetRawMessageUpdatedAtAfter(data.TimeAfter),
- AfterResponse: ignoreHTTPStatus403, // ignore 403 for
CI/CD disable
+ TimeAfter: data.TimeAfter, // set to nil to disable
timeFilter
+ CollectNewRecordsByList: helper.FinalizableApiCollectorListArgs{
+ PageSize: 100,
+ Concurrency: 10,
+ FinalizableApiCollectorCommonArgs:
helper.FinalizableApiCollectorCommonArgs{
+ UrlTemplate: "projects/{{ .Params.ProjectId
}}/jobs",
+ Query: func(reqData *helper.RequestData,
createdAfter *time.Time) (url.Values, errors.Error) {
+ query := url.Values{}
+ query.Set("with_stats", "true")
+ query.Set("sort", "asc")
+ query.Set("page",
strconv.Itoa(reqData.Pager.Page))
+ query.Set("per_page",
strconv.Itoa(reqData.Pager.Size))
+ return query, nil
+ },
+ ResponseParser: func(res *http.Response)
([]json.RawMessage, errors.Error) {
+ var items []json.RawMessage
+ err := helper.UnmarshalResponse(res,
&items)
+ if err != nil {
+ return nil, err
+ }
+ return items, nil
+ },
+ AfterResponse: ignoreHTTPStatus403, // ignore
403 for CI/CD disable
+ },
+ GetCreated: func(item json.RawMessage) (time.Time,
errors.Error) {
+ pr := &SimpleGitlabApiJob{}
+ err := json.Unmarshal(item, pr)
+ if err != nil {
+ return time.Time{},
errors.BadInput.Wrap(err, "failed to unmarshal github pull request")
Review Comment:
wrong message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
