This is an automated email from the ASF dual-hosted git repository.
likyh pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
The following commit(s) were added to refs/heads/main by this push:
new aa201f132 feat: add checklist in ci (#4543)
aa201f132 is described below
commit aa201f1324d9b95603a84b88247fb0b54e396630
Author: Likyh <[email protected]>
AuthorDate: Fri Mar 3 23:51:18 2023 +0800
feat: add checklist in ci (#4543)
* feat: add checklist in ci
* feat: update some detail info
---
.asf.yaml | 2 +
.../{front-end-lint.yml => frontend-lint.yml} | 0
.github/workflows/go-checklist.json | 48 ++++++++++++++++++++++
.../{front-end-lint.yml => go-checklist.yml} | 28 ++++++-------
.github/workflows/test-e2e.yml | 1 -
5 files changed, 64 insertions(+), 15 deletions(-)
diff --git a/.asf.yaml b/.asf.yaml
index e8a3bbe19..3f1cf3c92 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -69,6 +69,8 @@ github:
whatever: Just a placehold to make it in protection
release-v0.14:
whatever: Just a placehold to make it in protection
+ release-v0.15:
+ whatever: Just a placehold to make it in protection
# The triage role allows people to assign, edit, and close issues and pull
requests,
# without giving them write access to the code.
collaborators:
diff --git a/.github/workflows/front-end-lint.yml
b/.github/workflows/frontend-lint.yml
similarity index 100%
copy from .github/workflows/front-end-lint.yml
copy to .github/workflows/frontend-lint.yml
diff --git a/.github/workflows/go-checklist.json
b/.github/workflows/go-checklist.json
new file mode 100644
index 000000000..41c2514ee
--- /dev/null
+++ b/.github/workflows/go-checklist.json
@@ -0,0 +1,48 @@
+{
+ "mappings": [
+ {
+ "keywords": ["."],
+ "comment": "check test snapshot or result have been added into github
desc"
+ },
+ {
+ "keywords": ["CSVRelPath"],
+ "comment": "check if the data in e2e/*.csv is simple and complete. (No
duplicated data but cover all type of data)"
+ },
+ {
+ "keywords": ["const RAW_"],
+ "comment": "RAW_TABLE use correct in extractor and convertor"
+ },
+ {
+ "keywords": ["DomainTypes:"],
+ "comment": "DomainTypes filled with correct value"
+ },
+ {
+ "keywords": ["fmt.Printf"],
+ "comment": "check if debug code deleted"
+ },
+ {
+ "keywords": ["IdGen.Generate"],
+ "comment": "check if all primary and foreign id use `IdGen.Generate`"
+ },
+ {
+ "keywords": ["errors.HttpStatus("],
+ "comment": "check if http status code (`errors.HttpStatus`) correct"
+ },
+ {
+ "keywords": ["db.Cursor", "db.RawCursor", "dal.Cursor"],
+ "comment": "check if `db.Cursor` close"
+ },
+ {
+ "keywords": ["gorm:\"primaryKey\""],
+ "comment": "check if primary key in model not duplicated and check if
migration added when primary key changed"
+ },
+ {
+ "keywords": ["PageSize:"],
+ "comment": "check if `PageSize` set but not used"
+ },
+ {
+ "keywords": ["collectorWithState.IsIncremental", "Incremental:"],
+ "comment": "check if collector is incremental when `Incremental` is true"
+ }
+ ]
+}
\ No newline at end of file
diff --git a/.github/workflows/front-end-lint.yml
b/.github/workflows/go-checklist.yml
similarity index 65%
rename from .github/workflows/front-end-lint.yml
rename to .github/workflows/go-checklist.yml
index e5a0c9072..d7de36dfc 100644
--- a/.github/workflows/front-end-lint.yml
+++ b/.github/workflows/go-checklist.yml
@@ -15,24 +15,24 @@
# limitations under the License.
#
-name: Frontend-Lint
+name: Go-checklist
on:
pull_request:
branches: [ main ]
paths:
- - 'config-ui/**'
+ - ".github/workflows/*.yml"
+ - "**.go"
+ - "go.mod"
+ - "go.sum"
jobs:
- build:
+ checklist_job:
runs-on: ubuntu-latest
+ name: A job to create dynamic checklist
steps:
- - uses: actions/checkout@v2
- - name: Cache Frontend-Lint
- id: cache-Frontend-Lint
- uses: actions/cache@v3
- with:
- path: Frontend-Lint
- key: ${{ runner.os }}-Frontend-Lint
- - name: Install modules
- run: cd config-ui; npm i
- - name: Run ESLint
- run: cd config-ui; npm run lint
+ - uses: actions/checkout@v3
+ - name: Dynamic checklist action
+ uses:
vishalsinha21/dynamic-checklist@23eec89b55d2565f678788c4a12a8bc66b8fe1e5
+ with:
+ mappingFile: '.github/workflows/go-checklist.json'
+ env:
+ GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
diff --git a/.github/workflows/test-e2e.yml b/.github/workflows/test-e2e.yml
index be17af08d..234f5e315 100644
--- a/.github/workflows/test-e2e.yml
+++ b/.github/workflows/test-e2e.yml
@@ -29,7 +29,6 @@ on:
- "test/**"
- "e2e/**"
- "devops/**"
- - "config-ui/**"
jobs:
e2e-mysql:
runs-on: ubuntu-latest
