aubertaa opened a new issue, #4657:
URL: https://github.com/apache/incubator-devlake/issues/4657

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   hi
   the jenkins scope selector fails when at least 1 job in the whole list 
contains '/' character. It tries to call jenkins API with non encoded job name 
which leads to a 404 error (see screen). This makes jenkins scope selection 
impossible:
   
   
![image](https://user-images.githubusercontent.com/14087776/224946562-acc97df4-8596-4c15-9902-27e3073b2714.png)
   
   if i may suggest, var "repoId" should be URL encoded here as job name may 
contain "either reserved or potentially unsafe when used in URLs"  : 
https://github.com/apache/incubator-devlake/blob/d708a808c5808be330998c8bbdaf1e02b8d004d8/config-ui/src/plugins/components/data-scope/api.ts#L22
   
   ### What do you expect to happen
   
   - URL specific chars should be encoded when repoId is used as a path 
parameter
   - call to jenkins API should success for each existing job (or at least 
failure should not be a blocker to add other jobs in scope)
   
   
   ### How to reproduce
   
   - link devlake with a jenkins instance containing a job named "test/myjob"
   - try to add scope from this jenkins in a new blueprint
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   v0.15.0
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to