CamilleTeruel commented on code in PR #4695:
URL:
https://github.com/apache/incubator-devlake/pull/4695#discussion_r1142721626
##########
backend/server/services/remote/plugin/connection_api.go:
##########
@@ -22,15 +22,22 @@ import (
"github.com/apache/incubator-devlake/core/errors"
"github.com/apache/incubator-devlake/core/plugin"
+ "github.com/apache/incubator-devlake/server/api/shared"
"github.com/apache/incubator-devlake/server/services/remote/bridge"
)
func (pa *pluginAPI) TestConnection(input *plugin.ApiResourceInput)
(*plugin.ApiResourceOutput, errors.Error) {
err := pa.invoker.Call("test-connection", bridge.DefaultContext,
input.Body).Err
if err != nil {
Review Comment:
Indeed, this would require to discriminate between errors. We can plan this
change for later.
For now the message helps disambiguate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
