hezyin commented on code in PR #4724:
URL:
https://github.com/apache/incubator-devlake/pull/4724#discussion_r1147853395
##########
.env.example:
##########
@@ -28,7 +28,7 @@ TEMPORAL_TASK_QUEUE=
# Debug Info Warn Error
LOGGING_LEVEL=
LOGGING_DIR=./logs
-ENABLE_STACKTRACE=false
+ENABLE_STACKTRACE=true
Review Comment:
Do we want to turn this on by default? I thought it's only for debugging
purposes?
##########
.github/workflows/test-e2e.yml:
##########
@@ -42,27 +42,33 @@ jobs:
MYSQL_ROOT_PASSWORD: root
container: mericodev/lake-builder:latest
steps:
- - uses: actions/checkout@v3
+ - name: Checkout code
+ uses: actions/checkout@v3
+ - run: git config --global --add safe.directory $(pwd)
Review Comment:
What does this git config command do?
##########
devops/docker/lake-builder/README.md:
##########
@@ -1,13 +1,19 @@
# lake-builder
-golang builder image for lake, including go1.19.0 gcc10.3.1 g++10.3.1, libgit2
v1.3 based on alpine linux 3.16.
+Golang builder image for DevLake. Used by GitHub workflows.
Review Comment:
How is lake-builder used right now?
##########
.github/workflows/test-e2e.yml:
##########
@@ -42,27 +42,33 @@ jobs:
MYSQL_ROOT_PASSWORD: root
container: mericodev/lake-builder:latest
steps:
- - uses: actions/checkout@v3
+ - name: Checkout code
+ uses: actions/checkout@v3
+ - run: git config --global --add safe.directory $(pwd)
+ - name: Build Sources
+ run: |
+ cd backend
+ make build
- name: Cache test-e2e
id: cache-test-e2e
uses: actions/cache@v3
with:
path: |
~/.cache/go-build
- ~/go/pkg/mod
+ ${{ env.GOPATH }}/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-
- - name: Test
+ - name: Test-mysql
Review Comment:
Why is this renamed to `Test-mysql`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
