CamilleTeruel commented on code in PR #4802:
URL:
https://github.com/apache/incubator-devlake/pull/4802#discussion_r1150966929
##########
backend/core/utils/ipc.go:
##########
@@ -260,7 +260,8 @@ func scanErrorPipe(pipe io.ReadCloser, onReceive
func([]byte), outboundChannel c
data := make([]byte, len(src))
copy(data, src)
onReceive(data)
- outboundChannel <- &ProcessResponse{stderr: data}
+ err := errors.Default.New(string(data))
Review Comment:
Well depending on the semantics you put under the term "error", you might
want an error that doesn't abort the current command.
This was mostly for convenience and to ensure we have a single failure mode,
so not an important change.
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
