CamilleTeruel commented on code in PR #4504:
URL:
https://github.com/apache/incubator-devlake/pull/4504#discussion_r1154315506
##########
backend/server/services/remote/plugin/connection_api.go:
##########
@@ -33,7 +33,7 @@ func (pa *pluginAPI) TestConnection(input
*plugin.ApiResourceInput) (*plugin.Api
Success: false,
Message: err.Error(),
}
- return &plugin.ApiResourceOutput{Body: body, Status: 401}, nil
+ return &plugin.ApiResourceOutput{Body: body, Status: 500}, nil
Review Comment:
It is true that the error can be a server error, but it is more regularly an
authorization error from the tool API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
