klesh commented on code in PR #4839:
URL:
https://github.com/apache/incubator-devlake/pull/4839#discussion_r1155459452
##########
backend/core/migration/migrator.go:
##########
@@ -84,10 +89,9 @@ func (m *migratorImpl) Execute() errors.Error {
})
// execute them one by one
db := m.basicRes.GetDal()
- logger := m.basicRes.GetLogger().Nested("migrator")
for _, swc := range m.pending {
- scriptId := fmt.Sprintf("%d-%s", swc.script.Version(),
swc.script.Name())
Review Comment:
Seems like a benign issue.
The `executed` is constructed by `loadExecuted` method, and `pending` is
constructed by `Register`, as long as their `scriptId`s are consistent, it is
ok since `executed` inside `Execute` is not being used anywhere.
However, I agree with you that it should be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
