klesh commented on code in PR #4886:
URL:
https://github.com/apache/incubator-devlake/pull/4886#discussion_r1162517352
##########
backend/plugins/bitbucket/tasks/pipeline_extractor.go:
##########
@@ -98,6 +100,8 @@ func ExtractApiPipelines(taskCtx plugin.SubTaskContext)
errors.Error {
DurationInSeconds:
bitbucketApiPipeline.DurationInSeconds,
BitbucketCreatedOn:
api.Iso8601TimeToTime(bitbucketApiPipeline.CreatedOn),
BitbucketCompleteOn:
api.Iso8601TimeToTime(bitbucketApiPipeline.CompletedOn),
+ Type:
data.RegexEnricher.ReturnNameIfMatched(devops.DEPLOYMENT,
bitbucketApiPipeline.Target.RefName),
Review Comment:
I'm confused, shouldn't we do it on the tool layer since "some data source
platform might have its own type and env" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
