klesh commented on PR #4896: URL: https://github.com/apache/incubator-devlake/pull/4896#issuecomment-1510071598
Great discussion, thanks to @CamilleTeruel @chenggui53 I would like to add my 2 cents. 1. auto-discovery may not be easy in Golang, especially since all our plugins get compiled into a `.so` file, there is no official support for scanning Types/Vars in a dynlib. I think `init` func is acceptable if most of us agreed that putting registration in another file is bad. 2. dependency over entities is indeed a good idea, however, it is kind of complicated, I would accept tasks-base dependency at the moment. I think they can coexist in the future, developers can choose one or another to achieve the goal. We can start on the plugin level by providing a `helper` function to resolve the dependency and see how it goes. 3. I don't see the `loop detection` in the implementation, the dependency should be a DAG, I think we should do it. 4. Is the sorting algo stable? I would prefer a stable outcome for debugging's sake. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@devlake.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
