CamilleTeruel commented on code in PR #4973:
URL:
https://github.com/apache/incubator-devlake/pull/4973#discussion_r1171578066
##########
backend/server/services/remote/plugin/plugin_impl.go:
##########
@@ -164,11 +164,12 @@ func (p *remotePluginImpl) Description() string {
}
func (p *remotePluginImpl) RootPkgPath() string {
- // RootPkgPath is only used to find to which plugin a given type
belongs.
- // This in turn is only used by DomainIdGenerator.
- // Remote plugins define tool layer types in another language,
- // so the reflective implementation of NewDomainIdGenerator cannot work.
- return ""
Review Comment:
DomainIdGenerator uses FindPluginNameBySubPkgPath that returns the name of
the first plugin whose RootPkgPath is a prefix of the type package path. So
this empty string makes FindPluginNameBySubPkgPath believe all types belong to
any remote plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
