warren830 commented on code in PR #4978:
URL:
https://github.com/apache/incubator-devlake/pull/4978#discussion_r1172111784
##########
backend/plugins/gitlab/models/migrationscripts/20230420_add_mr_commit_author_date.go:
##########
@@ -0,0 +1,53 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
Review Comment:
fixed
##########
backend/plugins/gitlab/models/mr_commit.go:
##########
@@ -28,9 +29,10 @@ import (
// Thus a "Merge Request Commit" needs to be considered as distinct from a
"Commit"
type GitlabMrCommit struct {
- ConnectionId uint64 `gorm:"primaryKey"`
- CommitSha string `gorm:"primaryKey;type:varchar(40)"`
- MergeRequestId int `gorm:"primaryKey;autoIncrement:false"`
+ ConnectionId uint64 `gorm:"primaryKey"`
+ CommitSha string `gorm:"primaryKey;type:varchar(40)"`
+ MergeRequestId int `gorm:"primaryKey;autoIncrement:false"`
+ CommitAuthoredDate *time.Time
Review Comment:
Either is ok, I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
