CamilleTeruel opened a new issue, #4986:
URL: https://github.com/apache/incubator-devlake/issues/4986

   ## What and why to refactorIssue title:
   
   Currently, the remote plugins are registered this way:
   - the route `/plugins/register` is created in `backend/server/api.go`
   - `backend/python/plugins/start.sh` is executed
   - this executes the `startup` command of each plugin
   - the plugin registers itself by POSTing its details to `/plugins/register` 
   
   This is not ideal, because:
   - this is more complicated than it needs to be
   - this exposes the registration route to the public, which can be a security 
issue
   - the `start.sh` and `build.sh` scripts have to make assumptions about how 
to build all plugins (e.g. that they use `poetry`)
   
   ## Describe the solution you'd like
   
   Instead, we could add a Makefile to each plugin, with `build` and `run` 
targets.
   The `build` target is executed by `backend/Makefile` to build each plugins.
   Then at startup, each plugin is registered by using info returned by `make 
run plugin-info`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to