CamilleTeruel commented on code in PR #4976: URL: https://github.com/apache/incubator-devlake/pull/4976#discussion_r1173682441
########## backend/python/plugins/azuredevops/azuredevops/helper/db.py: ########## @@ -1,28 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one or more Review Comment: I deleted this file because it is not used anymore. Some converters might indeed need to query the DB. While it might be beneficial to abstract sqlalchemy API away, this requires quite some work. OTOH, sqlalchemy API is mature and almost standard. So I'm not sure if the cost/benefit ratio is good. We can think about little helping methods like this one, but I think it should execute the query in the same session than the one used for conversion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
