klesh opened a new issue, #5009: URL: https://github.com/apache/incubator-devlake/issues/5009
## What and why to refactor Previously, we support optional grafana by mounting the `default.conf.tpl` into the container, it works but poses a couple of shortcomings: 1. The `default.conf.tpl` is never meant to be exposed to users for modification. 2. The `default.conf.tpl` will be modified in the `devlake` repo in order to support advanced features, i.e. SSO like OAUTH/JWD etc. When that happens, the modification will not be applied to the `helm chart` ## Describe the solution you'd like 1. `config-ui` image to expose an Environment Variable named `USE_EXTERNAL_GRAFANA`, when it is set to `true`, config-ui would redirect requests to specified `GRAFANA_ENDPOINT` 2. `helm-chart` will use the EnvVar instead of mounting the `default.conf.tpl` file. ## Related issues #https://github.com/apache/incubator-devlake-helm-chart/pull/94/files ## Additional context I recently updated the `default.conf.tpl` and it didn't get applied in our deployment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
