[GitHub] [incubator-devlake-helm-chart] JorgeGar commented on a diff in pull request #110: Include option to have the database connection details as a secret

Thu, 27 Apr 2023 02:17:59 -0700 


JorgeGar commented on code in PR #110:
URL: 
https://github.com/apache/incubator-devlake-helm-chart/pull/110#discussion_r1178786100


##########
charts/devlake/values.yaml:
##########
@@ -223,3 +226,14 @@ option:
 
   # database type, supported: [mysql]
   database: mysql
+
+  # if true, will not add the database connection details 
+  # to the configmap and will let them be obtained from a secret.
+  useConnectionDetailsSecret: false

Review Comment:
   This one is with basic auth disabled:
   ![Screenshot 2023-04-27 at 10 14 
08](https://user-images.githubusercontent.com/5280729/234801827-84d36ac0-bc5d-42ac-95c8-3ba4544f3795.png)
   
   And this one with basic auth enabled:
   ![Screenshot 2023-04-27 at 11 16 
17](https://user-images.githubusercontent.com/5280729/234817871-5dc0e1bc-dfc4-48fa-8cc0-ea3af19fa3bb.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to