CamilleTeruel commented on code in PR #4906:
URL:
https://github.com/apache/incubator-devlake/pull/4906#discussion_r1179278317
##########
backend/python/pydevlake/pydevlake/stream.py:
##########
@@ -80,9 +80,14 @@ class StreamRawModel(RawModel, table=True):
__tablename__ = table_name
self._raw_model = StreamRawModel
- RawModel.metadata.create_all(session.get_bind())
+ if session is not None:
Review Comment:
When is the session None?
##########
backend/test/e2e/remote/python_plugin_test.go:
##########
@@ -159,4 +159,8 @@ func TestBlueprintV200(t *testing.T) {
project := client.GetProject(projectName)
require.Equal(t, blueprint.Name, project.Blueprint.Name)
client.TriggerBlueprint(blueprint.ID)
+
+ bps := client.DeleteScope(PLUGIN_NAME, connection.ID, scope.Id)
+ require.Equal(t, 1, len(bps))
+ require.Equal(t, blueprint.ID, bps[0].ID)
Review Comment:
This test is about triggering a blueprint. Scope deletion should have its
own dedicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]