JorgeGar commented on code in PR #125:
URL:
https://github.com/apache/incubator-devlake-helm-chart/pull/125#discussion_r1185732721
##########
charts/devlake/templates/ingresses.yaml:
##########
@@ -56,6 +56,7 @@ spec:
- host: {{ .Values.ingress.hostname | quote }}
http:
paths:
+ {{- if not .Values.grafana.oauthEnabled }}
Review Comment:
Just asking here: Why are we not creating the internal Grafana ingress when
the oauth is enabled?
##########
charts/devlake/templates/configmaps.yaml:
##########
@@ -58,20 +52,28 @@ data:
secureJsonData:
password: $MYSQL_PASSWORD
editable: false
-#{{- else if eq .Values.option.database "pgsql" }}
-# grafana-datasource.yml: |
-# apiVersion: 1
-# datasources:
-# - name: postgres
-# type: postgres
-# url: $POSTGRES_URL
-# database: $POSTGRES_DB
-# user: $POSTGRES_USER
-# secureJsonData:
-# password: $POSTGRES_PASSWORD
-# jsonData:
-# sslmode: 'disable'
-# postgresVersion: 1000 # support pgsql 10.0 and above
-# timescaledb: false
{{- end }}
{{- end }}
+---
+{{- if .Values.grafana.oauthEnabled }}
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: {{ include "devlake.fullname" . }}-grafana-oauth-config
+data:
+ {{- with .Values.grafana.oauthConfig }}
Review Comment:
Could this be optionally a secret? As far as I understand, it may contain
sensitive data.
##########
charts/devlake/templates/deployments.yaml:
##########
@@ -72,13 +71,15 @@ spec:
envFrom:
- configMapRef:
name: {{ include "devlake.fullname" . }}-config
+ {{- if .Values.grafana.oauthEnabled }}
+ - configMapRef:
+ name: {{ include "devlake.fullname" . }}-grafana-oauth-config
+ {{- end }}
{{- if .Values.option.useConnectionDetailsSecret }}
- secretRef:
name: {{ .Values.option.connectionSecretName }}
{{- end }}
env:
- - name: GF_SERVER_ROOT_URL
Review Comment:
This variable is removed, but I do not see it replaced anywhere. Is it not
used anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
