IronCore864 commented on code in PR #125:
URL: 
https://github.com/apache/incubator-devlake-helm-chart/pull/125#discussion_r1185880545


##########
charts/devlake/templates/ingresses.yaml:
##########
@@ -56,6 +56,7 @@ spec:
     - host: {{ .Values.ingress.hostname | quote }}
       http:
         paths:
+          {{- if not .Values.grafana.oauthEnabled }}

Review Comment:
   I think it's because this is how the current Config-UI/DevLake works at the 
moment; there is an Nginx running inside the Config-UI pod, which forwards 
`/grafana` traffic to the Grafana pod inside the same namespace in the K8s 
cluster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to