This is an automated email from the ASF dual-hosted git repository.
zhangliang2022 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
The following commit(s) were added to refs/heads/main by this push:
new 98d398380 feat: github adapts original_status and status (#5133)
98d398380 is described below
commit 98d39838025dec9e34e05b74dcf933d5ee289c1b
Author: abeizn <[email protected]>
AuthorDate: Tue May 9 16:08:42 2023 +0800
feat: github adapts original_status and status (#5133)
* feat: github adapts original_status and status
* feat: add github graphql status convertor
---
.../core/models/domainlayer/code/pull_request.go | 6 ++
backend/plugins/github/e2e/pr_test.go | 1 +
.../snapshot_tables/_tool_github_pull_requests.csv | 98 ++++++++++----------
.../github/e2e/snapshot_tables/pull_requests.csv | 100 ++++++++++-----------
backend/plugins/github/tasks/pr_convertor.go | 12 ++-
backend/plugins/github/tasks/pr_extractor.go | 13 ---
6 files changed, 116 insertions(+), 114 deletions(-)
diff --git a/backend/core/models/domainlayer/code/pull_request.go
b/backend/core/models/domainlayer/code/pull_request.go
index d3179b4e6..a300ae544 100644
--- a/backend/core/models/domainlayer/code/pull_request.go
+++ b/backend/core/models/domainlayer/code/pull_request.go
@@ -23,6 +23,12 @@ import (
"github.com/apache/incubator-devlake/core/models/domainlayer"
)
+const (
+ OPEN = "OPEN"
+ CLOSED = "CLOSED"
+ MERGED = "MERGED"
+)
+
type PullRequest struct {
domainlayer.DomainEntity
BaseRepoId string `gorm:"index"`
diff --git a/backend/plugins/github/e2e/pr_test.go
b/backend/plugins/github/e2e/pr_test.go
index eb1a18546..440a5c3cb 100644
--- a/backend/plugins/github/e2e/pr_test.go
+++ b/backend/plugins/github/e2e/pr_test.go
@@ -124,6 +124,7 @@ func TestPrDataFlow(t *testing.T) {
"base_repo_id",
"head_repo_id",
"status",
+ "original_status",
"title",
"description",
"url",
diff --git
a/backend/plugins/github/e2e/snapshot_tables/_tool_github_pull_requests.csv
b/backend/plugins/github/e2e/snapshot_tables/_tool_github_pull_requests.csv
index 1f026d005..d682a2730 100644
--- a/backend/plugins/github/e2e/snapshot_tables/_tool_github_pull_requests.csv
+++ b/backend/plugins/github/e2e/snapshot_tables/_tool_github_pull_requests.csv
@@ -1,50 +1,50 @@
connection_id,github_id,repo_id,head_repo_id,number,state,title,github_created_at,github_updated_at,closed_at,additions,deletions,comments,commits,review_comments,merged,merged_at,body,type,component,merge_commit_sha,head_ref,base_ref,base_commit_sha,head_commit_sha,url,author_name,author_id,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark
-1,203756736,134018330,142234748,4,MERGED,pre-allocate the capacity of the
worker listpre-allocate the capacity of the worker listpre-allocate the
capacity of the worker listpre-allocate the capacity of the worker
listpre-allocate the capacity of the worker listpre-allocate the capacity of
the worker listpre-allocate the capacity of the worker listpre-allocate the
capacity of the worker listpre-allocate the capacity of the worker
listpre-allocate the capacity of the worker listpre-allocat [...]
-1,211603583,134018330,0,8,CLOSED,fix goroutine
leak,2018-08-29T01:35:54.000+00:00,2018-10-30T00:12:13.000+00:00,2018-10-30T00:12:13.000+00:00,0,0,0,0,0,0,,"""n++,
will cause workers[0]
leak""",,,74ba726f34abe487b7defac6bb9bebf24d342377,dev,master,666635c65d8d3bb1223b819325e0bd23c81f2733,afd687164b13280199208ec4869709edcf02b52d,https://github.com/panjf2000/ants/pull/8,hongli-my,8597823,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,247,
-1,212277907,134018330,146845386,9,CLOSED,Update
pool.go,2018-08-31T05:29:36.000+00:00,2018-08-31T13:40:33.000+00:00,2018-08-31T13:40:33.000+00:00,0,0,0,0,0,0,,"""#活着的孩子不想当孤儿\r\n\tHopefully:\r\n\tchildren
:= []*child{C1,C2,C3,C4,C5,C6,C7}\r\n\tIn fact:\r\n\tchildren :=
[]*child{C1,C4,C2,C3,C5,C6,C7}""",,,f14d3f91f68d0bc23fe42aa413e98005f6575045,patch-1,master,666635c65d8d3bb1223b819325e0bd23c81f2733,2726d42ea62857283ee73ef3611e379b60974ad2,https://github.com/panjf2000/ants/pull/9,Nonnnnnn
[...]
-1,216254598,134018330,149267177,11,CLOSED,graceful
exit,2018-09-18T10:15:01.000+00:00,2018-12-03T03:52:35.000+00:00,2018-12-03T03:52:35.000+00:00,0,0,0,0,0,0,,"""graceful
exit""",,,6a87067eb3d6440e5db17f31d4bc12ac291633f4,master,develop,833b6e29acfb2f16e3cf7fc92c79763847c319f4,a03eccc794870f0a2e55a5cb8344ea47f2a0001d,https://github.com/panjf2000/ants/pull/11,shanhuhai5739,3794113,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,249,
-1,218939809,134018330,150579999,13,MERGED,❓解决死循环导致cpu占用率过高,2018-09-28T11:37:28.000+00:00,2018-09-29T11:29:54.000+00:00,2018-09-29T11:29:54.000+00:00,0,0,0,0,0,0,2018-09-29T11:29:54.000+00:00,"""使用了cond
条件变量来阻塞Submit
goroutine。潘少,你再仔细琢磨琢磨,看下有何不妥?""",,,9a3b5cd25344822bca7684f87d9e123890a7bf59,master,master,af376f1b7b59dc488458bcecd4273f0fcde33c55,1846b4392a3a20e6bf1a7431b67f86bd43e0f0b9,https://github.com/panjf2000/ants/pull/13,liyonglion,12890888,"{""ConnectionId"":1,""Name"":""panjf2000/
[...]
-1,219363161,134018330,0,14,MERGED,Remove meaningless if
statements,2018-10-01T12:48:11.000+00:00,2018-10-02T13:52:27.000+00:00,2018-10-02T13:52:27.000+00:00,0,0,0,0,0,0,2018-10-02T13:52:27.000+00:00,"""""",,,29730bb70343924a2f56a13a9799611dd1cd27fd,master,master,1b62696050b7030106291980d5220f886b017eff,5ed168767a771e3802252020b9821610380ed1a4,https://github.com/panjf2000/ants/pull/14,SimePel,20608155,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,251,
-1,219936521,134018330,0,15,MERGED,Fixes to benchmarks and added semaphore
comparison,2018-10-03T07:16:16.000+00:00,2018-10-03T12:38:57.000+00:00,2018-10-03T12:33:59.000+00:00,0,0,0,0,0,0,2018-10-03T12:33:59.000+00:00,"""Benchmark
results with Param=0, as time.Sleep is not stable on Windows\r\n\r\nAlso Go
1.11 has bunch of improvements:\r\n\r\n```\r\ngoos: windows\r\ngoarch:
amd64\r\npkg: github.com/panjf2000/ants\r\nBenchmarkGoroutineWithFunc-8
1 3530220300 ns/op [...]
-1,222703171,134018330,152956614,16,CLOSED,bugfix(check max pool
size),2018-10-14T09:21:41.000+00:00,2018-12-03T03:53:31.000+00:00,2018-12-03T03:53:31.000+00:00,0,0,0,0,0,0,,"""if
you limit max goroutine to math.Maxint32 as your code `int32(pool size)`\r\nI
think should check max Goroutine size, otherwise size overflow to
negative?\r\n""",,,1399cfa28f6751f769a985206daecb56a08b2de9,bugfix_check_max_pool_size,master,711dbdb7a222771ce15aaee1bb7b7c6e9731f208,439348b027031c793e54669fcd74eb496
[...]
-1,231840723,134018330,158152223,19,MERGED,Possible memory leak because of
Ticker,2018-11-19T03:03:09.000+00:00,2018-12-01T15:49:32.000+00:00,2018-12-01T15:49:32.000+00:00,0,0,0,0,0,0,2018-12-01T15:49:32.000+00:00,"""//
NewTicker returns a new Ticker containing a channel that will send the\r\n//
time with a period specified by the duration argument.\r\n// It adjusts the
intervals or drops ticks to make up for slow receivers.\r\n// The duration d
must be greater than zero; if not, NewTicke [...]
-1,246250598,134018330,0,23,MERGED,feature: add
PanicHandler,2019-01-21T10:58:15.000+00:00,2019-01-22T05:41:34.000+00:00,2019-01-22T05:41:34.000+00:00,0,0,0,0,0,0,2019-01-22T05:41:34.000+00:00,"""@panjf2000
PTAL\r\nFix #22 \r\nSigned-off-by: Cholerae Hu
<[email protected]>""",,,9158bd37025ccdd29d6346a6639a282e0060c7e2,panichandler,master,812dd4e01075be3cf97429a43abaf6837908cdcd,5bbc9e170bbee27c37bcc30da3da75b4531d1edb,https://github.com/panjf2000/ants/pull/23,choleraehyq,8923413,"{""C
[...]
-1,267414275,134018330,0,30,MERGED,goreport: lint warning on code comment
structure,2019-04-04T11:52:48.000+00:00,2019-04-23T11:11:58.000+00:00,2019-04-23T11:11:58.000+00:00,0,0,0,0,0,0,2019-04-23T11:11:58.000+00:00,"""Added
a newline between group comment and exported variable line
😄""",,,dec04010834ccd3691eb1776045ce3b9310ce26c,patch-1,master,4ae3fb8dc413492862469027bb58cb45b77338f1,ec5d1f3b8107265cb53536975504c7cda4f6d68f,https://github.com/panjf2000/ants/pull/30,sarathsp06,964542,"{""
[...]
-1,292246524,134018330,194015289,36,CLOSED,handle job
panic,2019-06-27T03:27:05.000+00:00,2019-08-17T20:32:55.000+00:00,2019-08-17T20:32:34.000+00:00,0,0,0,0,0,0,,"""""",,,95e11bf85f18a80197918d15a19ec10f41903d63,master,master,05e96abd6103ae7b70436abe58dbc0ad7e740929,39f04c6e65b76b5f20abd3ca0606db4cd038e5c2,https://github.com/panjf2000/ants/pull/36,king526,38849208,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,257,
-1,300598936,134018330,198582966,39,MERGED,优化清理速度并修复内存泄漏,2019-07-24T07:41:02.000+00:00,2019-07-26T04:00:12.000+00:00,2019-07-26T04:00:12.000+00:00,0,0,0,0,0,0,2019-07-26T04:00:12.000+00:00,"""""",,,21a109c7f0873c8f466d6710de23474968940011,master,master,fc48d32604efc2b36d144b8f83d34c1aa1fda1c9,b44a12884b495713a44f796981267ed87134decb,https://github.com/panjf2000/ants/pull/39,wwjiang,1290360,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,258,
-1,301421607,134018330,198955529,40,MERGED,"optimize memory allocation, change
the default pool param and add the log of panic
stack.",2019-07-26T07:07:06.000+00:00,2019-07-26T15:22:26.000+00:00,2019-07-26T15:22:26.000+00:00,0,0,0,0,0,0,2019-07-26T15:22:26.000+00:00,"""Hi,
I am using it on my online server which almost need 5 million goroutines on
each go service.\r\nI'm divided into 10 small pools, because a pool of five
million will slow down the speed associated with the slice.\r\nI ma [...]
-1,308859272,134018330,0,41,MERGED,support nonblocking submit and max blocking
limit
setting,2019-08-20T03:24:27.000+00:00,2019-08-20T11:52:19.000+00:00,2019-08-20T10:55:19.000+00:00,0,0,0,0,0,0,2019-08-20T10:55:19.000+00:00,"""Signed-off-by:
Cholerae Hu
<[email protected]>""",,,faef79b7d8a4876da8a215d7794cce20c710aaa2,nonblocking,master,dc8169d5c2645bfc507d6993b7d215326300f31b,58466b12b03a603d9f0331bbcc64a7557b27865d,https://github.com/panjf2000/ants/pull/41,choleraehyq,8923413,"{""C
[...]
-1,311420898,134018330,134018330,48,MERGED,Create
CODE_OF_CONDUCT.md,2019-08-27T14:44:03.000+00:00,2019-08-28T05:30:30.000+00:00,2019-08-27T14:46:22.000+00:00,0,0,0,0,0,0,2019-08-27T14:46:22.000+00:00,"""""",,,d5eded45bffe827e5a64a3376c4b94f08b641031,add-code-of-conduct-1,master,44aec9954f58987c37d5937ba590bbf0812a32de,bba6c12b60eff3445adcc168fff3bfdcad9e2571,https://github.com/panjf2000/ants/pull/48,panjf2000,7496278,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull
[...]
-1,316337433,134018330,207765423,51,MERGED,Invoke decRunning() when
revertWorker() returns
false,2019-09-11T08:46:23.000+00:00,2019-09-12T01:00:32.000+00:00,2019-09-12T01:00:32.000+00:00,0,0,0,0,0,0,2019-09-12T01:00:32.000+00:00,"""Signed-off-by:
Cholerae Hu <[email protected]>\r\n\r\n---\r\nname: Pull request\r\nabout:
Propose changes to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us mak [...]
-1,325179595,134018330,0,53,MERGED,add loop queue
,2019-10-07T08:17:20.000+00:00,2019-12-26T01:44:41.000+00:00,2019-10-09T16:59:19.000+00:00,0,0,0,0,0,0,2019-10-09T16:59:19.000+00:00,"""---\r\nname:
Pull request\r\nabout: 抽象出worker队列的实现,使用原先和循环队列实现这个接口\r\ntitle: ''\r\nlabels:
''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`!
Please fill this out to help us make the most of your pull request.\r\n\r\nWas
this change discussed in an issue first? That can help sa [...]
-1,329127652,134018330,215736581,54,CLOSED,throw out default
panic,2019-10-17T08:18:41.000+00:00,2019-10-19T05:55:20.000+00:00,2019-10-18T02:07:14.000+00:00,0,0,0,0,0,0,,"""<the
Go programming language>\r\n5.10. Recover\r\nRecovering indiscriminately from
panics is a dubious practice because the state of a package’s variables after a
panic is rarely well defined or documented. Perhaps a critical update to a data
structure was incomplete, a file or net work connection was opened but not cl
[...]
-1,346931859,134018330,0,66,CLOSED,Refine the indentation of the sample code in
READMEs,2019-11-29T07:50:17.000+00:00,2019-11-29T07:57:46.000+00:00,2019-11-29T07:52:04.000+00:00,0,0,0,0,0,0,,"""""",,,1acafed7740d0daf1dcc3a30129798f59c234331,master,master,fd3841dd88c15fcc0e0ea94e606d980221ac5e09,b19edbd7b909527b2cc2a759e7a60133497f9dee,https://github.com/panjf2000/ants/pull/66,RealLiuSha,5715152,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,265,
-1,379435034,134018330,0,79,MERGED,Fix a bug that doesn't release
lock,2020-02-25T08:30:05.000+00:00,2020-05-07T16:12:40.000+00:00,2020-02-26T03:15:03.000+00:00,0,0,0,0,0,0,2020-02-26T03:15:03.000+00:00,"""err!=nil时未释放锁,使用defer
p.lock.Unlock()修复\r\n\r\n---\r\nname: Pull request\r\nabout: Propose changes
to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\ [...]
-1,404931293,134018330,256385795,87,CLOSED,fix:v2 dir not
exist,2020-04-17T05:34:28.000+00:00,2020-04-19T03:03:07.000+00:00,2020-04-19T03:03:07.000+00:00,0,0,0,0,0,0,,"""---\r\nname:
Pull request\r\nabout: Propose changes to the code\r\ntitle: ''\r\nlabels:
''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`!
Please fill this out to help us make the most of your pull request.\r\n\r\nWas
this change discussed in an issue first? That can help save time in case the
[...]
-1,410487606,134018330,259825622,89,MERGED,Fix indent on
README,2020-04-29T04:51:26.000+00:00,2020-06-22T13:58:37.000+00:00,2020-04-29T07:08:43.000+00:00,0,0,0,0,0,0,2020-04-29T07:08:43.000+00:00,"""---\r\nname:
Pull request\r\nabout: Propose changes to the code\r\ntitle: 'Fix
indent'\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for
contributing to `ants`! Please fill this out to help us make the most of your
pull request.\r\n\r\nWas this change discussed in an issue fir [...]
-1,415925259,134018330,0,91,CLOSED,支持配置workerChanCap大小,2020-05-11T07:40:41.000+00:00,2020-05-11T10:15:54.000+00:00,2020-05-11T09:27:30.000+00:00,0,0,0,0,0,0,,"""---\r\nname:
Pull request\r\nabout: support customize workerChanCap \r\ntitle:
''\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for
contributing to `ants`! Please fill this out to help us make the most of your
pull request.\r\n\r\nWas this change discussed in an issue first? That can help
save time in case the cha [...]
-1,452382525,134018330,280806104,100,MERGED,chore: support
go1.14,2020-07-19T06:38:38.000+00:00,2020-07-19T15:00:14.000+00:00,2020-07-19T14:59:48.000+00:00,0,0,0,0,0,0,2020-07-19T14:59:48.000+00:00,"""as
title.""",,,0a7be73d35726850863a80432dec0ac5c78cdfb4,patch,master,b2666199751ef4fe666c175ba667d18a182b67e0,18623ceb17a9230484ff5d1a31c3beb0b631a2f3,https://github.com/panjf2000/ants/pull/100,appleboy,21979,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,270,
-1,461992435,134018330,284629248,103,CLOSED,Add a Gitter chat badge to
README.md,2020-08-03T07:12:25.000+00:00,2020-08-03T07:17:52.000+00:00,2020-08-03T07:17:52.000+00:00,0,0,0,0,0,0,,"""###
panjf2000/ants now has a Chat Room on Gitter\n\n@panjf2000 has just created a
chat room. You can visit it here:
[https://gitter.im/ants-pool/ants](https://gitter.im/ants-pool/ants?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&content=body_link).\n\nThis
pull-request adds this badge to your R [...]
-1,475457581,134018330,0,107,MERGED,Avoid memory
leak,2020-08-28T15:02:33.000+00:00,2020-08-29T10:51:57.000+00:00,2020-08-29T10:51:57.000+00:00,0,0,0,0,0,0,2020-08-29T10:51:57.000+00:00,"""---\r\nname:
Pull request\r\nabout: Propose changes to the code\r\ntitle: 'avoid memory
leaky'\r\nlabels: 'gc'\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for
contributing to `ants`! Please fill this out to help us make the most of your
pull request.\r\n\r\nWas this change discussed in an issue fir [...]
-1,496172205,134018330,300247425,111,CLOSED,Remove underscore from file
names,2020-10-01T11:08:20.000+00:00,2020-10-04T07:42:53.000+00:00,2020-10-04T07:42:53.000+00:00,0,0,0,0,0,0,,"""\r\n##
1. Are you opening this pull request for bug-fixes, optimizations, or new
features?\r\nFixing the file naming convention based on
[this](https://golang.org/doc/effective_go.html#package-names).\r\n\r\n## 2.
Please describe how these code changes achieve your intention.\r\nThere is no
code change\r\n\r [...]
-1,502102437,134018330,303638681,114,MERGED,fix: Memory
leak,2020-10-13T08:37:37.000+00:00,2020-10-15T12:22:42.000+00:00,2020-10-15T03:35:56.000+00:00,0,0,0,0,0,0,2020-10-15T03:35:56.000+00:00,"""Fixes
#113""",,,94a7a7f1cb3a11fcaaf9608c94fe1dc0bcd98ab0,master,master,ef6017217221e20416d886c0231dd5134752ef4e,00691c648a5b7d28dba5bcafa05d9bbccdf4d933,https://github.com/panjf2000/ants/pull/114,Mutated1994,29589055,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,274,
-1,505486248,134018330,305101171,117,CLOSED,fix set negative
size,2020-10-18T14:58:12.000+00:00,2020-10-19T01:58:45.000+00:00,2020-10-19T01:58:45.000+00:00,0,0,0,0,0,0,,"""fix
set negative size for
pool\r\n""",,,55d7f5eb6298d59b76a26b56d1bbb776503a8563,hotfix-poolsize,master,94a7a7f1cb3a11fcaaf9608c94fe1dc0bcd98ab0,05a3664dbf966f1a7ced274aaf47d34e644287ef,https://github.com/panjf2000/ants/pull/117,imxyb,7411249,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,275,
-1,543900177,134018330,323540538,131,CLOSED,Add go1.15.x support on
CI,2020-12-22T06:25:18.000+00:00,2021-03-19T02:15:23.000+00:00,2021-03-19T02:15:23.000+00:00,0,0,0,0,0,0,,"""Add
go1.15.x support on
CI""",,,545d5f0c007d1d5e2cd23ae2d9074365c0f03790,patch-1,master,fd8d670fd09489e6ea7693c0a382ba85d2694f16,15cb2705734c62544ac5dca0de3f28f03a69a854,https://github.com/panjf2000/ants/pull/131,kaiiak,2832687,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,276,
-1,582870188,134018330,343711920,136,CLOSED,Change the writing of
if...err,2021-03-02T09:24:36.000+00:00,2021-03-11T02:27:15.000+00:00,2021-03-11T02:27:15.000+00:00,0,0,0,0,0,0,,"""---\r\nname:
Pull request\r\nabout: Propose changes to the code\r\ntitle: ''\r\nlabels:
''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`!
Please fill this out to help us make the most of your pull request.\r\n\r\nWas
this change discussed in an issue first? That can help save time [...]
-1,586207150,134018330,345288213,139,CLOSED,The program should return directly
when the pool size passed in when
…,2021-03-07T08:00:46.000+00:00,2021-03-12T12:45:57.000+00:00,2021-03-12T12:45:57.000+00:00,0,0,0,0,0,0,,"""…calling
the NewPool interface is less than or equal to 0\r\n\r\n---\r\nname: Pull
request\r\nabout: Propose changes to the code\r\ntitle: 'code
improve'\r\n---\r\n""",,,9a4288b9368ab4551d967fddda163d6be2182fde,feature/zhangyuanxue/dev,master,fd8d670fd09489e6ea7693c0a382b
[...]
-1,607755003,134018330,353622545,149,CLOSED,pool_list,2021-04-02T01:16:21.000+00:00,2021-04-02T05:28:23.000+00:00,2021-04-02T04:09:52.000+00:00,0,0,0,0,0,0,,"""sequence""",,,fd1b0378ee9b60fe32a2fe5c8198a427e5f46949,pool_list,master,dbcb6a104f23b1a6a7521796b30515230353283e,674fe08bb2c2ced275600ebdddf2412c84e2c349,https://github.com/panjf2000/ants/pull/149,yddeng,41562937,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,279,
-1,654684379,134018330,371305210,158,OPEN,Submit a task with args to
pool,2021-05-27T08:53:42.000+00:00,2022-02-22T16:48:28.000+00:00,,0,0,0,0,0,0,,"""---\r\nname:
Resolve problem with args capturing\r\n---\r\n\r\n<!--\r\nThank you for
contributing to `ants`! Please fill this out to help us make the most of your
pull request.\r\n\r\nWas this change discussed in an issue first? That can help
save time in case the change is not a good fit for the project. Not all pull
requests get merged.\r [...]
-1,669972849,134018330,376993065,167,OPEN,allow NewPoolWithFunc can invoke with
nil
argument,2021-06-15T00:57:34.000+00:00,2022-02-22T16:48:28.000+00:00,,0,0,0,0,0,0,,"""2.
abstract a Task interface for SubmitTask which is more
convenient\r\n\r\n---\r\nname: Pull request\r\nabout: Propose changes to the
code\r\ntitle: 'allow NewPoolWithFunc can invoke with nil argument'\r\nlabels:
''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`!
Please fill this out to help [...]
-1,686947632,134018330,384510398,172,MERGED,Timing issue in the
TestNonblockingSubmitWithFunc,2021-07-09T17:43:56.000+00:00,2021-07-12T14:59:39.000+00:00,2021-07-12T14:52:47.000+00:00,0,0,0,0,0,0,2021-07-12T14:52:47.000+00:00,"""On
some machines this unit would fail due to a timing issue. Since the Invoke in
the loop was using nil as the param, it would (depending on timing) lead to the
workers finishing the (w *goWorkerWithFunc) run() in the range loop over
w.args as args would == nil [...]
-1,693963625,134018330,0,174,MERGED,Fix CI workflow to make the cache action
really
work,2021-07-21T00:56:19.000+00:00,2021-07-21T03:29:35.000+00:00,2021-07-21T03:21:49.000+00:00,0,0,0,0,0,0,2021-07-21T03:21:49.000+00:00,"""workflows
add cache mod file\r\nworkflows should be restore cache before unit
test\r\nlink
[actions/cache](https://github.com/marketplace/actions/cache)\r\n---\r\nname:
Pull request\r\nabout: Propose changes to the code\r\ntitle:
'workflows'\r\nlabels: 'workflows'\r\na [...]
-1,696437287,134018330,389252738,176,OPEN,feat: goroutine exits
immediately,2021-07-25T03:44:37.000+00:00,2022-02-22T16:48:28.000+00:00,,0,0,0,0,0,0,,"""---\r\nname:
goroutine exits immediately\r\nabout: goroutine exits immediately, lazy init
defaultAntsPool\r\ntitle: 'goroutine exits immediately'\r\nlabels:
''\r\nassignees: 'panjf2000'\r\n---\r\n\r\n<!--\r\nThank you for contributing
to `ants`! Please fill this out to help us make the most of your pull
request.\r\n\r\nWas this change dis [...]
-1,731946063,134018330,398834222,184,MERGED,style: fixed some typos in the
comments,2021-09-11T15:06:25.000+00:00,2021-09-13T03:57:28.000+00:00,2021-09-13T03:57:25.000+00:00,0,0,0,0,0,0,2021-09-13T03:57:25.000+00:00,"""---\r\nname:
Pull request\r\nabout: typos in comments\r\ntitle: fixed some typos in the
comments\r\nlabels: \r\nassignees: @panjf2000 \r\n---\r\n\r\n<!--\r\nThank you
for contributing to `ants`! Please fill this out to help us make the most of
your pull request.\r\n\r\nWas [...]
-1,736936308,134018330,0,185,MERGED,Update the link of one of the relevant
articles,2021-09-18T17:06:03.000+00:00,2021-09-19T17:24:49.000+00:00,2021-09-19T02:56:40.000+00:00,0,0,0,0,0,0,2021-09-19T02:56:40.000+00:00,"""Hello!
I never got the chance to mention it before, but thank you for linking one of
my articles in your repository :) \r\n\r\n## 1. Are you opening this pull
request for bug-fixs, optimizations or new feature?\r\nNo\r\n\r\n\r\n## 2.
Please describe how these code changes a [...]
-1,742901118,134018330,0,186,MERGED,Update the link of one of the relevant
articles,2021-09-26T15:53:39.000+00:00,2021-09-27T03:44:34.000+00:00,2021-09-27T02:38:55.000+00:00,0,0,0,0,0,0,2021-09-27T02:38:55.000+00:00,"""re:
#185\r\n\r\nMissed the `README_ZH.md` file 😅
""",,,3f9c4cd54898e7149c7f6d072213b8fdbd0036d8,patch-1,master,61d120b6f086998184f402a83ace485a036d4c7d,41f6b572b25da6363d7d7c45b77705fd8bee7466,https://github.com/panjf2000/ants/pull/186,TwiN,15699766,"{""ConnectionId"":1,""N
[...]
-1,757412327,134018330,416596451,189,MERGED,add shopify into user
cases,2021-10-13T13:34:05.000+00:00,2021-10-13T13:42:53.000+00:00,2021-10-13T13:42:42.000+00:00,0,0,0,0,0,0,2021-10-13T13:42:42.000+00:00,"""Fixes
https://github.com/panjf2000/ants/issues/188""",,,76ce0ce24f21b1dd13050e0c84b07ce55e68f111,add-shopify-as-user-case,master,3f9c4cd54898e7149c7f6d072213b8fdbd0036d8,efe0bad6c0ab13b54d00909864e34a1060e41d6e,https://github.com/panjf2000/ants/pull/189,lilien1010,3814966,"{""Connectio
[...]
-1,763816683,134018330,419934243,192,CLOSED,add more test about
spinlock,2021-10-22T02:53:44.000+00:00,2021-11-27T13:44:28.000+00:00,2021-11-27T13:44:28.000+00:00,0,0,0,0,0,0,,"""---\r\nname:
Pull request\r\nabout: add more test about spinlock\r\ntitle: ''\r\nlabels:
''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`!
Please fill this out to help us make the most of your pull request.\r\n\r\nWas
this change discussed in an issue first? That can help save time [...]
-1,770998086,134018330,423301234,193,CLOSED,Replace goto with simple for
loop,2021-11-02T00:36:11.000+00:00,2021-11-18T14:44:47.000+00:00,2021-11-18T14:44:40.000+00:00,0,0,0,0,0,0,,"""---\r\nname:
Pull request\r\nabout: Replace goto with simple for loop\r\ntitle: 'Replace
goto with simple for loop'\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\r\nWas this change
discussed i [...]
-1,791490205,134018330,0,198,CLOSED,optimize: calculating mid in binary
search,2021-11-30T09:34:02.000+00:00,2021-12-01T00:42:16.000+00:00,2021-12-01T00:42:16.000+00:00,0,0,0,0,0,0,,"""---\r\nname:
Pull request\r\nabout: Propose changes to the code\r\ntitle: ''\r\nlabels:
''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`!
Please fill this out to help us make the most of your pull request.\r\n\r\nWas
this change discussed in an issue first? That can help save t [...]
-1,816835878,134018330,445578800,206,MERGED,Add binarysearch of loop
queue,2022-01-08T10:06:36.000+00:00,2022-01-31T02:49:04.000+00:00,2022-01-31T02:49:03.000+00:00,0,0,0,0,0,0,2022-01-31T02:49:03.000+00:00,"""---\r\nname:
Pull request\r\nabout: Add binarysearch method to loop_queue to get expired
workers, just like worker_stack.\r\ntitle: ''\r\nlabels: ''\r\nassignees:
'bright2227'\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please
fill this out to help us make the most [...]
-1,835038436,134018330,449536867,210,MERGED,Awake the blocking callers when
Tune(size int) is invoked to expand the
pool,2022-01-29T08:01:24.000+00:00,2022-04-14T17:31:43.000+00:00,2022-02-14T13:51:41.000+00:00,0,0,0,0,0,0,2022-02-14T13:51:40.000+00:00,"""…capacity\r\n\r\n---\r\nname:
Pull request\r\nabout: Propose changes to the code\r\ntitle: 'Instantly scale
up capacity when using Tune(size int) to enlarge the capacity'\r\nlabels:
'enhancement'\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nTh [...]
-1,842184289,134018330,456662951,211,OPEN,Remove worker_func.go and modify
pool_func.go simplifying the
library,2022-02-07T21:31:30.000+00:00,2022-02-22T16:48:28.000+00:00,,0,0,0,0,0,0,,"""---\r\nname:
Remove worker_func.go and modify pool_func.go simplifying the
library\r\nabout: Remove worker_func.go and modify pool_func.go to simply
utilize the non-func pool+worker implementation\r\ntitle: 'Remove
worker_func.go and modify pool_func.go simplifying the library'\r\nlabels:
''\r\nassignee [...]
+1,203756736,134018330,142234748,4,closed,pre-allocate the capacity of the
worker listpre-allocate the capacity of the worker listpre-allocate the
capacity of the worker listpre-allocate the capacity of the worker
listpre-allocate the capacity of the worker listpre-allocate the capacity of
the worker listpre-allocate the capacity of the worker listpre-allocate the
capacity of the worker listpre-allocate the capacity of the worker
listpre-allocate the capacity of the worker listpre-allocat [...]
+1,211603583,134018330,0,8,closed,fix goroutine
leak,2018-08-29T01:35:54.000+00:00,2018-10-30T00:12:13.000+00:00,2018-10-30T00:12:13.000+00:00,0,0,0,0,0,0,,"""n++,
will cause workers[0]
leak""",,,74ba726f34abe487b7defac6bb9bebf24d342377,dev,master,666635c65d8d3bb1223b819325e0bd23c81f2733,afd687164b13280199208ec4869709edcf02b52d,https://github.com/panjf2000/ants/pull/8,hongli-my,8597823,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,247,
+1,212277907,134018330,146845386,9,closed,Update
pool.go,2018-08-31T05:29:36.000+00:00,2018-08-31T13:40:33.000+00:00,2018-08-31T13:40:33.000+00:00,0,0,0,0,0,0,,"""#活着的孩子不想当孤儿\r\n\tHopefully:\r\n\tchildren
:= []*child{C1,C2,C3,C4,C5,C6,C7}\r\n\tIn fact:\r\n\tchildren :=
[]*child{C1,C4,C2,C3,C5,C6,C7}""",,,f14d3f91f68d0bc23fe42aa413e98005f6575045,patch-1,master,666635c65d8d3bb1223b819325e0bd23c81f2733,2726d42ea62857283ee73ef3611e379b60974ad2,https://github.com/panjf2000/ants/pull/9,Nonnnnnn
[...]
+1,216254598,134018330,149267177,11,closed,graceful
exit,2018-09-18T10:15:01.000+00:00,2018-12-03T03:52:35.000+00:00,2018-12-03T03:52:35.000+00:00,0,0,0,0,0,0,,"""graceful
exit""",,,6a87067eb3d6440e5db17f31d4bc12ac291633f4,master,develop,833b6e29acfb2f16e3cf7fc92c79763847c319f4,a03eccc794870f0a2e55a5cb8344ea47f2a0001d,https://github.com/panjf2000/ants/pull/11,shanhuhai5739,3794113,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,249,
+1,218939809,134018330,150579999,13,closed,❓解决死循环导致cpu占用率过高,2018-09-28T11:37:28.000+00:00,2018-09-29T11:29:54.000+00:00,2018-09-29T11:29:54.000+00:00,0,0,0,0,0,0,2018-09-29T11:29:54.000+00:00,"""使用了cond
条件变量来阻塞Submit
goroutine。潘少,你再仔细琢磨琢磨,看下有何不妥?""",,,9a3b5cd25344822bca7684f87d9e123890a7bf59,master,master,af376f1b7b59dc488458bcecd4273f0fcde33c55,1846b4392a3a20e6bf1a7431b67f86bd43e0f0b9,https://github.com/panjf2000/ants/pull/13,liyonglion,12890888,"{""ConnectionId"":1,""Name"":""panjf2000/
[...]
+1,219363161,134018330,0,14,closed,Remove meaningless if
statements,2018-10-01T12:48:11.000+00:00,2018-10-02T13:52:27.000+00:00,2018-10-02T13:52:27.000+00:00,0,0,0,0,0,0,2018-10-02T13:52:27.000+00:00,"""""",,,29730bb70343924a2f56a13a9799611dd1cd27fd,master,master,1b62696050b7030106291980d5220f886b017eff,5ed168767a771e3802252020b9821610380ed1a4,https://github.com/panjf2000/ants/pull/14,SimePel,20608155,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,251,
+1,219936521,134018330,0,15,closed,Fixes to benchmarks and added semaphore
comparison,2018-10-03T07:16:16.000+00:00,2018-10-03T12:38:57.000+00:00,2018-10-03T12:33:59.000+00:00,0,0,0,0,0,0,2018-10-03T12:33:59.000+00:00,"""Benchmark
results with Param=0, as time.Sleep is not stable on Windows\r\n\r\nAlso Go
1.11 has bunch of improvements:\r\n\r\n```\r\ngoos: windows\r\ngoarch:
amd64\r\npkg: github.com/panjf2000/ants\r\nBenchmarkGoroutineWithFunc-8
1 3530220300 ns/op [...]
+1,222703171,134018330,152956614,16,closed,bugfix(check max pool
size),2018-10-14T09:21:41.000+00:00,2018-12-03T03:53:31.000+00:00,2018-12-03T03:53:31.000+00:00,0,0,0,0,0,0,,"""if
you limit max goroutine to math.Maxint32 as your code `int32(pool size)`\r\nI
think should check max Goroutine size, otherwise size overflow to
negative?\r\n""",,,1399cfa28f6751f769a985206daecb56a08b2de9,bugfix_check_max_pool_size,master,711dbdb7a222771ce15aaee1bb7b7c6e9731f208,439348b027031c793e54669fcd74eb496
[...]
+1,231840723,134018330,158152223,19,closed,Possible memory leak because of
Ticker,2018-11-19T03:03:09.000+00:00,2018-12-01T15:49:32.000+00:00,2018-12-01T15:49:32.000+00:00,0,0,0,0,0,0,2018-12-01T15:49:32.000+00:00,"""//
NewTicker returns a new Ticker containing a channel that will send the\r\n//
time with a period specified by the duration argument.\r\n// It adjusts the
intervals or drops ticks to make up for slow receivers.\r\n// The duration d
must be greater than zero; if not, NewTicke [...]
+1,246250598,134018330,0,23,closed,feature: add
PanicHandler,2019-01-21T10:58:15.000+00:00,2019-01-22T05:41:34.000+00:00,2019-01-22T05:41:34.000+00:00,0,0,0,0,0,0,2019-01-22T05:41:34.000+00:00,"""@panjf2000
PTAL\r\nFix #22 \r\nSigned-off-by: Cholerae Hu
<[email protected]>""",,,9158bd37025ccdd29d6346a6639a282e0060c7e2,panichandler,master,812dd4e01075be3cf97429a43abaf6837908cdcd,5bbc9e170bbee27c37bcc30da3da75b4531d1edb,https://github.com/panjf2000/ants/pull/23,choleraehyq,8923413,"{""C
[...]
+1,267414275,134018330,0,30,closed,goreport: lint warning on code comment
structure,2019-04-04T11:52:48.000+00:00,2019-04-23T11:11:58.000+00:00,2019-04-23T11:11:58.000+00:00,0,0,0,0,0,0,2019-04-23T11:11:58.000+00:00,"""Added
a newline between group comment and exported variable line
😄""",,,dec04010834ccd3691eb1776045ce3b9310ce26c,patch-1,master,4ae3fb8dc413492862469027bb58cb45b77338f1,ec5d1f3b8107265cb53536975504c7cda4f6d68f,https://github.com/panjf2000/ants/pull/30,sarathsp06,964542,"{""
[...]
+1,292246524,134018330,194015289,36,closed,handle job
panic,2019-06-27T03:27:05.000+00:00,2019-08-17T20:32:55.000+00:00,2019-08-17T20:32:34.000+00:00,0,0,0,0,0,0,,"""""",,,95e11bf85f18a80197918d15a19ec10f41903d63,master,master,05e96abd6103ae7b70436abe58dbc0ad7e740929,39f04c6e65b76b5f20abd3ca0606db4cd038e5c2,https://github.com/panjf2000/ants/pull/36,king526,38849208,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,257,
+1,300598936,134018330,198582966,39,closed,优化清理速度并修复内存泄漏,2019-07-24T07:41:02.000+00:00,2019-07-26T04:00:12.000+00:00,2019-07-26T04:00:12.000+00:00,0,0,0,0,0,0,2019-07-26T04:00:12.000+00:00,"""""",,,21a109c7f0873c8f466d6710de23474968940011,master,master,fc48d32604efc2b36d144b8f83d34c1aa1fda1c9,b44a12884b495713a44f796981267ed87134decb,https://github.com/panjf2000/ants/pull/39,wwjiang,1290360,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,258,
+1,301421607,134018330,198955529,40,closed,"optimize memory allocation, change
the default pool param and add the log of panic
stack.",2019-07-26T07:07:06.000+00:00,2019-07-26T15:22:26.000+00:00,2019-07-26T15:22:26.000+00:00,0,0,0,0,0,0,2019-07-26T15:22:26.000+00:00,"""Hi,
I am using it on my online server which almost need 5 million goroutines on
each go service.\r\nI'm divided into 10 small pools, because a pool of five
million will slow down the speed associated with the slice.\r\nI ma [...]
+1,308859272,134018330,0,41,closed,support nonblocking submit and max blocking
limit
setting,2019-08-20T03:24:27.000+00:00,2019-08-20T11:52:19.000+00:00,2019-08-20T10:55:19.000+00:00,0,0,0,0,0,0,2019-08-20T10:55:19.000+00:00,"""Signed-off-by:
Cholerae Hu
<[email protected]>""",,,faef79b7d8a4876da8a215d7794cce20c710aaa2,nonblocking,master,dc8169d5c2645bfc507d6993b7d215326300f31b,58466b12b03a603d9f0331bbcc64a7557b27865d,https://github.com/panjf2000/ants/pull/41,choleraehyq,8923413,"{""C
[...]
+1,311420898,134018330,134018330,48,closed,Create
CODE_OF_CONDUCT.md,2019-08-27T14:44:03.000+00:00,2019-08-28T05:30:30.000+00:00,2019-08-27T14:46:22.000+00:00,0,0,0,0,0,0,2019-08-27T14:46:22.000+00:00,"""""",,,d5eded45bffe827e5a64a3376c4b94f08b641031,add-code-of-conduct-1,master,44aec9954f58987c37d5937ba590bbf0812a32de,bba6c12b60eff3445adcc168fff3bfdcad9e2571,https://github.com/panjf2000/ants/pull/48,panjf2000,7496278,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull
[...]
+1,316337433,134018330,207765423,51,closed,Invoke decRunning() when
revertWorker() returns
false,2019-09-11T08:46:23.000+00:00,2019-09-12T01:00:32.000+00:00,2019-09-12T01:00:32.000+00:00,0,0,0,0,0,0,2019-09-12T01:00:32.000+00:00,"""Signed-off-by:
Cholerae Hu <[email protected]>\r\n\r\n---\r\nname: Pull request\r\nabout:
Propose changes to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us mak [...]
+1,325179595,134018330,0,53,closed,add loop queue
,2019-10-07T08:17:20.000+00:00,2019-12-26T01:44:41.000+00:00,2019-10-09T16:59:19.000+00:00,0,0,0,0,0,0,2019-10-09T16:59:19.000+00:00,"""---\r\nname:
Pull request\r\nabout: 抽象出worker队列的实现,使用原先和循环队列实现这个接口\r\ntitle: ''\r\nlabels:
''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`!
Please fill this out to help us make the most of your pull request.\r\n\r\nWas
this change discussed in an issue first? That can help sa [...]
+1,329127652,134018330,215736581,54,closed,throw out default
panic,2019-10-17T08:18:41.000+00:00,2019-10-19T05:55:20.000+00:00,2019-10-18T02:07:14.000+00:00,0,0,0,0,0,0,,"""<the
Go programming language>\r\n5.10. Recover\r\nRecovering indiscriminately from
panics is a dubious practice because the state of a package’s variables after a
panic is rarely well defined or documented. Perhaps a critical update to a data
structure was incomplete, a file or net work connection was opened but not cl
[...]
+1,346931859,134018330,0,66,closed,Refine the indentation of the sample code in
READMEs,2019-11-29T07:50:17.000+00:00,2019-11-29T07:57:46.000+00:00,2019-11-29T07:52:04.000+00:00,0,0,0,0,0,0,,"""""",,,1acafed7740d0daf1dcc3a30129798f59c234331,master,master,fd3841dd88c15fcc0e0ea94e606d980221ac5e09,b19edbd7b909527b2cc2a759e7a60133497f9dee,https://github.com/panjf2000/ants/pull/66,RealLiuSha,5715152,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,265,
+1,379435034,134018330,0,79,closed,Fix a bug that doesn't release
lock,2020-02-25T08:30:05.000+00:00,2020-05-07T16:12:40.000+00:00,2020-02-26T03:15:03.000+00:00,0,0,0,0,0,0,2020-02-26T03:15:03.000+00:00,"""err!=nil时未释放锁,使用defer
p.lock.Unlock()修复\r\n\r\n---\r\nname: Pull request\r\nabout: Propose changes
to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\ [...]
+1,404931293,134018330,256385795,87,closed,fix:v2 dir not
exist,2020-04-17T05:34:28.000+00:00,2020-04-19T03:03:07.000+00:00,2020-04-19T03:03:07.000+00:00,0,0,0,0,0,0,,"""---\r\nname:
Pull request\r\nabout: Propose changes to the code\r\ntitle: ''\r\nlabels:
''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`!
Please fill this out to help us make the most of your pull request.\r\n\r\nWas
this change discussed in an issue first? That can help save time in case the
[...]
+1,410487606,134018330,259825622,89,closed,Fix indent on
README,2020-04-29T04:51:26.000+00:00,2020-06-22T13:58:37.000+00:00,2020-04-29T07:08:43.000+00:00,0,0,0,0,0,0,2020-04-29T07:08:43.000+00:00,"""---\r\nname:
Pull request\r\nabout: Propose changes to the code\r\ntitle: 'Fix
indent'\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for
contributing to `ants`! Please fill this out to help us make the most of your
pull request.\r\n\r\nWas this change discussed in an issue fir [...]
+1,415925259,134018330,0,91,closed,支持配置workerChanCap大小,2020-05-11T07:40:41.000+00:00,2020-05-11T10:15:54.000+00:00,2020-05-11T09:27:30.000+00:00,0,0,0,0,0,0,,"""---\r\nname:
Pull request\r\nabout: support customize workerChanCap \r\ntitle:
''\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for
contributing to `ants`! Please fill this out to help us make the most of your
pull request.\r\n\r\nWas this change discussed in an issue first? That can help
save time in case the cha [...]
+1,452382525,134018330,280806104,100,closed,chore: support
go1.14,2020-07-19T06:38:38.000+00:00,2020-07-19T15:00:14.000+00:00,2020-07-19T14:59:48.000+00:00,0,0,0,0,0,0,2020-07-19T14:59:48.000+00:00,"""as
title.""",,,0a7be73d35726850863a80432dec0ac5c78cdfb4,patch,master,b2666199751ef4fe666c175ba667d18a182b67e0,18623ceb17a9230484ff5d1a31c3beb0b631a2f3,https://github.com/panjf2000/ants/pull/100,appleboy,21979,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,270,
+1,461992435,134018330,284629248,103,closed,Add a Gitter chat badge to
README.md,2020-08-03T07:12:25.000+00:00,2020-08-03T07:17:52.000+00:00,2020-08-03T07:17:52.000+00:00,0,0,0,0,0,0,,"""###
panjf2000/ants now has a Chat Room on Gitter\n\n@panjf2000 has just created a
chat room. You can visit it here:
[https://gitter.im/ants-pool/ants](https://gitter.im/ants-pool/ants?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&content=body_link).\n\nThis
pull-request adds this badge to your R [...]
+1,475457581,134018330,0,107,closed,Avoid memory
leak,2020-08-28T15:02:33.000+00:00,2020-08-29T10:51:57.000+00:00,2020-08-29T10:51:57.000+00:00,0,0,0,0,0,0,2020-08-29T10:51:57.000+00:00,"""---\r\nname:
Pull request\r\nabout: Propose changes to the code\r\ntitle: 'avoid memory
leaky'\r\nlabels: 'gc'\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for
contributing to `ants`! Please fill this out to help us make the most of your
pull request.\r\n\r\nWas this change discussed in an issue fir [...]
+1,496172205,134018330,300247425,111,closed,Remove underscore from file
names,2020-10-01T11:08:20.000+00:00,2020-10-04T07:42:53.000+00:00,2020-10-04T07:42:53.000+00:00,0,0,0,0,0,0,,"""\r\n##
1. Are you opening this pull request for bug-fixes, optimizations, or new
features?\r\nFixing the file naming convention based on
[this](https://golang.org/doc/effective_go.html#package-names).\r\n\r\n## 2.
Please describe how these code changes achieve your intention.\r\nThere is no
code change\r\n\r [...]
+1,502102437,134018330,303638681,114,closed,fix: Memory
leak,2020-10-13T08:37:37.000+00:00,2020-10-15T12:22:42.000+00:00,2020-10-15T03:35:56.000+00:00,0,0,0,0,0,0,2020-10-15T03:35:56.000+00:00,"""Fixes
#113""",,,94a7a7f1cb3a11fcaaf9608c94fe1dc0bcd98ab0,master,master,ef6017217221e20416d886c0231dd5134752ef4e,00691c648a5b7d28dba5bcafa05d9bbccdf4d933,https://github.com/panjf2000/ants/pull/114,Mutated1994,29589055,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,274,
+1,505486248,134018330,305101171,117,closed,fix set negative
size,2020-10-18T14:58:12.000+00:00,2020-10-19T01:58:45.000+00:00,2020-10-19T01:58:45.000+00:00,0,0,0,0,0,0,,"""fix
set negative size for
pool\r\n""",,,55d7f5eb6298d59b76a26b56d1bbb776503a8563,hotfix-poolsize,master,94a7a7f1cb3a11fcaaf9608c94fe1dc0bcd98ab0,05a3664dbf966f1a7ced274aaf47d34e644287ef,https://github.com/panjf2000/ants/pull/117,imxyb,7411249,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,275,
+1,543900177,134018330,323540538,131,closed,Add go1.15.x support on
CI,2020-12-22T06:25:18.000+00:00,2021-03-19T02:15:23.000+00:00,2021-03-19T02:15:23.000+00:00,0,0,0,0,0,0,,"""Add
go1.15.x support on
CI""",,,545d5f0c007d1d5e2cd23ae2d9074365c0f03790,patch-1,master,fd8d670fd09489e6ea7693c0a382ba85d2694f16,15cb2705734c62544ac5dca0de3f28f03a69a854,https://github.com/panjf2000/ants/pull/131,kaiiak,2832687,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,276,
+1,582870188,134018330,343711920,136,closed,Change the writing of
if...err,2021-03-02T09:24:36.000+00:00,2021-03-11T02:27:15.000+00:00,2021-03-11T02:27:15.000+00:00,0,0,0,0,0,0,,"""---\r\nname:
Pull request\r\nabout: Propose changes to the code\r\ntitle: ''\r\nlabels:
''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`!
Please fill this out to help us make the most of your pull request.\r\n\r\nWas
this change discussed in an issue first? That can help save time [...]
+1,586207150,134018330,345288213,139,closed,The program should return directly
when the pool size passed in when
…,2021-03-07T08:00:46.000+00:00,2021-03-12T12:45:57.000+00:00,2021-03-12T12:45:57.000+00:00,0,0,0,0,0,0,,"""…calling
the NewPool interface is less than or equal to 0\r\n\r\n---\r\nname: Pull
request\r\nabout: Propose changes to the code\r\ntitle: 'code
improve'\r\n---\r\n""",,,9a4288b9368ab4551d967fddda163d6be2182fde,feature/zhangyuanxue/dev,master,fd8d670fd09489e6ea7693c0a382b
[...]
+1,607755003,134018330,353622545,149,closed,pool_list,2021-04-02T01:16:21.000+00:00,2021-04-02T05:28:23.000+00:00,2021-04-02T04:09:52.000+00:00,0,0,0,0,0,0,,"""sequence""",,,fd1b0378ee9b60fe32a2fe5c8198a427e5f46949,pool_list,master,dbcb6a104f23b1a6a7521796b30515230353283e,674fe08bb2c2ced275600ebdddf2412c84e2c349,https://github.com/panjf2000/ants/pull/149,yddeng,41562937,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,279,
+1,654684379,134018330,371305210,158,open,Submit a task with args to
pool,2021-05-27T08:53:42.000+00:00,2022-02-22T16:48:28.000+00:00,,0,0,0,0,0,0,,"""---\r\nname:
Resolve problem with args capturing\r\n---\r\n\r\n<!--\r\nThank you for
contributing to `ants`! Please fill this out to help us make the most of your
pull request.\r\n\r\nWas this change discussed in an issue first? That can help
save time in case the change is not a good fit for the project. Not all pull
requests get merged.\r [...]
+1,669972849,134018330,376993065,167,open,allow NewPoolWithFunc can invoke with
nil
argument,2021-06-15T00:57:34.000+00:00,2022-02-22T16:48:28.000+00:00,,0,0,0,0,0,0,,"""2.
abstract a Task interface for SubmitTask which is more
convenient\r\n\r\n---\r\nname: Pull request\r\nabout: Propose changes to the
code\r\ntitle: 'allow NewPoolWithFunc can invoke with nil argument'\r\nlabels:
''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`!
Please fill this out to help [...]
+1,686947632,134018330,384510398,172,closed,Timing issue in the
TestNonblockingSubmitWithFunc,2021-07-09T17:43:56.000+00:00,2021-07-12T14:59:39.000+00:00,2021-07-12T14:52:47.000+00:00,0,0,0,0,0,0,2021-07-12T14:52:47.000+00:00,"""On
some machines this unit would fail due to a timing issue. Since the Invoke in
the loop was using nil as the param, it would (depending on timing) lead to the
workers finishing the (w *goWorkerWithFunc) run() in the range loop over
w.args as args would == nil [...]
+1,693963625,134018330,0,174,closed,Fix CI workflow to make the cache action
really
work,2021-07-21T00:56:19.000+00:00,2021-07-21T03:29:35.000+00:00,2021-07-21T03:21:49.000+00:00,0,0,0,0,0,0,2021-07-21T03:21:49.000+00:00,"""workflows
add cache mod file\r\nworkflows should be restore cache before unit
test\r\nlink
[actions/cache](https://github.com/marketplace/actions/cache)\r\n---\r\nname:
Pull request\r\nabout: Propose changes to the code\r\ntitle:
'workflows'\r\nlabels: 'workflows'\r\na [...]
+1,696437287,134018330,389252738,176,open,feat: goroutine exits
immediately,2021-07-25T03:44:37.000+00:00,2022-02-22T16:48:28.000+00:00,,0,0,0,0,0,0,,"""---\r\nname:
goroutine exits immediately\r\nabout: goroutine exits immediately, lazy init
defaultAntsPool\r\ntitle: 'goroutine exits immediately'\r\nlabels:
''\r\nassignees: 'panjf2000'\r\n---\r\n\r\n<!--\r\nThank you for contributing
to `ants`! Please fill this out to help us make the most of your pull
request.\r\n\r\nWas this change dis [...]
+1,731946063,134018330,398834222,184,closed,style: fixed some typos in the
comments,2021-09-11T15:06:25.000+00:00,2021-09-13T03:57:28.000+00:00,2021-09-13T03:57:25.000+00:00,0,0,0,0,0,0,2021-09-13T03:57:25.000+00:00,"""---\r\nname:
Pull request\r\nabout: typos in comments\r\ntitle: fixed some typos in the
comments\r\nlabels: \r\nassignees: @panjf2000 \r\n---\r\n\r\n<!--\r\nThank you
for contributing to `ants`! Please fill this out to help us make the most of
your pull request.\r\n\r\nWas [...]
+1,736936308,134018330,0,185,closed,Update the link of one of the relevant
articles,2021-09-18T17:06:03.000+00:00,2021-09-19T17:24:49.000+00:00,2021-09-19T02:56:40.000+00:00,0,0,0,0,0,0,2021-09-19T02:56:40.000+00:00,"""Hello!
I never got the chance to mention it before, but thank you for linking one of
my articles in your repository :) \r\n\r\n## 1. Are you opening this pull
request for bug-fixs, optimizations or new feature?\r\nNo\r\n\r\n\r\n## 2.
Please describe how these code changes a [...]
+1,742901118,134018330,0,186,closed,Update the link of one of the relevant
articles,2021-09-26T15:53:39.000+00:00,2021-09-27T03:44:34.000+00:00,2021-09-27T02:38:55.000+00:00,0,0,0,0,0,0,2021-09-27T02:38:55.000+00:00,"""re:
#185\r\n\r\nMissed the `README_ZH.md` file 😅
""",,,3f9c4cd54898e7149c7f6d072213b8fdbd0036d8,patch-1,master,61d120b6f086998184f402a83ace485a036d4c7d,41f6b572b25da6363d7d7c45b77705fd8bee7466,https://github.com/panjf2000/ants/pull/186,TwiN,15699766,"{""ConnectionId"":1,""N
[...]
+1,757412327,134018330,416596451,189,closed,add shopify into user
cases,2021-10-13T13:34:05.000+00:00,2021-10-13T13:42:53.000+00:00,2021-10-13T13:42:42.000+00:00,0,0,0,0,0,0,2021-10-13T13:42:42.000+00:00,"""Fixes
https://github.com/panjf2000/ants/issues/188""",,,76ce0ce24f21b1dd13050e0c84b07ce55e68f111,add-shopify-as-user-case,master,3f9c4cd54898e7149c7f6d072213b8fdbd0036d8,efe0bad6c0ab13b54d00909864e34a1060e41d6e,https://github.com/panjf2000/ants/pull/189,lilien1010,3814966,"{""Connectio
[...]
+1,763816683,134018330,419934243,192,closed,add more test about
spinlock,2021-10-22T02:53:44.000+00:00,2021-11-27T13:44:28.000+00:00,2021-11-27T13:44:28.000+00:00,0,0,0,0,0,0,,"""---\r\nname:
Pull request\r\nabout: add more test about spinlock\r\ntitle: ''\r\nlabels:
''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`!
Please fill this out to help us make the most of your pull request.\r\n\r\nWas
this change discussed in an issue first? That can help save time [...]
+1,770998086,134018330,423301234,193,closed,Replace goto with simple for
loop,2021-11-02T00:36:11.000+00:00,2021-11-18T14:44:47.000+00:00,2021-11-18T14:44:40.000+00:00,0,0,0,0,0,0,,"""---\r\nname:
Pull request\r\nabout: Replace goto with simple for loop\r\ntitle: 'Replace
goto with simple for loop'\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\r\nWas this change
discussed i [...]
+1,791490205,134018330,0,198,closed,optimize: calculating mid in binary
search,2021-11-30T09:34:02.000+00:00,2021-12-01T00:42:16.000+00:00,2021-12-01T00:42:16.000+00:00,0,0,0,0,0,0,,"""---\r\nname:
Pull request\r\nabout: Propose changes to the code\r\ntitle: ''\r\nlabels:
''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`!
Please fill this out to help us make the most of your pull request.\r\n\r\nWas
this change discussed in an issue first? That can help save t [...]
+1,816835878,134018330,445578800,206,closed,Add binarysearch of loop
queue,2022-01-08T10:06:36.000+00:00,2022-01-31T02:49:04.000+00:00,2022-01-31T02:49:03.000+00:00,0,0,0,0,0,0,2022-01-31T02:49:03.000+00:00,"""---\r\nname:
Pull request\r\nabout: Add binarysearch method to loop_queue to get expired
workers, just like worker_stack.\r\ntitle: ''\r\nlabels: ''\r\nassignees:
'bright2227'\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please
fill this out to help us make the most [...]
+1,835038436,134018330,449536867,210,closed,Awake the blocking callers when
Tune(size int) is invoked to expand the
pool,2022-01-29T08:01:24.000+00:00,2022-04-14T17:31:43.000+00:00,2022-02-14T13:51:41.000+00:00,0,0,0,0,0,0,2022-02-14T13:51:40.000+00:00,"""…capacity\r\n\r\n---\r\nname:
Pull request\r\nabout: Propose changes to the code\r\ntitle: 'Instantly scale
up capacity when using Tune(size int) to enlarge the capacity'\r\nlabels:
'enhancement'\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nTh [...]
+1,842184289,134018330,456662951,211,open,Remove worker_func.go and modify
pool_func.go simplifying the
library,2022-02-07T21:31:30.000+00:00,2022-02-22T16:48:28.000+00:00,,0,0,0,0,0,0,,"""---\r\nname:
Remove worker_func.go and modify pool_func.go simplifying the
library\r\nabout: Remove worker_func.go and modify pool_func.go to simply
utilize the non-func pool+worker implementation\r\ntitle: 'Remove
worker_func.go and modify pool_func.go simplifying the library'\r\nlabels:
''\r\nassignee [...]
diff --git a/backend/plugins/github/e2e/snapshot_tables/pull_requests.csv
b/backend/plugins/github/e2e/snapshot_tables/pull_requests.csv
index 2f3c224b9..5c68cf265 100644
--- a/backend/plugins/github/e2e/snapshot_tables/pull_requests.csv
+++ b/backend/plugins/github/e2e/snapshot_tables/pull_requests.csv
@@ -1,50 +1,50 @@
-id,base_repo_id,head_repo_id,status,title,description,url,author_name,author_id,parent_pr_id,pull_request_key,created_date,merged_date,closed_date,type,component,merge_commit_sha,head_ref,base_ref,base_commit_sha,head_commit_sha,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark
-github:GithubPullRequest:1:203756736,github:GithubRepo:1:134018330,github:GithubRepo:1:142234748,MERGED,pre-allocate
the capacity of the worker listpre-allocate the capacity of the worker
listpre-allocate the capacity of the worker listpre-allocate the capacity of
the worker listpre-allocate the capacity of the worker listpre-allocate the
capacity of the worker listpre-allocate the capacity of the worker
listpre-allocate the capacity of the worker listpre-allocate the capacity of
the wor [...]
-github:GithubPullRequest:1:211603583,github:GithubRepo:1:134018330,github:GithubRepo:1:0,CLOSED,fix
goroutine leak,"""n++, will cause workers[0]
leak""",https://github.com/panjf2000/ants/pull/8,hongli-my,github:GithubAccount:1:8597823,,8,2018-08-29T01:35:54.000+00:00,,2018-10-30T00:12:13.000+00:00,,,74ba726f34abe487b7defac6bb9bebf24d342377,dev,master,666635c65d8d3bb1223b819325e0bd23c81f2733,afd687164b13280199208ec4869709edcf02b52d,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw
[...]
-github:GithubPullRequest:1:212277907,github:GithubRepo:1:134018330,github:GithubRepo:1:146845386,CLOSED,Update
pool.go,"""#活着的孩子不想当孤儿\r\n\tHopefully:\r\n\tchildren :=
[]*child{C1,C2,C3,C4,C5,C6,C7}\r\n\tIn fact:\r\n\tchildren :=
[]*child{C1,C4,C2,C3,C5,C6,C7}""",https://github.com/panjf2000/ants/pull/9,Nonnnnnnnnn,github:GithubAccount:1:42808204,,9,2018-08-31T05:29:36.000+00:00,,2018-08-31T13:40:33.000+00:00,,,f14d3f91f68d0bc23fe42aa413e98005f6575045,patch-1,master,666635c65d8d3bb1223b81
[...]
-github:GithubPullRequest:1:216254598,github:GithubRepo:1:134018330,github:GithubRepo:1:149267177,CLOSED,graceful
exit,"""graceful
exit""",https://github.com/panjf2000/ants/pull/11,shanhuhai5739,github:GithubAccount:1:3794113,,11,2018-09-18T10:15:01.000+00:00,,2018-12-03T03:52:35.000+00:00,,,6a87067eb3d6440e5db17f31d4bc12ac291633f4,master,develop,833b6e29acfb2f16e3cf7fc92c79763847c319f4,a03eccc794870f0a2e55a5cb8344ea47f2a0001d,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github
[...]
-github:GithubPullRequest:1:218939809,github:GithubRepo:1:134018330,github:GithubRepo:1:150579999,MERGED,❓解决死循环导致cpu占用率过高,"""使用了cond
条件变量来阻塞Submit
goroutine。潘少,你再仔细琢磨琢磨,看下有何不妥?""",https://github.com/panjf2000/ants/pull/13,liyonglion,github:GithubAccount:1:12890888,,13,2018-09-28T11:37:28.000+00:00,2018-09-29T11:29:54.000+00:00,2018-09-29T11:29:54.000+00:00,,,9a3b5cd25344822bca7684f87d9e123890a7bf59,master,master,af376f1b7b59dc488458bcecd4273f0fcde33c55,1846b4392a3a20e6bf1a7431b67f86bd43e0
[...]
-github:GithubPullRequest:1:219363161,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,Remove
meaningless if
statements,"""""",https://github.com/panjf2000/ants/pull/14,SimePel,github:GithubAccount:1:20608155,,14,2018-10-01T12:48:11.000+00:00,2018-10-02T13:52:27.000+00:00,2018-10-02T13:52:27.000+00:00,,,29730bb70343924a2f56a13a9799611dd1cd27fd,master,master,1b62696050b7030106291980d5220f886b017eff,5ed168767a771e3802252020b9821610380ed1a4,"{""ConnectionId"":1,""Name"":""panjf2000
[...]
-github:GithubPullRequest:1:219936521,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,Fixes
to benchmarks and added semaphore comparison,"""Benchmark results with
Param=0, as time.Sleep is not stable on Windows\r\n\r\nAlso Go 1.11 has bunch
of improvements:\r\n\r\n```\r\ngoos: windows\r\ngoarch: amd64\r\npkg:
github.com/panjf2000/ants\r\nBenchmarkGoroutineWithFunc-8 1
3530220300 ns/op 207472 B/op 506
allocs/op\r\nBenchmarkSemaphoreWithFunc-8 [...]
-github:GithubPullRequest:1:222703171,github:GithubRepo:1:134018330,github:GithubRepo:1:152956614,CLOSED,bugfix(check
max pool size),"""if you limit max goroutine to math.Maxint32 as your code
`int32(pool size)`\r\nI think should check max Goroutine size, otherwise size
overflow to
negative?\r\n""",https://github.com/panjf2000/ants/pull/16,rikewang,github:GithubAccount:1:24841832,,16,2018-10-14T09:21:41.000+00:00,,2018-12-03T03:53:31.000+00:00,,,1399cfa28f6751f769a985206daecb56a08b2de9,b
[...]
-github:GithubPullRequest:1:231840723,github:GithubRepo:1:134018330,github:GithubRepo:1:158152223,MERGED,Possible
memory leak because of Ticker,"""// NewTicker returns a new Ticker containing
a channel that will send the\r\n// time with a period specified by the duration
argument.\r\n// It adjusts the intervals or drops ticks to make up for slow
receivers.\r\n// The duration d must be greater than zero; if not, NewTicker
will panic.\r\n// Stop the ticker to release associated resources.\r [...]
-github:GithubPullRequest:1:246250598,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,feature:
add PanicHandler,"""@panjf2000 PTAL\r\nFix #22 \r\nSigned-off-by: Cholerae Hu
<[email protected]>""",https://github.com/panjf2000/ants/pull/23,choleraehyq,github:GithubAccount:1:8923413,,23,2019-01-21T10:58:15.000+00:00,2019-01-22T05:41:34.000+00:00,2019-01-22T05:41:34.000+00:00,,,9158bd37025ccdd29d6346a6639a282e0060c7e2,panichandler,master,812dd4e01075be3cf97429a43abaf6837908cdcd
[...]
-github:GithubPullRequest:1:267414275,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,goreport:
lint warning on code comment structure,"""Added a newline between group
comment and exported variable line
😄""",https://github.com/panjf2000/ants/pull/30,sarathsp06,github:GithubAccount:1:964542,,30,2019-04-04T11:52:48.000+00:00,2019-04-23T11:11:58.000+00:00,2019-04-23T11:11:58.000+00:00,,,dec04010834ccd3691eb1776045ce3b9310ce26c,patch-1,master,4ae3fb8dc413492862469027bb58cb45b77338f
[...]
-github:GithubPullRequest:1:292246524,github:GithubRepo:1:134018330,github:GithubRepo:1:194015289,CLOSED,handle
job
panic,"""""",https://github.com/panjf2000/ants/pull/36,king526,github:GithubAccount:1:38849208,,36,2019-06-27T03:27:05.000+00:00,,2019-08-17T20:32:34.000+00:00,,,95e11bf85f18a80197918d15a19ec10f41903d63,master,master,05e96abd6103ae7b70436abe58dbc0ad7e740929,39f04c6e65b76b5f20abd3ca0606db4cd038e5c2,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,257,
-github:GithubPullRequest:1:300598936,github:GithubRepo:1:134018330,github:GithubRepo:1:198582966,MERGED,优化清理速度并修复内存泄漏,"""""",https://github.com/panjf2000/ants/pull/39,wwjiang,github:GithubAccount:1:1290360,,39,2019-07-24T07:41:02.000+00:00,2019-07-26T04:00:12.000+00:00,2019-07-26T04:00:12.000+00:00,,,21a109c7f0873c8f466d6710de23474968940011,master,master,fc48d32604efc2b36d144b8f83d34c1aa1fda1c9,b44a12884b495713a44f796981267ed87134decb,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_r
[...]
-github:GithubPullRequest:1:301421607,github:GithubRepo:1:134018330,github:GithubRepo:1:198955529,MERGED,"optimize
memory allocation, change the default pool param and add the log of panic
stack.","""Hi, I am using it on my online server which almost need 5 million
goroutines on each go service.\r\nI'm divided into 10 small pools, because a
pool of five million will slow down the speed associated with the slice.\r\nI
made some small optimizations, I hope this is useful.\r\noptimize memory [...]
-github:GithubPullRequest:1:308859272,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,support
nonblocking submit and max blocking limit setting,"""Signed-off-by: Cholerae
Hu
<[email protected]>""",https://github.com/panjf2000/ants/pull/41,choleraehyq,github:GithubAccount:1:8923413,,41,2019-08-20T03:24:27.000+00:00,2019-08-20T10:55:19.000+00:00,2019-08-20T10:55:19.000+00:00,,,faef79b7d8a4876da8a215d7794cce20c710aaa2,nonblocking,master,dc8169d5c2645bfc507d6993b7d215326300f31b
[...]
-github:GithubPullRequest:1:311420898,github:GithubRepo:1:134018330,github:GithubRepo:1:134018330,MERGED,Create
CODE_OF_CONDUCT.md,"""""",https://github.com/panjf2000/ants/pull/48,panjf2000,github:GithubAccount:1:7496278,,48,2019-08-27T14:44:03.000+00:00,2019-08-27T14:46:22.000+00:00,2019-08-27T14:46:22.000+00:00,,,d5eded45bffe827e5a64a3376c4b94f08b641031,add-code-of-conduct-1,master,44aec9954f58987c37d5937ba590bbf0812a32de,bba6c12b60eff3445adcc168fff3bfdcad9e2571,"{""ConnectionId"":1,""N
[...]
-github:GithubPullRequest:1:316337433,github:GithubRepo:1:134018330,github:GithubRepo:1:207765423,MERGED,Invoke
decRunning() when revertWorker() returns false,"""Signed-off-by: Cholerae Hu
<[email protected]>\r\n\r\n---\r\nname: Pull request\r\nabout: Propose
changes to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\r\nWas this change
discussed in a [...]
-github:GithubPullRequest:1:325179595,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,add
loop queue ,"""---\r\nname: Pull request\r\nabout:
抽象出worker队列的实现,使用原先和循环队列实现这个接口\r\ntitle: ''\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\r\nWas this change
discussed in an issue first? That can help save time in case the change is not
a good fit for the project. Not all [...]
-github:GithubPullRequest:1:329127652,github:GithubRepo:1:134018330,github:GithubRepo:1:215736581,CLOSED,throw
out default panic,"""<the Go programming language>\r\n5.10.
Recover\r\nRecovering indiscriminately from panics is a dubious practice
because the state of a package’s variables after a panic is rarely well defined
or documented. Perhaps a critical update to a data structure was incomplete, a
file or net work connection was opened but not closed, or a lock was acquired
but not rele [...]
-github:GithubPullRequest:1:346931859,github:GithubRepo:1:134018330,github:GithubRepo:1:0,CLOSED,Refine
the indentation of the sample code in
READMEs,"""""",https://github.com/panjf2000/ants/pull/66,RealLiuSha,github:GithubAccount:1:5715152,,66,2019-11-29T07:50:17.000+00:00,,2019-11-29T07:52:04.000+00:00,,,1acafed7740d0daf1dcc3a30129798f59c234331,master,master,fd3841dd88c15fcc0e0ea94e606d980221ac5e09,b19edbd7b909527b2cc2a759e7a60133497f9dee,"{""ConnectionId"":1,""Name"":""panjf2000/ants""
[...]
-github:GithubPullRequest:1:379435034,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,Fix
a bug that doesn't release lock,"""err!=nil时未释放锁,使用defer
p.lock.Unlock()修复\r\n\r\n---\r\nname: Pull request\r\nabout: Propose changes to
the code\r\ntitle: ''\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\r\nWas this change
discussed in an issue first? That can help save tim [...]
-github:GithubPullRequest:1:404931293,github:GithubRepo:1:134018330,github:GithubRepo:1:256385795,CLOSED,fix:v2
dir not exist,"""---\r\nname: Pull request\r\nabout: Propose changes to the
code\r\ntitle: ''\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank
you for contributing to `ants`! Please fill this out to help us make the most
of your pull request.\r\n\r\nWas this change discussed in an issue first? That
can help save time in case the change is not a good fit for the project [...]
-github:GithubPullRequest:1:410487606,github:GithubRepo:1:134018330,github:GithubRepo:1:259825622,MERGED,Fix
indent on README,"""---\r\nname: Pull request\r\nabout: Propose changes to the
code\r\ntitle: 'Fix indent'\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\r\nWas this change
discussed in an issue first? That can help save time in case the change is not
a good fit for t [...]
-github:GithubPullRequest:1:415925259,github:GithubRepo:1:134018330,github:GithubRepo:1:0,CLOSED,支持配置workerChanCap大小,"""---\r\nname:
Pull request\r\nabout: support customize workerChanCap \r\ntitle:
''\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for
contributing to `ants`! Please fill this out to help us make the most of your
pull request.\r\n\r\nWas this change discussed in an issue first? That can help
save time in case the change is not a good fit for the project. No [...]
-github:GithubPullRequest:1:452382525,github:GithubRepo:1:134018330,github:GithubRepo:1:280806104,MERGED,chore:
support go1.14,"""as
title.""",https://github.com/panjf2000/ants/pull/100,appleboy,github:GithubAccount:1:21979,,100,2020-07-19T06:38:38.000+00:00,2020-07-19T14:59:48.000+00:00,2020-07-19T14:59:48.000+00:00,,,0a7be73d35726850863a80432dec0ac5c78cdfb4,patch,master,b2666199751ef4fe666c175ba667d18a182b67e0,18623ceb17a9230484ff5d1a31c3beb0b631a2f3,"{""ConnectionId"":1,""Name"":""panj
[...]
-github:GithubPullRequest:1:461992435,github:GithubRepo:1:134018330,github:GithubRepo:1:284629248,CLOSED,Add
a Gitter chat badge to README.md,"""### panjf2000/ants now has a Chat Room on
Gitter\n\n@panjf2000 has just created a chat room. You can visit it here:
[https://gitter.im/ants-pool/ants](https://gitter.im/ants-pool/ants?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&content=body_link).\n\nThis
pull-request adds this badge to your
README.md:\n\n\n[.\r\n\r\n## 2.
Please describe how these code changes achieve your intention.\r\nThere is no
code change\r\n\r\n\r\n\r\n_(Feel free to reject this PR if [...]
-github:GithubPullRequest:1:502102437,github:GithubRepo:1:134018330,github:GithubRepo:1:303638681,MERGED,fix:
Memory leak,"""Fixes
#113""",https://github.com/panjf2000/ants/pull/114,Mutated1994,github:GithubAccount:1:29589055,,114,2020-10-13T08:37:37.000+00:00,2020-10-15T03:35:56.000+00:00,2020-10-15T03:35:56.000+00:00,,,94a7a7f1cb3a11fcaaf9608c94fe1dc0bcd98ab0,master,master,ef6017217221e20416d886c0231dd5134752ef4e,00691c648a5b7d28dba5bcafa05d9bbccdf4d933,"{""ConnectionId"":1,""Name"":""p
[...]
-github:GithubPullRequest:1:505486248,github:GithubRepo:1:134018330,github:GithubRepo:1:305101171,CLOSED,fix
set negative size,"""fix set negative size for
pool\r\n""",https://github.com/panjf2000/ants/pull/117,imxyb,github:GithubAccount:1:7411249,,117,2020-10-18T14:58:12.000+00:00,,2020-10-19T01:58:45.000+00:00,,,55d7f5eb6298d59b76a26b56d1bbb776503a8563,hotfix-poolsize,master,94a7a7f1cb3a11fcaaf9608c94fe1dc0bcd98ab0,05a3664dbf966f1a7ced274aaf47d34e644287ef,"{""ConnectionId"":1,""Name"":"
[...]
-github:GithubPullRequest:1:543900177,github:GithubRepo:1:134018330,github:GithubRepo:1:323540538,CLOSED,Add
go1.15.x support on CI,"""Add go1.15.x support on
CI""",https://github.com/panjf2000/ants/pull/131,kaiiak,github:GithubAccount:1:2832687,,131,2020-12-22T06:25:18.000+00:00,,2021-03-19T02:15:23.000+00:00,,,545d5f0c007d1d5e2cd23ae2d9074365c0f03790,patch-1,master,fd8d670fd09489e6ea7693c0a382ba85d2694f16,15cb2705734c62544ac5dca0de3f28f03a69a854,"{""ConnectionId"":1,""Name"":""panjf2000
[...]
-github:GithubPullRequest:1:582870188,github:GithubRepo:1:134018330,github:GithubRepo:1:343711920,CLOSED,Change
the writing of if...err,"""---\r\nname: Pull request\r\nabout: Propose changes
to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\r\nWas this change
discussed in an issue first? That can help save time in case the change is not
a good fit for t [...]
-github:GithubPullRequest:1:586207150,github:GithubRepo:1:134018330,github:GithubRepo:1:345288213,CLOSED,The
program should return directly when the pool size passed in when …,"""…calling
the NewPool interface is less than or equal to 0\r\n\r\n---\r\nname: Pull
request\r\nabout: Propose changes to the code\r\ntitle: 'code
improve'\r\n---\r\n""",https://github.com/panjf2000/ants/pull/139,zhangyuanxue,github:GithubAccount:1:32893410,,139,2021-03-07T08:00:46.000+00:00,,2021-03-12T12:45:57.00
[...]
-github:GithubPullRequest:1:607755003,github:GithubRepo:1:134018330,github:GithubRepo:1:353622545,CLOSED,pool_list,"""sequence""",https://github.com/panjf2000/ants/pull/149,yddeng,github:GithubAccount:1:41562937,,149,2021-04-02T01:16:21.000+00:00,,2021-04-02T04:09:52.000+00:00,,,fd1b0378ee9b60fe32a2fe5c8198a427e5f46949,pool_list,master,dbcb6a104f23b1a6a7521796b30515230353283e,674fe08bb2c2ced275600ebdddf2412c84e2c349,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_r
[...]
-github:GithubPullRequest:1:654684379,github:GithubRepo:1:134018330,github:GithubRepo:1:371305210,OPEN,Submit
a task with args to pool,"""---\r\nname: Resolve problem with args
capturing\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please
fill this out to help us make the most of your pull request.\r\n\r\nWas this
change discussed in an issue first? That can help save time in case the change
is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt
is n [...]
-github:GithubPullRequest:1:669972849,github:GithubRepo:1:134018330,github:GithubRepo:1:376993065,OPEN,allow
NewPoolWithFunc can invoke with nil argument,"""2. abstract a Task interface
for SubmitTask which is more convenient\r\n\r\n---\r\nname: Pull
request\r\nabout: Propose changes to the code\r\ntitle: 'allow NewPoolWithFunc
can invoke with nil argument'\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the m [...]
-github:GithubPullRequest:1:686947632,github:GithubRepo:1:134018330,github:GithubRepo:1:384510398,MERGED,Timing
issue in the TestNonblockingSubmitWithFunc,"""On some machines this unit would
fail due to a timing issue. Since the Invoke in the loop was using nil as the
param, it would (depending on timing) lead to the workers finishing the (w
*goWorkerWithFunc) run() in the range loop over w.args as args would == nil and
return. \r\n\r\nIf an explicit time.Sleep(1 * time.Second) is added [...]
-github:GithubPullRequest:1:693963625,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,Fix
CI workflow to make the cache action really work,"""workflows add cache mod
file\r\nworkflows should be restore cache before unit test\r\nlink
[actions/cache](https://github.com/marketplace/actions/cache)\r\n---\r\nname:
Pull request\r\nabout: Propose changes to the code\r\ntitle:
'workflows'\r\nlabels: 'workflows'\r\nassignees: ''\r\n---\r\n\r\n## 1. Are you
opening this pull request for [...]
-github:GithubPullRequest:1:696437287,github:GithubRepo:1:134018330,github:GithubRepo:1:389252738,OPEN,feat:
goroutine exits immediately,"""---\r\nname: goroutine exits
immediately\r\nabout: goroutine exits immediately, lazy init
defaultAntsPool\r\ntitle: 'goroutine exits immediately'\r\nlabels:
''\r\nassignees: 'panjf2000'\r\n---\r\n\r\n<!--\r\nThank you for contributing
to `ants`! Please fill this out to help us make the most of your pull
request.\r\n\r\nWas this change discussed in an [...]
-github:GithubPullRequest:1:731946063,github:GithubRepo:1:134018330,github:GithubRepo:1:398834222,MERGED,style:
fixed some typos in the comments,"""---\r\nname: Pull request\r\nabout: typos
in comments\r\ntitle: fixed some typos in the comments\r\nlabels:
\r\nassignees: @panjf2000 \r\n---\r\n\r\n<!--\r\nThank you for contributing to
`ants`! Please fill this out to help us make the most of your pull
request.\r\n\r\nWas this change discussed in an issue first? That can help save
time in cas [...]
-github:GithubPullRequest:1:736936308,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,Update
the link of one of the relevant articles,"""Hello! I never got the chance to
mention it before, but thank you for linking one of my articles in your
repository :) \r\n\r\n## 1. Are you opening this pull request for bug-fixs,
optimizations or new feature?\r\nNo\r\n\r\n\r\n## 2. Please describe how these
code changes achieve your intention.\r\nI'm working on migrating my domain from
`twin [...]
-github:GithubPullRequest:1:742901118,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,Update
the link of one of the relevant articles,"""re: #185\r\n\r\nMissed the
`README_ZH.md` file 😅
""",https://github.com/panjf2000/ants/pull/186,TwiN,github:GithubAccount:1:15699766,,186,2021-09-26T15:53:39.000+00:00,2021-09-27T02:38:55.000+00:00,2021-09-27T02:38:55.000+00:00,,,3f9c4cd54898e7149c7f6d072213b8fdbd0036d8,patch-1,master,61d120b6f086998184f402a83ace485a036d4c7d,41f6b572b25da6363d
[...]
-github:GithubPullRequest:1:757412327,github:GithubRepo:1:134018330,github:GithubRepo:1:416596451,MERGED,add
shopify into user cases,"""Fixes
https://github.com/panjf2000/ants/issues/188""",https://github.com/panjf2000/ants/pull/189,lilien1010,github:GithubAccount:1:3814966,,189,2021-10-13T13:34:05.000+00:00,2021-10-13T13:42:42.000+00:00,2021-10-13T13:42:42.000+00:00,,,76ce0ce24f21b1dd13050e0c84b07ce55e68f111,add-shopify-as-user-case,master,3f9c4cd54898e7149c7f6d072213b8fdbd0036d8,efe0bad
[...]
-github:GithubPullRequest:1:763816683,github:GithubRepo:1:134018330,github:GithubRepo:1:419934243,CLOSED,add
more test about spinlock,"""---\r\nname: Pull request\r\nabout: add more
test about spinlock\r\ntitle: ''\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\r\nWas this change
discussed in an issue first? That can help save time in case the change is not
a good fit for [...]
-github:GithubPullRequest:1:770998086,github:GithubRepo:1:134018330,github:GithubRepo:1:423301234,CLOSED,Replace
goto with simple for loop,"""---\r\nname: Pull request\r\nabout: Replace goto
with simple for loop\r\ntitle: 'Replace goto with simple for loop'\r\nlabels:
''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`!
Please fill this out to help us make the most of your pull request.\r\n\r\nWas
this change discussed in an issue first? That can help save time [...]
-github:GithubPullRequest:1:791490205,github:GithubRepo:1:134018330,github:GithubRepo:1:0,CLOSED,optimize:
calculating mid in binary search,"""---\r\nname: Pull request\r\nabout:
Propose changes to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\r\nWas this change
discussed in an issue first? That can help save time in case the change is not
a good fit f [...]
-github:GithubPullRequest:1:816835878,github:GithubRepo:1:134018330,github:GithubRepo:1:445578800,MERGED,Add
binarysearch of loop queue,"""---\r\nname: Pull request\r\nabout: Add
binarysearch method to loop_queue to get expired workers, just like
worker_stack.\r\ntitle: ''\r\nlabels: ''\r\nassignees:
'bright2227'\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please
fill this out to help us make the most of your pull request.\r\n\r\nWas this
change discussed in an issue firs [...]
-github:GithubPullRequest:1:835038436,github:GithubRepo:1:134018330,github:GithubRepo:1:449536867,MERGED,Awake
the blocking callers when Tune(size int) is invoked to expand the
pool,"""…capacity\r\n\r\n---\r\nname: Pull request\r\nabout: Propose changes to
the code\r\ntitle: 'Instantly scale up capacity when using Tune(size int) to
enlarge the capacity'\r\nlabels: 'enhancement'\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us mak [...]
-github:GithubPullRequest:1:842184289,github:GithubRepo:1:134018330,github:GithubRepo:1:456662951,OPEN,Remove
worker_func.go and modify pool_func.go simplifying the library,"""---\r\nname:
Remove worker_func.go and modify pool_func.go simplifying the library\r\nabout:
Remove worker_func.go and modify pool_func.go to simply utilize the non-func
pool+worker implementation\r\ntitle: 'Remove worker_func.go and modify
pool_func.go simplifying the library'\r\nlabels: ''\r\nassignees: @panjf2000
[...]
+id,base_repo_id,head_repo_id,status,original_status,title,description,url,author_name,author_id,parent_pr_id,pull_request_key,created_date,merged_date,closed_date,type,component,merge_commit_sha,head_ref,base_ref,base_commit_sha,head_commit_sha,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark
+github:GithubPullRequest:1:203756736,github:GithubRepo:1:134018330,github:GithubRepo:1:142234748,MERGED,closed,pre-allocate
the capacity of the worker listpre-allocate the capacity of the worker
listpre-allocate the capacity of the worker listpre-allocate the capacity of
the worker listpre-allocate the capacity of the worker listpre-allocate the
capacity of the worker listpre-allocate the capacity of the worker
listpre-allocate the capacity of the worker listpre-allocate the capacity of
[...]
+github:GithubPullRequest:1:211603583,github:GithubRepo:1:134018330,github:GithubRepo:1:0,CLOSED,closed,fix
goroutine leak,"""n++, will cause workers[0]
leak""",https://github.com/panjf2000/ants/pull/8,hongli-my,github:GithubAccount:1:8597823,,8,2018-08-29T01:35:54.000+00:00,,2018-10-30T00:12:13.000+00:00,,,74ba726f34abe487b7defac6bb9bebf24d342377,dev,master,666635c65d8d3bb1223b819325e0bd23c81f2733,afd687164b13280199208ec4869709edcf02b52d,"{""ConnectionId"":1,""Name"":""panjf2000/ants""
[...]
+github:GithubPullRequest:1:212277907,github:GithubRepo:1:134018330,github:GithubRepo:1:146845386,CLOSED,closed,Update
pool.go,"""#活着的孩子不想当孤儿\r\n\tHopefully:\r\n\tchildren :=
[]*child{C1,C2,C3,C4,C5,C6,C7}\r\n\tIn fact:\r\n\tchildren :=
[]*child{C1,C4,C2,C3,C5,C6,C7}""",https://github.com/panjf2000/ants/pull/9,Nonnnnnnnnn,github:GithubAccount:1:42808204,,9,2018-08-31T05:29:36.000+00:00,,2018-08-31T13:40:33.000+00:00,,,f14d3f91f68d0bc23fe42aa413e98005f6575045,patch-1,master,666635c65d8d3bb
[...]
+github:GithubPullRequest:1:216254598,github:GithubRepo:1:134018330,github:GithubRepo:1:149267177,CLOSED,closed,graceful
exit,"""graceful
exit""",https://github.com/panjf2000/ants/pull/11,shanhuhai5739,github:GithubAccount:1:3794113,,11,2018-09-18T10:15:01.000+00:00,,2018-12-03T03:52:35.000+00:00,,,6a87067eb3d6440e5db17f31d4bc12ac291633f4,master,develop,833b6e29acfb2f16e3cf7fc92c79763847c319f4,a03eccc794870f0a2e55a5cb8344ea47f2a0001d,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw
[...]
+github:GithubPullRequest:1:218939809,github:GithubRepo:1:134018330,github:GithubRepo:1:150579999,MERGED,closed,❓解决死循环导致cpu占用率过高,"""使用了cond
条件变量来阻塞Submit
goroutine。潘少,你再仔细琢磨琢磨,看下有何不妥?""",https://github.com/panjf2000/ants/pull/13,liyonglion,github:GithubAccount:1:12890888,,13,2018-09-28T11:37:28.000+00:00,2018-09-29T11:29:54.000+00:00,2018-09-29T11:29:54.000+00:00,,,9a3b5cd25344822bca7684f87d9e123890a7bf59,master,master,af376f1b7b59dc488458bcecd4273f0fcde33c55,1846b4392a3a20e6bf1a7431b67f8
[...]
+github:GithubPullRequest:1:219363161,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,closed,Remove
meaningless if
statements,"""""",https://github.com/panjf2000/ants/pull/14,SimePel,github:GithubAccount:1:20608155,,14,2018-10-01T12:48:11.000+00:00,2018-10-02T13:52:27.000+00:00,2018-10-02T13:52:27.000+00:00,,,29730bb70343924a2f56a13a9799611dd1cd27fd,master,master,1b62696050b7030106291980d5220f886b017eff,5ed168767a771e3802252020b9821610380ed1a4,"{""ConnectionId"":1,""Name"":""pa
[...]
+github:GithubPullRequest:1:219936521,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,closed,Fixes
to benchmarks and added semaphore comparison,"""Benchmark results with
Param=0, as time.Sleep is not stable on Windows\r\n\r\nAlso Go 1.11 has bunch
of improvements:\r\n\r\n```\r\ngoos: windows\r\ngoarch: amd64\r\npkg:
github.com/panjf2000/ants\r\nBenchmarkGoroutineWithFunc-8 1
3530220300 ns/op 207472 B/op 506
allocs/op\r\nBenchmarkSemaphoreWithFun [...]
+github:GithubPullRequest:1:222703171,github:GithubRepo:1:134018330,github:GithubRepo:1:152956614,CLOSED,closed,bugfix(check
max pool size),"""if you limit max goroutine to math.Maxint32 as your code
`int32(pool size)`\r\nI think should check max Goroutine size, otherwise size
overflow to
negative?\r\n""",https://github.com/panjf2000/ants/pull/16,rikewang,github:GithubAccount:1:24841832,,16,2018-10-14T09:21:41.000+00:00,,2018-12-03T03:53:31.000+00:00,,,1399cfa28f6751f769a985206daecb56a08
[...]
+github:GithubPullRequest:1:231840723,github:GithubRepo:1:134018330,github:GithubRepo:1:158152223,MERGED,closed,Possible
memory leak because of Ticker,"""// NewTicker returns a new Ticker containing
a channel that will send the\r\n// time with a period specified by the duration
argument.\r\n// It adjusts the intervals or drops ticks to make up for slow
receivers.\r\n// The duration d must be greater than zero; if not, NewTicker
will panic.\r\n// Stop the ticker to release associated resou [...]
+github:GithubPullRequest:1:246250598,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,closed,feature:
add PanicHandler,"""@panjf2000 PTAL\r\nFix #22 \r\nSigned-off-by: Cholerae Hu
<[email protected]>""",https://github.com/panjf2000/ants/pull/23,choleraehyq,github:GithubAccount:1:8923413,,23,2019-01-21T10:58:15.000+00:00,2019-01-22T05:41:34.000+00:00,2019-01-22T05:41:34.000+00:00,,,9158bd37025ccdd29d6346a6639a282e0060c7e2,panichandler,master,812dd4e01075be3cf97429a43abaf6837
[...]
+github:GithubPullRequest:1:267414275,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,closed,goreport:
lint warning on code comment structure,"""Added a newline between group
comment and exported variable line
😄""",https://github.com/panjf2000/ants/pull/30,sarathsp06,github:GithubAccount:1:964542,,30,2019-04-04T11:52:48.000+00:00,2019-04-23T11:11:58.000+00:00,2019-04-23T11:11:58.000+00:00,,,dec04010834ccd3691eb1776045ce3b9310ce26c,patch-1,master,4ae3fb8dc413492862469027bb58cb45
[...]
+github:GithubPullRequest:1:292246524,github:GithubRepo:1:134018330,github:GithubRepo:1:194015289,CLOSED,closed,handle
job
panic,"""""",https://github.com/panjf2000/ants/pull/36,king526,github:GithubAccount:1:38849208,,36,2019-06-27T03:27:05.000+00:00,,2019-08-17T20:32:34.000+00:00,,,95e11bf85f18a80197918d15a19ec10f41903d63,master,master,05e96abd6103ae7b70436abe58dbc0ad7e740929,39f04c6e65b76b5f20abd3ca0606db4cd038e5c2,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull
[...]
+github:GithubPullRequest:1:300598936,github:GithubRepo:1:134018330,github:GithubRepo:1:198582966,MERGED,closed,优化清理速度并修复内存泄漏,"""""",https://github.com/panjf2000/ants/pull/39,wwjiang,github:GithubAccount:1:1290360,,39,2019-07-24T07:41:02.000+00:00,2019-07-26T04:00:12.000+00:00,2019-07-26T04:00:12.000+00:00,,,21a109c7f0873c8f466d6710de23474968940011,master,master,fc48d32604efc2b36d144b8f83d34c1aa1fda1c9,b44a12884b495713a44f796981267ed87134decb,"{""ConnectionId"":1,""Name"":""panjf2000/ants
[...]
+github:GithubPullRequest:1:301421607,github:GithubRepo:1:134018330,github:GithubRepo:1:198955529,MERGED,closed,"optimize
memory allocation, change the default pool param and add the log of panic
stack.","""Hi, I am using it on my online server which almost need 5 million
goroutines on each go service.\r\nI'm divided into 10 small pools, because a
pool of five million will slow down the speed associated with the slice.\r\nI
made some small optimizations, I hope this is useful.\r\noptimize [...]
+github:GithubPullRequest:1:308859272,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,closed,support
nonblocking submit and max blocking limit setting,"""Signed-off-by: Cholerae
Hu
<[email protected]>""",https://github.com/panjf2000/ants/pull/41,choleraehyq,github:GithubAccount:1:8923413,,41,2019-08-20T03:24:27.000+00:00,2019-08-20T10:55:19.000+00:00,2019-08-20T10:55:19.000+00:00,,,faef79b7d8a4876da8a215d7794cce20c710aaa2,nonblocking,master,dc8169d5c2645bfc507d6993b7d215326
[...]
+github:GithubPullRequest:1:311420898,github:GithubRepo:1:134018330,github:GithubRepo:1:134018330,MERGED,closed,Create
CODE_OF_CONDUCT.md,"""""",https://github.com/panjf2000/ants/pull/48,panjf2000,github:GithubAccount:1:7496278,,48,2019-08-27T14:44:03.000+00:00,2019-08-27T14:46:22.000+00:00,2019-08-27T14:46:22.000+00:00,,,d5eded45bffe827e5a64a3376c4b94f08b641031,add-code-of-conduct-1,master,44aec9954f58987c37d5937ba590bbf0812a32de,bba6c12b60eff3445adcc168fff3bfdcad9e2571,"{""ConnectionId"
[...]
+github:GithubPullRequest:1:316337433,github:GithubRepo:1:134018330,github:GithubRepo:1:207765423,MERGED,closed,Invoke
decRunning() when revertWorker() returns false,"""Signed-off-by: Cholerae Hu
<[email protected]>\r\n\r\n---\r\nname: Pull request\r\nabout: Propose
changes to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\r\nWas this change
discuss [...]
+github:GithubPullRequest:1:325179595,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,closed,add
loop queue ,"""---\r\nname: Pull request\r\nabout:
抽象出worker队列的实现,使用原先和循环队列实现这个接口\r\ntitle: ''\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\r\nWas this change
discussed in an issue first? That can help save time in case the change is not
a good fit for the project. N [...]
+github:GithubPullRequest:1:329127652,github:GithubRepo:1:134018330,github:GithubRepo:1:215736581,CLOSED,closed,throw
out default panic,"""<the Go programming language>\r\n5.10.
Recover\r\nRecovering indiscriminately from panics is a dubious practice
because the state of a package’s variables after a panic is rarely well defined
or documented. Perhaps a critical update to a data structure was incomplete, a
file or net work connection was opened but not closed, or a lock was acquired
but n [...]
+github:GithubPullRequest:1:346931859,github:GithubRepo:1:134018330,github:GithubRepo:1:0,CLOSED,closed,Refine
the indentation of the sample code in
READMEs,"""""",https://github.com/panjf2000/ants/pull/66,RealLiuSha,github:GithubAccount:1:5715152,,66,2019-11-29T07:50:17.000+00:00,,2019-11-29T07:52:04.000+00:00,,,1acafed7740d0daf1dcc3a30129798f59c234331,master,master,fd3841dd88c15fcc0e0ea94e606d980221ac5e09,b19edbd7b909527b2cc2a759e7a60133497f9dee,"{""ConnectionId"":1,""Name"":""panjf2000
[...]
+github:GithubPullRequest:1:379435034,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,closed,Fix
a bug that doesn't release lock,"""err!=nil时未释放锁,使用defer
p.lock.Unlock()修复\r\n\r\n---\r\nname: Pull request\r\nabout: Propose changes to
the code\r\ntitle: ''\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\r\nWas this change
discussed in an issue first? That can help s [...]
+github:GithubPullRequest:1:404931293,github:GithubRepo:1:134018330,github:GithubRepo:1:256385795,CLOSED,closed,fix:v2
dir not exist,"""---\r\nname: Pull request\r\nabout: Propose changes to the
code\r\ntitle: ''\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank
you for contributing to `ants`! Please fill this out to help us make the most
of your pull request.\r\n\r\nWas this change discussed in an issue first? That
can help save time in case the change is not a good fit for the [...]
+github:GithubPullRequest:1:410487606,github:GithubRepo:1:134018330,github:GithubRepo:1:259825622,MERGED,closed,Fix
indent on README,"""---\r\nname: Pull request\r\nabout: Propose changes to the
code\r\ntitle: 'Fix indent'\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\r\nWas this change
discussed in an issue first? That can help save time in case the change is not
a good fi [...]
+github:GithubPullRequest:1:415925259,github:GithubRepo:1:134018330,github:GithubRepo:1:0,CLOSED,closed,支持配置workerChanCap大小,"""---\r\nname:
Pull request\r\nabout: support customize workerChanCap \r\ntitle:
''\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for
contributing to `ants`! Please fill this out to help us make the most of your
pull request.\r\n\r\nWas this change discussed in an issue first? That can help
save time in case the change is not a good fit for the proj [...]
+github:GithubPullRequest:1:452382525,github:GithubRepo:1:134018330,github:GithubRepo:1:280806104,MERGED,closed,chore:
support go1.14,"""as
title.""",https://github.com/panjf2000/ants/pull/100,appleboy,github:GithubAccount:1:21979,,100,2020-07-19T06:38:38.000+00:00,2020-07-19T14:59:48.000+00:00,2020-07-19T14:59:48.000+00:00,,,0a7be73d35726850863a80432dec0ac5c78cdfb4,patch,master,b2666199751ef4fe666c175ba667d18a182b67e0,18623ceb17a9230484ff5d1a31c3beb0b631a2f3,"{""ConnectionId"":1,""Name""
[...]
+github:GithubPullRequest:1:461992435,github:GithubRepo:1:134018330,github:GithubRepo:1:284629248,CLOSED,closed,Add
a Gitter chat badge to README.md,"""### panjf2000/ants now has a Chat Room on
Gitter\n\n@panjf2000 has just created a chat room. You can visit it here:
[https://gitter.im/ants-pool/ants](https://gitter.im/ants-pool/ants?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&content=body_link).\n\nThis
pull-request adds this badge to your README.md:\n\n\n[.\r\n\r\n## 2.
Please describe how these code changes achieve your intention.\r\nThere is no
code change\r\n\r\n\r\n\r\n_(Feel free to reject thi [...]
+github:GithubPullRequest:1:502102437,github:GithubRepo:1:134018330,github:GithubRepo:1:303638681,MERGED,closed,fix:
Memory leak,"""Fixes
#113""",https://github.com/panjf2000/ants/pull/114,Mutated1994,github:GithubAccount:1:29589055,,114,2020-10-13T08:37:37.000+00:00,2020-10-15T03:35:56.000+00:00,2020-10-15T03:35:56.000+00:00,,,94a7a7f1cb3a11fcaaf9608c94fe1dc0bcd98ab0,master,master,ef6017217221e20416d886c0231dd5134752ef4e,00691c648a5b7d28dba5bcafa05d9bbccdf4d933,"{""ConnectionId"":1,""Nam
[...]
+github:GithubPullRequest:1:505486248,github:GithubRepo:1:134018330,github:GithubRepo:1:305101171,CLOSED,closed,fix
set negative size,"""fix set negative size for
pool\r\n""",https://github.com/panjf2000/ants/pull/117,imxyb,github:GithubAccount:1:7411249,,117,2020-10-18T14:58:12.000+00:00,,2020-10-19T01:58:45.000+00:00,,,55d7f5eb6298d59b76a26b56d1bbb776503a8563,hotfix-poolsize,master,94a7a7f1cb3a11fcaaf9608c94fe1dc0bcd98ab0,05a3664dbf966f1a7ced274aaf47d34e644287ef,"{""ConnectionId"":1,""N
[...]
+github:GithubPullRequest:1:543900177,github:GithubRepo:1:134018330,github:GithubRepo:1:323540538,CLOSED,closed,Add
go1.15.x support on CI,"""Add go1.15.x support on
CI""",https://github.com/panjf2000/ants/pull/131,kaiiak,github:GithubAccount:1:2832687,,131,2020-12-22T06:25:18.000+00:00,,2021-03-19T02:15:23.000+00:00,,,545d5f0c007d1d5e2cd23ae2d9074365c0f03790,patch-1,master,fd8d670fd09489e6ea7693c0a382ba85d2694f16,15cb2705734c62544ac5dca0de3f28f03a69a854,"{""ConnectionId"":1,""Name"":""pa
[...]
+github:GithubPullRequest:1:582870188,github:GithubRepo:1:134018330,github:GithubRepo:1:343711920,CLOSED,closed,Change
the writing of if...err,"""---\r\nname: Pull request\r\nabout: Propose changes
to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\r\nWas this change
discussed in an issue first? That can help save time in case the change is not
a good fi [...]
+github:GithubPullRequest:1:586207150,github:GithubRepo:1:134018330,github:GithubRepo:1:345288213,CLOSED,closed,The
program should return directly when the pool size passed in when …,"""…calling
the NewPool interface is less than or equal to 0\r\n\r\n---\r\nname: Pull
request\r\nabout: Propose changes to the code\r\ntitle: 'code
improve'\r\n---\r\n""",https://github.com/panjf2000/ants/pull/139,zhangyuanxue,github:GithubAccount:1:32893410,,139,2021-03-07T08:00:46.000+00:00,,2021-03-12T12:4
[...]
+github:GithubPullRequest:1:607755003,github:GithubRepo:1:134018330,github:GithubRepo:1:353622545,CLOSED,closed,pool_list,"""sequence""",https://github.com/panjf2000/ants/pull/149,yddeng,github:GithubAccount:1:41562937,,149,2021-04-02T01:16:21.000+00:00,,2021-04-02T04:09:52.000+00:00,,,fd1b0378ee9b60fe32a2fe5c8198a427e5f46949,pool_list,master,dbcb6a104f23b1a6a7521796b30515230353283e,674fe08bb2c2ced275600ebdddf2412c84e2c349,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api
[...]
+github:GithubPullRequest:1:654684379,github:GithubRepo:1:134018330,github:GithubRepo:1:371305210,OPEN,open,Submit
a task with args to pool,"""---\r\nname: Resolve problem with args
capturing\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please
fill this out to help us make the most of your pull request.\r\n\r\nWas this
change discussed in an issue first? That can help save time in case the change
is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt
[...]
+github:GithubPullRequest:1:669972849,github:GithubRepo:1:134018330,github:GithubRepo:1:376993065,OPEN,open,allow
NewPoolWithFunc can invoke with nil argument,"""2. abstract a Task interface
for SubmitTask which is more convenient\r\n\r\n---\r\nname: Pull
request\r\nabout: Propose changes to the code\r\ntitle: 'allow NewPoolWithFunc
can invoke with nil argument'\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make [...]
+github:GithubPullRequest:1:686947632,github:GithubRepo:1:134018330,github:GithubRepo:1:384510398,MERGED,closed,Timing
issue in the TestNonblockingSubmitWithFunc,"""On some machines this unit would
fail due to a timing issue. Since the Invoke in the loop was using nil as the
param, it would (depending on timing) lead to the workers finishing the (w
*goWorkerWithFunc) run() in the range loop over w.args as args would == nil and
return. \r\n\r\nIf an explicit time.Sleep(1 * time.Second) i [...]
+github:GithubPullRequest:1:693963625,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,closed,Fix
CI workflow to make the cache action really work,"""workflows add cache mod
file\r\nworkflows should be restore cache before unit test\r\nlink
[actions/cache](https://github.com/marketplace/actions/cache)\r\n---\r\nname:
Pull request\r\nabout: Propose changes to the code\r\ntitle:
'workflows'\r\nlabels: 'workflows'\r\nassignees: ''\r\n---\r\n\r\n## 1. Are you
opening this pull reque [...]
+github:GithubPullRequest:1:696437287,github:GithubRepo:1:134018330,github:GithubRepo:1:389252738,OPEN,open,feat:
goroutine exits immediately,"""---\r\nname: goroutine exits
immediately\r\nabout: goroutine exits immediately, lazy init
defaultAntsPool\r\ntitle: 'goroutine exits immediately'\r\nlabels:
''\r\nassignees: 'panjf2000'\r\n---\r\n\r\n<!--\r\nThank you for contributing
to `ants`! Please fill this out to help us make the most of your pull
request.\r\n\r\nWas this change discussed i [...]
+github:GithubPullRequest:1:731946063,github:GithubRepo:1:134018330,github:GithubRepo:1:398834222,MERGED,closed,style:
fixed some typos in the comments,"""---\r\nname: Pull request\r\nabout: typos
in comments\r\ntitle: fixed some typos in the comments\r\nlabels:
\r\nassignees: @panjf2000 \r\n---\r\n\r\n<!--\r\nThank you for contributing to
`ants`! Please fill this out to help us make the most of your pull
request.\r\n\r\nWas this change discussed in an issue first? That can help save
time [...]
+github:GithubPullRequest:1:736936308,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,closed,Update
the link of one of the relevant articles,"""Hello! I never got the chance to
mention it before, but thank you for linking one of my articles in your
repository :) \r\n\r\n## 1. Are you opening this pull request for bug-fixs,
optimizations or new feature?\r\nNo\r\n\r\n\r\n## 2. Please describe how these
code changes achieve your intention.\r\nI'm working on migrating my domain fro
[...]
+github:GithubPullRequest:1:742901118,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,closed,Update
the link of one of the relevant articles,"""re: #185\r\n\r\nMissed the
`README_ZH.md` file 😅
""",https://github.com/panjf2000/ants/pull/186,TwiN,github:GithubAccount:1:15699766,,186,2021-09-26T15:53:39.000+00:00,2021-09-27T02:38:55.000+00:00,2021-09-27T02:38:55.000+00:00,,,3f9c4cd54898e7149c7f6d072213b8fdbd0036d8,patch-1,master,61d120b6f086998184f402a83ace485a036d4c7d,41f6b572b25
[...]
+github:GithubPullRequest:1:757412327,github:GithubRepo:1:134018330,github:GithubRepo:1:416596451,MERGED,closed,add
shopify into user cases,"""Fixes
https://github.com/panjf2000/ants/issues/188""",https://github.com/panjf2000/ants/pull/189,lilien1010,github:GithubAccount:1:3814966,,189,2021-10-13T13:34:05.000+00:00,2021-10-13T13:42:42.000+00:00,2021-10-13T13:42:42.000+00:00,,,76ce0ce24f21b1dd13050e0c84b07ce55e68f111,add-shopify-as-user-case,master,3f9c4cd54898e7149c7f6d072213b8fdbd0036d8,
[...]
+github:GithubPullRequest:1:763816683,github:GithubRepo:1:134018330,github:GithubRepo:1:419934243,CLOSED,closed,add
more test about spinlock,"""---\r\nname: Pull request\r\nabout: add more
test about spinlock\r\ntitle: ''\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\r\nWas this change
discussed in an issue first? That can help save time in case the change is not
a good f [...]
+github:GithubPullRequest:1:770998086,github:GithubRepo:1:134018330,github:GithubRepo:1:423301234,CLOSED,closed,Replace
goto with simple for loop,"""---\r\nname: Pull request\r\nabout: Replace goto
with simple for loop\r\ntitle: 'Replace goto with simple for loop'\r\nlabels:
''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`!
Please fill this out to help us make the most of your pull request.\r\n\r\nWas
this change discussed in an issue first? That can help sav [...]
+github:GithubPullRequest:1:791490205,github:GithubRepo:1:134018330,github:GithubRepo:1:0,CLOSED,closed,optimize:
calculating mid in binary search,"""---\r\nname: Pull request\r\nabout:
Propose changes to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help us make the most of your pull request.\r\n\r\nWas this change
discussed in an issue first? That can help save time in case the change is not
a goo [...]
+github:GithubPullRequest:1:816835878,github:GithubRepo:1:134018330,github:GithubRepo:1:445578800,MERGED,closed,Add
binarysearch of loop queue,"""---\r\nname: Pull request\r\nabout: Add
binarysearch method to loop_queue to get expired workers, just like
worker_stack.\r\ntitle: ''\r\nlabels: ''\r\nassignees:
'bright2227'\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please
fill this out to help us make the most of your pull request.\r\n\r\nWas this
change discussed in an iss [...]
+github:GithubPullRequest:1:835038436,github:GithubRepo:1:134018330,github:GithubRepo:1:449536867,MERGED,closed,Awake
the blocking callers when Tune(size int) is invoked to expand the
pool,"""…capacity\r\n\r\n---\r\nname: Pull request\r\nabout: Propose changes to
the code\r\ntitle: 'Instantly scale up capacity when using Tune(size int) to
enlarge the capacity'\r\nlabels: 'enhancement'\r\nassignees:
''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this
out to help [...]
+github:GithubPullRequest:1:842184289,github:GithubRepo:1:134018330,github:GithubRepo:1:456662951,OPEN,open,Remove
worker_func.go and modify pool_func.go simplifying the library,"""---\r\nname:
Remove worker_func.go and modify pool_func.go simplifying the library\r\nabout:
Remove worker_func.go and modify pool_func.go to simply utilize the non-func
pool+worker implementation\r\ntitle: 'Remove worker_func.go and modify
pool_func.go simplifying the library'\r\nlabels: ''\r\nassignees: @panj [...]
diff --git a/backend/plugins/github/tasks/pr_convertor.go
b/backend/plugins/github/tasks/pr_convertor.go
index 74be31a8e..4bee55443 100644
--- a/backend/plugins/github/tasks/pr_convertor.go
+++ b/backend/plugins/github/tasks/pr_convertor.go
@@ -18,6 +18,8 @@ limitations under the License.
package tasks
import (
+ "reflect"
+
"github.com/apache/incubator-devlake/core/dal"
"github.com/apache/incubator-devlake/core/errors"
"github.com/apache/incubator-devlake/core/models/domainlayer"
@@ -26,7 +28,6 @@ import (
"github.com/apache/incubator-devlake/core/plugin"
"github.com/apache/incubator-devlake/helpers/pluginhelper/api"
"github.com/apache/incubator-devlake/plugins/github/models"
- "reflect"
)
var ConvertPullRequestsMeta = plugin.SubTaskMeta{
@@ -74,7 +75,7 @@ func ConvertPullRequests(taskCtx plugin.SubTaskContext)
errors.Error {
},
BaseRepoId:
repoIdGen.Generate(data.Options.ConnectionId, pr.RepoId),
HeadRepoId:
repoIdGen.Generate(data.Options.ConnectionId, pr.HeadRepoId),
- Status: pr.State,
+ OriginalStatus: pr.State,
Title: pr.Title,
Url: pr.Url,
AuthorId:
accountIdGen.Generate(data.Options.ConnectionId, pr.AuthorId),
@@ -92,6 +93,13 @@ func ConvertPullRequests(taskCtx plugin.SubTaskContext)
errors.Error {
HeadRef: pr.HeadRef,
HeadCommitSha: pr.HeadCommitSha,
}
+ if pr.State == "open" || pr.State == "OPEN" {
+ domainPr.Status = code.OPEN
+ } else if (pr.State == "closed" && pr.MergedAt != nil)
|| pr.State == "MERGED" {
+ domainPr.Status = code.MERGED
+ } else {
+ domainPr.Status = code.CLOSED
+ }
return []interface{}{
domainPr,
}, nil
diff --git a/backend/plugins/github/tasks/pr_extractor.go
b/backend/plugins/github/tasks/pr_extractor.go
index 43b989c0b..7734306eb 100644
--- a/backend/plugins/github/tasks/pr_extractor.go
+++ b/backend/plugins/github/tasks/pr_extractor.go
@@ -27,12 +27,6 @@ import (
"github.com/apache/incubator-devlake/plugins/github/models"
)
-const (
- OPEN = "OPEN"
- CLOSED = "CLOSED"
- MERGED = "MERGED"
-)
-
var ExtractApiPullRequestsMeta = plugin.SubTaskMeta{
Name: "extractApiPullRequests",
EntryPoint: ExtractApiPullRequests,
@@ -189,13 +183,6 @@ func convertGithubPullRequest(pull *GithubApiPullRequest,
connId uint64, repoId
if pull.Head.Repo != nil {
githubPull.HeadRepoId = pull.Head.Repo.GithubId
}
- if pull.State == "open" {
- githubPull.State = OPEN
- } else if pull.State == "closed" && pull.MergedAt != nil {
- githubPull.State = MERGED
- } else {
- githubPull.State = CLOSED
- }
return githubPull, nil
}