mkmarek commented on PR #5077:
URL: 
https://github.com/apache/incubator-devlake/pull/5077#issuecomment-1542282721

   So I was experimenting a bit and one other viable solution would be to have 
one connection per app installation instead of per app itself. 
   
   So in the connection settings, I added a dropdown that gets populated once 
you input the appId and private key. When you save the connection the 
installationId that you get from the dropdown gets saved too
   
![image](https://github.com/apache/incubator-devlake/assets/7100597/db1aec49-9290-4770-9ec3-beba6c9988ae)
   
   The consequence of that is that when you create/edit the data scope there 
will be always only a single owner/organization because an installation is 
always related only to a single one:
   
![image](https://github.com/apache/incubator-devlake/assets/7100597/ac23f4b6-c9a2-4ffa-bc00-fbc1d0c2224b)
   
   So in the end you will have to create multiple connections for multiple 
installations, duplicating the private key and appId data between connections. 
That's the downside of this approach.
   
   The upside is that on the outside it works exactly as the previous token 
solution, so no code change in the impl parts is necessary.
   
   I'll push those changes shortly so please let me know what you think about 
it @klesh 
   
   I think it's not ideal but most cases will have only a handful (like 2 or 3) 
of installations, so it shouldn't be that much trouble.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to