Startrekzky commented on PR #5105:
URL: 
https://github.com/apache/incubator-devlake/pull/5105#issuecomment-1542339585

   Hi @martincrb, the logic of SQLs seems good. Just a few suggestions:
   
   1. can you add and paraphrase these detailed explanations of how you map 
each metric to the team (see the block below) to the dashboard introduction 
panel? 
   
   ```
   I get first the author of the specific commit and then I navigate to the 
team the user belongs to.
   I get the team from the PR's author.
   I get the team from the commit author.
   ```
   
   
![image](https://github.com/apache/incubator-devlake/assets/14050754/9029faaf-82ab-4d50-933f-5768b39532f5)
   
   2. Can you add a link to the team configuration doc 
(https://devlake.apache.org/docs/Configuration/TeamConfiguration ) in the 
dashboard introduction?
   
![image](https://github.com/apache/incubator-devlake/assets/14050754/c68255b3-c77d-41fa-83c8-d56cc7bc4d7d)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to