IronCore864 commented on PR #130: URL: https://github.com/apache/incubator-devlake-helm-chart/pull/130#issuecomment-1550731630
Hi @albinvass, I think DevLake would need a .env file to work: https://github.com/apache/incubator-devlake/blob/main/backend/core/config/config_viper.go#L37. I agree that this isn't following the 12-factor app rules, nor is it cloud-native. I'd propose creating an issue in the main repo to support loading configurations from ENV vars; then the chart update would be easy: - statefulset to deployment - no xxx-devlake-config configmap as .env file mounted as a volume - directly envFrom/configMapRef from the xxx-devlake-config configmap in the deployment Are you good with Golang? If so, maybe you can contribute a PR to add this small feature :) But it seems other deployment methods (like docker-compose) still rely on the .env file, so bear in mind to support both .env file and ENV vars. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
