This is an automated email from the ASF dual-hosted git repository.
zhangliang2022 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
The following commit(s) were added to refs/heads/main by this push:
new 2b190844d fix: add values of updated_date to the table.issue_comments
(#5217)
2b190844d is described below
commit 2b190844de47d343d84dcf351c6ac57aed826298
Author: abeizn <[email protected]>
AuthorDate: Wed May 17 16:04:02 2023 +0800
fix: add values of updated_date to the table.issue_comments (#5217)
* fix: add values of updated_date to the table.issue_comments
* fix: bitbucket created_date
* fix: bitbucket e2e
* fix: bitbucket e2e
* fix: bitbucket e2e
* fix: bitbucket e2e
* fix: bitbucket e2e
---
.../models/domainlayer/ticket/issue_comment.go | 4 +-
...20230517_add_updated_date_to_issue_comments.go} | 33 ++++++--
backend/core/models/migrationscripts/register.go | 1 +
backend/plugins/bitbucket/e2e/comment_test.go | 4 +
.../_tool_bitbucket_issue_comments.csv | 58 ++++++-------
.../e2e/snapshot_tables/issue_comments.csv | 58 ++++++-------
.../bitbucket/tasks/issue_comment_convertor.go | 6 +-
.../plugins/gitee/tasks/issue_comment_convertor.go | 6 +-
backend/plugins/github/e2e/comment_test.go | 1 +
.../github/e2e/snapshot_tables/issue_comments.csv | 98 +++++++++++-----------
.../github/tasks/issue_comment_convertor.go | 6 +-
.../plugins/jira/tasks/issue_comment_convertor.go | 6 +-
.../e2e/snapshot_tables/issue_comments.csv | 10 +--
.../plugins/teambition/e2e/task_comment_test.go | 8 +-
.../teambition/tasks/task_comment_converter.go | 7 +-
15 files changed, 174 insertions(+), 132 deletions(-)
diff --git a/backend/core/models/domainlayer/ticket/issue_comment.go
b/backend/core/models/domainlayer/ticket/issue_comment.go
index fd7a297ba..d510022ac 100644
--- a/backend/core/models/domainlayer/ticket/issue_comment.go
+++ b/backend/core/models/domainlayer/ticket/issue_comment.go
@@ -18,8 +18,9 @@ limitations under the License.
package ticket
import (
- "github.com/apache/incubator-devlake/core/models/domainlayer"
"time"
+
+ "github.com/apache/incubator-devlake/core/models/domainlayer"
)
type IssueComment struct {
@@ -28,6 +29,7 @@ type IssueComment struct {
Body string
AccountId string `gorm:"type:varchar(255)"`
CreatedDate time.Time
+ UpdatedDate *time.Time
}
func (IssueComment) TableName() string {
diff --git a/backend/core/models/domainlayer/ticket/issue_comment.go
b/backend/core/models/migrationscripts/20230517_add_updated_date_to_issue_comments.go
similarity index 52%
copy from backend/core/models/domainlayer/ticket/issue_comment.go
copy to
backend/core/models/migrationscripts/20230517_add_updated_date_to_issue_comments.go
index fd7a297ba..e59da1a65 100644
--- a/backend/core/models/domainlayer/ticket/issue_comment.go
+++
b/backend/core/models/migrationscripts/20230517_add_updated_date_to_issue_comments.go
@@ -15,21 +15,36 @@ See the License for the specific language governing
permissions and
limitations under the License.
*/
-package ticket
+package migrationscripts
import (
- "github.com/apache/incubator-devlake/core/models/domainlayer"
"time"
+
+ "github.com/apache/incubator-devlake/core/context"
+ "github.com/apache/incubator-devlake/core/errors"
+ "github.com/apache/incubator-devlake/core/plugin"
)
-type IssueComment struct {
- domainlayer.DomainEntity
- IssueId string `gorm:"index"`
- Body string
- AccountId string `gorm:"type:varchar(255)"`
- CreatedDate time.Time
+var _ plugin.MigrationScript = (*addUpdatedDateToIssueComments)(nil)
+
+type addUpdatedDateToIssueComments struct{}
+
+type issueComments20230517 struct {
+ UpdatedDate *time.Time
}
-func (IssueComment) TableName() string {
+func (issueComments20230517) TableName() string {
return "issue_comments"
}
+
+func (script *addUpdatedDateToIssueComments) Up(basicRes context.BasicRes)
errors.Error {
+ return basicRes.GetDal().AutoMigrate(&issueComments20230517{})
+}
+
+func (*addUpdatedDateToIssueComments) Version() uint64 {
+ return 20230517162121
+}
+
+func (*addUpdatedDateToIssueComments) Name() string {
+ return "add updated_date to issue_comments"
+}
diff --git a/backend/core/models/migrationscripts/register.go
b/backend/core/models/migrationscripts/register.go
index ecd58feef..cf069ca82 100644
--- a/backend/core/models/migrationscripts/register.go
+++ b/backend/core/models/migrationscripts/register.go
@@ -84,5 +84,6 @@ func All() []plugin.MigrationScript {
new(addCalendarMonths),
new(modifyPrLabelsAndComments),
new(renameFinishedCommitsDiffs),
+ new(addUpdatedDateToIssueComments),
}
}
diff --git a/backend/plugins/bitbucket/e2e/comment_test.go
b/backend/plugins/bitbucket/e2e/comment_test.go
index 83fbe2a35..eab43b4c6 100644
--- a/backend/plugins/bitbucket/e2e/comment_test.go
+++ b/backend/plugins/bitbucket/e2e/comment_test.go
@@ -64,6 +64,8 @@ func TestCommentDataFlow(t *testing.T) {
"author_name",
"author_id",
"type",
+ "body",
+ "bitbucket_updated_at",
),
)
dataflowTester.VerifyTable(
@@ -109,6 +111,8 @@ func TestCommentDataFlow(t *testing.T) {
"issue_id",
"body",
"account_id",
+ "body",
+ "updated_date",
),
)
diff --git
a/backend/plugins/bitbucket/e2e/snapshot_tables/_tool_bitbucket_issue_comments.csv
b/backend/plugins/bitbucket/e2e/snapshot_tables/_tool_bitbucket_issue_comments.csv
index c51d4da0d..9c8fe0517 100644
---
a/backend/plugins/bitbucket/e2e/snapshot_tables/_tool_bitbucket_issue_comments.csv
+++
b/backend/plugins/bitbucket/e2e/snapshot_tables/_tool_bitbucket_issue_comments.csv
@@ -1,29 +1,29 @@
-connection_id,bitbucket_id,issue_id,author_name,author_id,type,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark
-1,63860152,1,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,1,
-1,63860153,1,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,2,
-1,63860241,1,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,3,
-1,63961973,6,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,4,
-1,63961995,28,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,5,
-1,63963442,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,6,
-1,63963443,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,7,
-1,63963444,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,8,
-1,63963445,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,9,
-1,63963446,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,10,
-1,63963447,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,11,
-1,63963449,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,12,
-1,63963450,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,13,
-1,63963451,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,14,
-1,63963452,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,15,
-1,63963453,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,16,
-1,63963454,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,17,
-1,63963455,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,18,
-1,63963456,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,19,
-1,63963457,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,20,
-1,63963458,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,21,
-1,63963459,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,22,
-1,63963460,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,23,
-1,63963461,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,24,
-1,63963462,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,25,
-1,63963463,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,26,
-1,63963464,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,27,
-1,63963465,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,28,
+connection_id,bitbucket_id,issue_id,author_name,author_id,type,body,bitbucket_updated_at,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark
+1,63860152,1,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,1,
+1,63860153,1,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,this is a comment
test for
issue,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,2,
+1,63860241,1,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,3,
+1,63961973,6,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,4,
+1,63961995,28,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,5,
+1,63963442,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,gvoeaoivae,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,6,
+1,63963443,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,vboeaorboaneo,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,7,
+1,63963444,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,beoiroierbieiaoboere,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,8,
+1,63963445,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,boetboenavnin,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,9,
+1,63963446,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,bbenoirbnavbeboa,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,10,
+1,63963447,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,lboehoraebow,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,11,
+1,63963449,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,ebeobnoerioaeiow,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,12,
+1,63963450,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,uttrberoiea,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,13,
+1,63963451,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,obfbdfonwea,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,14,
+1,63963452,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,bjeorjboewaonwea,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,15,
+1,63963453,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,brtoeorbnqqe,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,16,
+1,63963454,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,mmboeroi,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,17,
+1,63963455,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,lqooaqjoe,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,18,
+1,63963456,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,vajoieiowaeovw,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,19,
+1,63963457,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,ieiojiwea,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,20,
+1,63963458,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,beraowheuovhaewa,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,21,
+1,63963459,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,oeorjeorb,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,22,
+1,63963460,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,iocowevoanewww,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,23,
+1,63963461,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,cowoehvowevaobnebiejaiweaw,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,24,
+1,63963462,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,vbleklawi,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,25,
+1,63963463,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,qowjoveawev,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,26,
+1,63963464,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,ciojboieria,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,27,
+1,63963465,27,teoiaoe,62abf394192edb006fa0e8cf,issue_comment,cwiwhoervowwwqe,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,28,
diff --git a/backend/plugins/bitbucket/e2e/snapshot_tables/issue_comments.csv
b/backend/plugins/bitbucket/e2e/snapshot_tables/issue_comments.csv
index 56d8aac6f..6a8b5a3c5 100644
--- a/backend/plugins/bitbucket/e2e/snapshot_tables/issue_comments.csv
+++ b/backend/plugins/bitbucket/e2e/snapshot_tables/issue_comments.csv
@@ -1,29 +1,29 @@
-id,issue_id,body,account_id,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark
-bitbucket:BitbucketIssueComment:1:63860152,bitbucket:BitbucketIssue:1:likyh/likyhphp:1,,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,1,
-bitbucket:BitbucketIssueComment:1:63860153,bitbucket:BitbucketIssue:1:likyh/likyhphp:1,this
is a comment test for
issue,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,2,
-bitbucket:BitbucketIssueComment:1:63860241,bitbucket:BitbucketIssue:1:likyh/likyhphp:1,,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,3,
-bitbucket:BitbucketIssueComment:1:63961973,bitbucket:BitbucketIssue:1:likyh/likyhphp:6,,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,4,
-bitbucket:BitbucketIssueComment:1:63961995,bitbucket:BitbucketIssue:1:likyh/likyhphp:28,,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,5,
-bitbucket:BitbucketIssueComment:1:63963442,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,gvoeaoivae,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,6,
-bitbucket:BitbucketIssueComment:1:63963443,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,vboeaorboaneo,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,7,
-bitbucket:BitbucketIssueComment:1:63963444,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,beoiroierbieiaoboere,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,8,
-bitbucket:BitbucketIssueComment:1:63963445,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,boetboenavnin,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,9,
-bitbucket:BitbucketIssueComment:1:63963446,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,bbenoirbnavbeboa,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,10,
-bitbucket:BitbucketIssueComment:1:63963447,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,lboehoraebow,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,11,
-bitbucket:BitbucketIssueComment:1:63963449,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,ebeobnoerioaeiow,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,12,
-bitbucket:BitbucketIssueComment:1:63963450,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,uttrberoiea,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,13,
-bitbucket:BitbucketIssueComment:1:63963451,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,obfbdfonwea,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,14,
-bitbucket:BitbucketIssueComment:1:63963452,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,bjeorjboewaonwea,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,15,
-bitbucket:BitbucketIssueComment:1:63963453,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,brtoeorbnqqe,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,16,
-bitbucket:BitbucketIssueComment:1:63963454,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,mmboeroi,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,17,
-bitbucket:BitbucketIssueComment:1:63963455,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,lqooaqjoe,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,18,
-bitbucket:BitbucketIssueComment:1:63963456,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,vajoieiowaeovw,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,19,
-bitbucket:BitbucketIssueComment:1:63963457,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,ieiojiwea,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,20,
-bitbucket:BitbucketIssueComment:1:63963458,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,beraowheuovhaewa,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,21,
-bitbucket:BitbucketIssueComment:1:63963459,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,oeorjeorb,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,22,
-bitbucket:BitbucketIssueComment:1:63963460,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,iocowevoanewww,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,23,
-bitbucket:BitbucketIssueComment:1:63963461,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,cowoehvowevaobnebiejaiweaw,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,24,
-bitbucket:BitbucketIssueComment:1:63963462,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,vbleklawi,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,25,
-bitbucket:BitbucketIssueComment:1:63963463,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,qowjoveawev,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,26,
-bitbucket:BitbucketIssueComment:1:63963464,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,ciojboieria,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,27,
-bitbucket:BitbucketIssueComment:1:63963465,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,cwiwhoervowwwqe,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,28,
+id,issue_id,body,account_id,updated_date,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark
+bitbucket:BitbucketIssueComment:1:63860152,bitbucket:BitbucketIssue:1:likyh/likyhphp:1,,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,1,
+bitbucket:BitbucketIssueComment:1:63860153,bitbucket:BitbucketIssue:1:likyh/likyhphp:1,this
is a comment test for
issue,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,2,
+bitbucket:BitbucketIssueComment:1:63860241,bitbucket:BitbucketIssue:1:likyh/likyhphp:1,,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,3,
+bitbucket:BitbucketIssueComment:1:63961973,bitbucket:BitbucketIssue:1:likyh/likyhphp:6,,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,4,
+bitbucket:BitbucketIssueComment:1:63961995,bitbucket:BitbucketIssue:1:likyh/likyhphp:28,,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,5,
+bitbucket:BitbucketIssueComment:1:63963442,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,gvoeaoivae,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,6,
+bitbucket:BitbucketIssueComment:1:63963443,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,vboeaorboaneo,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,7,
+bitbucket:BitbucketIssueComment:1:63963444,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,beoiroierbieiaoboere,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,8,
+bitbucket:BitbucketIssueComment:1:63963445,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,boetboenavnin,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,9,
+bitbucket:BitbucketIssueComment:1:63963446,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,bbenoirbnavbeboa,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,10,
+bitbucket:BitbucketIssueComment:1:63963447,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,lboehoraebow,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,11,
+bitbucket:BitbucketIssueComment:1:63963449,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,ebeobnoerioaeiow,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,12,
+bitbucket:BitbucketIssueComment:1:63963450,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,uttrberoiea,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,13,
+bitbucket:BitbucketIssueComment:1:63963451,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,obfbdfonwea,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,14,
+bitbucket:BitbucketIssueComment:1:63963452,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,bjeorjboewaonwea,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,15,
+bitbucket:BitbucketIssueComment:1:63963453,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,brtoeorbnqqe,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,16,
+bitbucket:BitbucketIssueComment:1:63963454,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,mmboeroi,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,17,
+bitbucket:BitbucketIssueComment:1:63963455,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,lqooaqjoe,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,18,
+bitbucket:BitbucketIssueComment:1:63963456,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,vajoieiowaeovw,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,19,
+bitbucket:BitbucketIssueComment:1:63963457,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,ieiojiwea,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,20,
+bitbucket:BitbucketIssueComment:1:63963458,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,beraowheuovhaewa,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,21,
+bitbucket:BitbucketIssueComment:1:63963459,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,oeorjeorb,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,22,
+bitbucket:BitbucketIssueComment:1:63963460,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,iocowevoanewww,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,23,
+bitbucket:BitbucketIssueComment:1:63963461,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,cowoehvowevaobnebiejaiweaw,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,24,
+bitbucket:BitbucketIssueComment:1:63963462,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,vbleklawi,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,25,
+bitbucket:BitbucketIssueComment:1:63963463,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,qowjoveawev,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,26,
+bitbucket:BitbucketIssueComment:1:63963464,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,ciojboieria,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,27,
+bitbucket:BitbucketIssueComment:1:63963465,bitbucket:BitbucketIssue:1:likyh/likyhphp:27,cwiwhoervowwwqe,bitbucket:BitbucketAccount:1:62abf394192edb006fa0e8cf,,"{""ConnectionId"":1,""FullName"":""likyh/likyhphp""}",_raw_bitbucket_api_issue_comments,28,
diff --git a/backend/plugins/bitbucket/tasks/issue_comment_convertor.go
b/backend/plugins/bitbucket/tasks/issue_comment_convertor.go
index 420a9be8b..dcae35d10 100644
--- a/backend/plugins/bitbucket/tasks/issue_comment_convertor.go
+++ b/backend/plugins/bitbucket/tasks/issue_comment_convertor.go
@@ -18,6 +18,8 @@ limitations under the License.
package tasks
import (
+ "reflect"
+
"github.com/apache/incubator-devlake/core/dal"
"github.com/apache/incubator-devlake/core/errors"
"github.com/apache/incubator-devlake/core/models/domainlayer"
@@ -26,7 +28,6 @@ import (
plugin "github.com/apache/incubator-devlake/core/plugin"
"github.com/apache/incubator-devlake/helpers/pluginhelper/api"
"github.com/apache/incubator-devlake/plugins/bitbucket/models"
- "reflect"
)
var ConvertIssueCommentsMeta = plugin.SubTaskMeta{
@@ -69,7 +70,8 @@ func ConvertIssueComments(taskCtx plugin.SubTaskContext)
errors.Error {
},
IssueId:
issueIdGen.Generate(data.Options.ConnectionId, data.Options.FullName,
bitbucketIssueComment.IssueId),
AccountId:
accountIdGen.Generate(data.Options.ConnectionId,
bitbucketIssueComment.AuthorId),
- CreatedDate: bitbucketIssueComment.CreatedAt,
+ CreatedDate:
bitbucketIssueComment.BitbucketCreatedAt,
+ UpdatedDate:
bitbucketIssueComment.BitbucketUpdatedAt,
Body: bitbucketIssueComment.Body,
}
return []interface{}{
diff --git a/backend/plugins/gitee/tasks/issue_comment_convertor.go
b/backend/plugins/gitee/tasks/issue_comment_convertor.go
index 23fe6662c..d76951191 100644
--- a/backend/plugins/gitee/tasks/issue_comment_convertor.go
+++ b/backend/plugins/gitee/tasks/issue_comment_convertor.go
@@ -18,6 +18,8 @@ limitations under the License.
package tasks
import (
+ "reflect"
+
"github.com/apache/incubator-devlake/core/dal"
"github.com/apache/incubator-devlake/core/errors"
"github.com/apache/incubator-devlake/core/models/domainlayer"
@@ -26,7 +28,6 @@ import (
"github.com/apache/incubator-devlake/core/plugin"
helper "github.com/apache/incubator-devlake/helpers/pluginhelper/api"
"github.com/apache/incubator-devlake/plugins/gitee/models"
- "reflect"
)
var ConvertIssueCommentsMeta = plugin.SubTaskMeta{
@@ -71,6 +72,9 @@ func ConvertIssueComments(taskCtx plugin.SubTaskContext)
errors.Error {
AccountId:
accountIdGen.Generate(data.Options.ConnectionId,
giteeIssueComment.AuthorUserId),
CreatedDate: giteeIssueComment.GiteeCreatedAt,
}
+ if !giteeIssueComment.GiteeUpdatedAt.IsZero() {
+ domainIssueComment.UpdatedDate =
&giteeIssueComment.GiteeUpdatedAt
+ }
return []interface{}{
domainIssueComment,
}, nil
diff --git a/backend/plugins/github/e2e/comment_test.go
b/backend/plugins/github/e2e/comment_test.go
index f43c6d5c3..17147bdab 100644
--- a/backend/plugins/github/e2e/comment_test.go
+++ b/backend/plugins/github/e2e/comment_test.go
@@ -130,6 +130,7 @@ func TestCommentDataFlow(t *testing.T) {
"body",
"account_id",
"created_date",
+ "updated_date",
"_raw_data_params",
"_raw_data_table",
"_raw_data_id",
diff --git a/backend/plugins/github/e2e/snapshot_tables/issue_comments.csv
b/backend/plugins/github/e2e/snapshot_tables/issue_comments.csv
index d07a086a4..3d47d59b9 100644
--- a/backend/plugins/github/e2e/snapshot_tables/issue_comments.csv
+++ b/backend/plugins/github/e2e/snapshot_tables/issue_comments.csv
@@ -1,49 +1,49 @@
-id,issue_id,body,account_id,created_date,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark
-github:GithubIssue:1:409800144,github:GithubIssue:1:346842831,""" chinese
freeSignal chinese idleWorkers chinese ， chinese ， chinese freeSignal chinese
idleWorkers chinese worker chinese ，putWorker chinese worker chinese
idleWorkers， chinese freeSignal， chinese idleWorkers chinese worker chinese
freeSignal chinese ， chinese worker chinese freeSignal chinese
""",github:GithubAccount:1:7496278,2018-08-02T04:13:09.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_
[...]
-github:GithubIssue:1:410141732,github:GithubIssue:1:347255859,""" chinese
\r\n\r\n chinese \r\n9913 @ 0x42c73a 0x42c7ee 0x43cf64 0x43cc7d 0x46dfe8
0x7b28e0 0x7b2be5
0x4591f1\r\n#\t0x43cc7c\tsync.runtime_SemacquireMutex+0x3c\t\t\t\tE:/go/src/runtime/sema.go:71\r\n#\t0x46dfe7\tsync.(*Mutex).Lock+0x107\t\t\t\t\tE:/go/src/sync/mutex.go:134\r\n#\t0x7b28df\tmp/vendor/github.com/panjf2000/ants.(*Pool).putWorker+0x6f\tF:/gowork/src/mp/vendor/github.com/panjf2000/ants/pool.go:229\r\n#\t0x7b2be4\t
[...]
-github:GithubIssue:1:410143221,github:GithubIssue:1:347255859,""" chinese
。。。\r\npanic: runtime error: index out of range\r\n\r\ngoroutine 7
[running]:\r\nmp/vendor/github.com/panjf2000/ants.(*Pool).getWorker(0xc4200b6460,
0xc4202a6e01)\r\n\tF:/gowork/src/mp/vendor/github.com/panjf2000/ants/pool.go:213
+0x2ce\r\nmp/vendor/github.com/panjf2000/ants.(*Pool).Submit(0xc4200b6460,
0xc4223d47d0, 0x0,
0x0)\r\n\tF:/gowork/src/mp/vendor/github.com/panjf2000/ants/pool.go:125
+0x62\r\n""",github:Gi [...]
-github:GithubIssue:1:410147487,github:GithubIssue:1:347255859,"""@lovelly
chinese ， chinese ， chinese
？""",github:GithubAccount:1:7496278,2018-08-03T05:21:03.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3169,
-github:GithubIssue:1:410170764,github:GithubIssue:1:347255859,"""😄 😄 😄
chinese ， chinese print chinese ， chinese bug 9913 chinese putWorker chinese
。，。。。""",github:GithubAccount:1:13118848,2018-08-03T07:33:21.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3170,
-github:GithubIssue:1:410173358,github:GithubIssue:1:347255859,"""\r\n
chinese idleWorkers chinese ， chinese n chinese 204 chinese
\t<-p.freeSignal， chinese worker chinese idleWorkers， chinese putWorker
chinese ， chinese 190 chinese p.lock.Lock() chinese ， chinese n :=
len(idleWorkers) - 1 chinese 0 chinese else chinese , chinese ，p.freeSignal
chinese 204 chinese ， chi [...]
-github:GithubIssue:1:410204870,github:GithubIssue:1:347255859,"""@lovelly
chinese ， chinese ， chinese ；\r\n chinese ， chinese 1000w chinese ， chinese ，
chinese
？""",github:GithubAccount:1:7496278,2018-08-03T09:51:15.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3172,
-github:GithubIssue:1:410205295,github:GithubIssue:1:347255859,"""😄 😄 😄
chinese 0 chinese 60 chinese
。。。""",github:GithubAccount:1:13118848,2018-08-03T09:53:00.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3173,
-github:GithubIssue:1:410267195,github:GithubIssue:1:347255859,"""@lovelly
chinese ， chinese
""",github:GithubAccount:1:7496278,2018-08-03T14:15:45.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3174,
-github:GithubIssue:1:410290418,github:GithubIssue:1:346842831,""" chinese #6
""",github:GithubAccount:1:7496278,2018-08-03T15:32:00.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3175,
-github:GithubIssue:1:411342200,github:GithubIssue:1:348630179,"""@huiwq1990
chinese ， chinese
。""",github:GithubAccount:1:7496278,2018-08-08T09:17:30.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3176,
-github:GithubIssue:1:411369513,github:GithubIssue:1:348630179,"""@huiwq1990
chinese ， chinese
""",github:GithubAccount:1:7496278,2018-08-08T11:06:55.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3177,
-github:GithubIssue:1:411965696,github:GithubIssue:1:348630179,""" chinese ，
chinese
""",github:GithubAccount:1:4555057,2018-08-10T03:35:53.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3178,
-github:GithubIssue:1:411969260,github:GithubIssue:1:348630179,"""@huiwq1990
chinese ， chinese issue chinese
。""",github:GithubAccount:1:7496278,2018-08-10T04:06:04.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3179,
-github:GithubIssue:1:418287926,github:GithubIssue:1:356703393,""" chinese ，
chinese cpu chinese
""",github:GithubAccount:1:7496278,2018-09-04T08:40:06.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3184,
-github:GithubIssue:1:418290090,github:GithubIssue:1:356703393,""" chinese
goroutine chinese submit chinese
""",github:GithubAccount:1:11763614,2018-09-04T08:47:39.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3185,
-github:GithubIssue:1:418293975,github:GithubIssue:1:356703393,""" chinese ，
chinese submit chinese goroutine chinese ， chinese
goroutine。""",github:GithubAccount:1:7496278,2018-09-04T09:00:55.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3186,
-github:GithubIssue:1:418297020,github:GithubIssue:1:356703393,"""// Submit
submits a task to this pool.\r\nfunc (p *Pool) Submit(task f) error {\r\n\tif
len(p.release) > 0 {\r\n\t\treturn ErrPoolClosed\r\n\t}\r\n\tp.getWorker().task
<- task\r\n\treturn nil\r\n}\r\n chinese p.getWorker() chinese ， chinese
pool chinese
""",github:GithubAccount:1:11763614,2018-09-04T09:11:37.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3187,
-github:GithubIssue:1:425014962,github:GithubIssue:1:364361014,""" chinese tag，
chinese \r\n\r\nedcismybrother <[email protected]> chinese 2018 chinese
9 chinese 27 chinese chinese 4:32 chinese ：\r\n\r\n> chinese dep chinese ，
chinese ants chinese ， chinese tag chinese 。 chinese tag\r\n> 3.6 chinese
ed55924 chinese ，git chinese af376f1b chinese ， chinese 5 chinese ， chinese ，
chinese tag chinese 。（ chinese ）\r\n>\r\n> —\r\n> You are receiving this
because you are subscribed to [...]
-github:GithubIssue:1:425018770,github:GithubIssue:1:356703393,""" chinese cpu
chinese 。 chinese Submit chinese ， chinese worker， chinese \r\n```\t\t\r\nfor
{\r\n\t\t\tp.lock.Lock()\r\n\t\t\tidleWorkers = p.workers\r\n\t\t\tl :=
len(idleWorkers) - 1\r\n\t\t\tif l < 0
{\r\n\t\t\t\tp.lock.Unlock()\r\n\t\t\t\tcontinue\r\n\t\t\t}\r\n\t\t\tw =
idleWorkers[l]\r\n\t\t\tidleWorkers[l] = nil\r\n\t\t\tp.workers =
idleWorkers[:l]\r\n\t\t\tp.lock.Unlock()\r\n\t\t\tbreak\r\n\t\t}\r\n```\r\n
chinese co [...]
-github:GithubIssue:1:425061837,github:GithubIssue:1:356703393,"""\r\n\r\ncpu
chinese
100%\r\n\r\n\r\n""",github:GithubAccount:1:12890888,2018-09-27T11:53:26.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3191,
-github:GithubIssue:1:425062926,github:GithubIssue:1:364361014,"""tag chinese
，v3.7\r\n\r\nAndy Pan <[email protected]> chinese 2018 chinese 9 chinese 27
chinese chinese 5:00 chinese ：\r\n\r\n> chinese tag， chinese \r\n>\r\n>
edcismybrother <[email protected]> chinese 2018 chinese 9 chinese 27
chinese chinese 4:32 chinese ：\r\n>\r\n>> chinese dep chinese ， chinese ants
chinese ， chinese tag chinese 。 chinese tag\r\n>> 3.6 chinese ed55924 chinese
，git chinese af376f1b chin [...]
-github:GithubIssue:1:425066089,github:GithubIssue:1:356703393,"""@liyonglion
chinese ， chinese ，pool chinese 1， chinese cpu chinese ， chinese block chinese
， chinese cpu chinese ， chinese ？ chinese ， chinese
。""",github:GithubAccount:1:7496278,2018-09-27T12:07:30.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3193,
-github:GithubIssue:1:425288734,github:GithubIssue:1:356703393,"""@panjf2000
ants chinese “ chinese ” chinese ， chinese “ chinese ” chinese ， chinese 。
chinese block chinese Submit chinese “ chinese
”？""",github:GithubAccount:1:12890888,2018-09-28T01:09:40.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3194,
-github:GithubIssue:1:425293042,github:GithubIssue:1:356703393,"""@liyonglion
chinese chan chinese ， chinese ：#6， chinese 。 chinese submit chinese cpu 100%
chinese ？ chinese ， chinese ， chinese ？ chinese
pr。""",github:GithubAccount:1:7496278,2018-09-28T01:37:17.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3195,
-github:GithubIssue:1:425331360,github:GithubIssue:1:364361014,"""@panjf2000
chinese ， chinese
""",github:GithubAccount:1:29452204,2018-09-28T06:05:58.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3196,
-github:GithubIssue:1:425409255,github:GithubIssue:1:356703393,"""@panjf2000
chinese pr， chinese ？ chinese ， chinese 。 chinese
。""",github:GithubAccount:1:12890888,2018-09-28T11:41:08.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3197,
-github:GithubIssue:1:425423023,github:GithubIssue:1:356703393,"""@liyonglion
chinese ， chinese ：\r\n1. chinese pr， chinese ants_test.go chinese import ants
chinese ；\r\n2. chinese pool.go chinese ， chinese pool_func.go chinese
。""",github:GithubAccount:1:7496278,2018-09-28T12:41:27.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3198,
-github:GithubIssue:1:439792581,github:GithubIssue:1:382039050,"""GOMAXPROCS
chinese G-P-M chinese M chinese ， chinese
。""",github:GithubAccount:1:7496278,2018-11-19T07:10:47.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3229,
-github:GithubIssue:1:439793939,github:GithubIssue:1:381941219,"""release
chinese ， chinese ， chinese goroutine chinese ， chinese ， chinese
pr""",github:GithubAccount:1:7496278,2018-11-19T07:18:05.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3231,
-github:GithubIssue:1:440207809,github:GithubIssue:1:382574800,"""https://github.com/panjf2000/ants/blob/711dbdb7a222771ce15aaee1bb7b7c6e9731f208/pool.go#L119""",github:GithubAccount:1:5668717,2018-11-20T09:41:24.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3232,
-github:GithubIssue:1:440263871,github:GithubIssue:1:382574800,""" chinese ，
chinese ， chinese channel， chinese
？""",github:GithubAccount:1:7496278,2018-11-20T12:56:13.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3233,
-github:GithubIssue:1:440500490,github:GithubIssue:1:382574800,"""> chinese ，
chinese ， chinese channel， chinese ？\r\n\r\n chinese 。 chinese ， chinese ，
chinese ❓ chinese
。""",github:GithubAccount:1:5668717,2018-11-21T02:00:22.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3234,
-github:GithubIssue:1:440541883,github:GithubIssue:1:382574800,""" chinese
chan\r\n\r\ntype msg struct {\r\n……\r\nFailed chan<- *msg\r\n}\r\n\r\n//
payload == &msg\r\npool,_:= NewPoolWithFunc(10,func(payload interface{})
error{\r\n……\r\n// chinese payload chinese Failed
chan\r\n})\r\n\r\npool.Serve(msg)""",github:GithubAccount:1:7931755,2018-11-21T05:57:51.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3235,
-github:GithubIssue:1:440605531,github:GithubIssue:1:382574800,"""> chinese
chan\r\n> \r\n> type msg struct {\r\n> ……\r\n> Failed chan<- *msg\r\n> }\r\n>
\r\n> // payload == &msg\r\n> pool,_:= NewPoolWithFunc(10,func(payload
interface{}) error{\r\n> ……\r\n> // chinese payload chinese Failed chan\r\n>
})\r\n> \r\n> pool.Serve(msg)\r\n\r\n chinese `NewPoolWithFunc()`， chinese
`ants.NewPool()`， chinese `pool`， chinese `pool` chinese ：\r\n\r\n```\r\nfunc
(w *Worker) Register(fn func() e [...]
-github:GithubIssue:1:440876192,github:GithubIssue:1:382574800,""" chinese ，
chinese ants chinese ， chinese ， chinese return error chinese ， chinese ；
chinese ，❓ chinese ：1. chinese ；2. chinese ( chinese channel chinese )， chinese
ants chinese ， chinese ， chinese pr， chinese
~~""",github:GithubAccount:1:7496278,2018-11-22T01:09:56.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3237,
-github:GithubIssue:1:442366878,github:GithubIssue:1:381941219,""" chinese
pool chinese waitgroup， chinese chinese work， chinese waitgroup.Add()，
chinese waitgroup.Done()。 chinese release chinese waitgroup.Wait()。 chinese
worker。 chinese b chinese worker chinese func chinese ， chinese release
chinese
。""",github:GithubAccount:1:32898629,2018-11-28T08:48:17.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3238,
-github:GithubIssue:1:445462719,github:GithubIssue:1:388907811,""" chinese go
chinese
？""",github:GithubAccount:1:7496278,2018-12-08T14:20:26.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3239,
-github:GithubIssue:1:445496131,github:GithubIssue:1:388907811,"""go version
go1.11.1 darwin/amd64\r\n\r\n chinese ， chinese Semaphore chinese AntsPool
chinese
""",github:GithubAccount:1:720086,2018-12-08T22:56:54.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3240,
-github:GithubIssue:1:445815378,github:GithubIssue:1:388907811,""" chinese ，
chinese 。\r\nants chinese ：\r\n1. chinese ( chinese )；\r\n2. goroutine chinese
（ chinese goroutine， chinese ， chinese goroutine chinese ， chinese ）；\r\n3.
ants pool chinese ， chinese pool size、 chinese pool；\r\n4. chinese goroutine
chinese 、 chinese goroutine chinese ， chinese
；\r\n......""",github:GithubAccount:1:7496278,2018-12-10T13:30:04.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_gith
[...]
-github:GithubIssue:1:446447291,github:GithubIssue:1:388907811,""" chinese ，
chinese ？ chinese go routines chinese ， chinese ants chinese
？""",github:GithubAccount:1:720086,2018-12-12T03:18:44.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3242,
-github:GithubIssue:1:446453643,github:GithubIssue:1:388907811,""" chinese
benchmem=true chinese ； chinese ， chinese pool chinese goroutines chinese ，
chinese goroutine chinese ， chinese sema chinese goroutine chinese ， chinese ，
chinese
goroutine。""",github:GithubAccount:1:7496278,2018-12-12T03:58:29.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3243,
-github:GithubIssue:1:456022133,github:GithubIssue:1:401277739,""" chinese ，
chinese 。 chinese
。""",github:GithubAccount:1:7496278,2019-01-21T10:21:24.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3244,
-github:GithubIssue:1:456022560,github:GithubIssue:1:401277739,""" chinese ，
chinese
PR。""",github:GithubAccount:1:7496278,2019-01-21T10:22:39.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3245,
-github:GithubIssue:1:459948887,github:GithubIssue:1:405951301,"""@jiashiwen
\r\nIt works on my side, pls make sure that you run the example on top of the
latest ants code,
thanks.""",github:GithubAccount:1:7496278,2019-02-02T09:03:51.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3252,
-github:GithubIssue:1:468919580,github:GithubIssue:1:413968505,""" chinese
，incRunning chinese
。""",github:GithubAccount:1:7496278,2019-03-02T13:14:05.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3253,
-github:GithubIssue:1:471299071,github:GithubIssue:1:419183961,"""server
chinese
？""",github:GithubAccount:1:7496278,2019-03-10T13:18:01.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3254,
-github:GithubIssue:1:471869506,github:GithubIssue:1:419268851,""" chinese ，
chinese ， chinese
？""",github:GithubAccount:1:29243953,2019-03-12T06:06:39.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3255,
+id,issue_id,body,account_id,created_date,updated_date,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark
+github:GithubIssue:1:409800144,github:GithubIssue:1:346842831,""" chinese
freeSignal chinese idleWorkers chinese ， chinese ， chinese freeSignal chinese
idleWorkers chinese worker chinese ，putWorker chinese worker chinese
idleWorkers， chinese freeSignal， chinese idleWorkers chinese worker chinese
freeSignal chinese ， chinese worker chinese freeSignal chinese
""",github:GithubAccount:1:7496278,2018-08-02T04:13:09.000+00:00,2018-08-02T04:13:09.000+00:00,"{""ConnectionId"":1,""Name"":""panjf
[...]
+github:GithubIssue:1:410141732,github:GithubIssue:1:347255859,""" chinese
\r\n\r\n chinese \r\n9913 @ 0x42c73a 0x42c7ee 0x43cf64 0x43cc7d 0x46dfe8
0x7b28e0 0x7b2be5
0x4591f1\r\n#\t0x43cc7c\tsync.runtime_SemacquireMutex+0x3c\t\t\t\tE:/go/src/runtime/sema.go:71\r\n#\t0x46dfe7\tsync.(*Mutex).Lock+0x107\t\t\t\t\tE:/go/src/sync/mutex.go:134\r\n#\t0x7b28df\tmp/vendor/github.com/panjf2000/ants.(*Pool).putWorker+0x6f\tF:/gowork/src/mp/vendor/github.com/panjf2000/ants/pool.go:229\r\n#\t0x7b2be4\t
[...]
+github:GithubIssue:1:410143221,github:GithubIssue:1:347255859,""" chinese
。。。\r\npanic: runtime error: index out of range\r\n\r\ngoroutine 7
[running]:\r\nmp/vendor/github.com/panjf2000/ants.(*Pool).getWorker(0xc4200b6460,
0xc4202a6e01)\r\n\tF:/gowork/src/mp/vendor/github.com/panjf2000/ants/pool.go:213
+0x2ce\r\nmp/vendor/github.com/panjf2000/ants.(*Pool).Submit(0xc4200b6460,
0xc4223d47d0, 0x0,
0x0)\r\n\tF:/gowork/src/mp/vendor/github.com/panjf2000/ants/pool.go:125
+0x62\r\n""",github:Gi [...]
+github:GithubIssue:1:410147487,github:GithubIssue:1:347255859,"""@lovelly
chinese ， chinese ， chinese
？""",github:GithubAccount:1:7496278,2018-08-03T05:21:03.000+00:00,2018-08-03T05:21:13.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3169,
+github:GithubIssue:1:410170764,github:GithubIssue:1:347255859,"""😄 😄 😄
chinese ， chinese print chinese ， chinese bug 9913 chinese putWorker chinese
。，。。。""",github:GithubAccount:1:13118848,2018-08-03T07:33:21.000+00:00,2018-08-03T07:33:21.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3170,
+github:GithubIssue:1:410173358,github:GithubIssue:1:347255859,"""\r\n
chinese idleWorkers chinese ， chinese n chinese 204 chinese
\t<-p.freeSignal， chinese worker chinese idleWorkers， chinese putWorker
chinese ， chinese 190 chinese p.lock.Lock() chinese ， chinese n :=
len(idleWorkers) - 1 chinese 0 chinese else chinese , chinese ，p.freeSignal
chinese 204 chinese ， chi [...]
+github:GithubIssue:1:410204870,github:GithubIssue:1:347255859,"""@lovelly
chinese ， chinese ， chinese ；\r\n chinese ， chinese 1000w chinese ， chinese ，
chinese
？""",github:GithubAccount:1:7496278,2018-08-03T09:51:15.000+00:00,2018-08-03T09:52:04.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3172,
+github:GithubIssue:1:410205295,github:GithubIssue:1:347255859,"""😄 😄 😄
chinese 0 chinese 60 chinese
。。。""",github:GithubAccount:1:13118848,2018-08-03T09:53:00.000+00:00,2018-08-03T09:53:00.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3173,
+github:GithubIssue:1:410267195,github:GithubIssue:1:347255859,"""@lovelly
chinese ， chinese
""",github:GithubAccount:1:7496278,2018-08-03T14:15:45.000+00:00,2018-08-03T14:15:45.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3174,
+github:GithubIssue:1:410290418,github:GithubIssue:1:346842831,""" chinese #6
""",github:GithubAccount:1:7496278,2018-08-03T15:32:00.000+00:00,2018-08-03T15:32:00.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3175,
+github:GithubIssue:1:411342200,github:GithubIssue:1:348630179,"""@huiwq1990
chinese ， chinese
。""",github:GithubAccount:1:7496278,2018-08-08T09:17:30.000+00:00,2018-08-08T09:17:30.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3176,
+github:GithubIssue:1:411369513,github:GithubIssue:1:348630179,"""@huiwq1990
chinese ， chinese
""",github:GithubAccount:1:7496278,2018-08-08T11:06:55.000+00:00,2018-08-08T11:06:55.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3177,
+github:GithubIssue:1:411965696,github:GithubIssue:1:348630179,""" chinese ，
chinese
""",github:GithubAccount:1:4555057,2018-08-10T03:35:53.000+00:00,2018-08-10T03:35:53.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3178,
+github:GithubIssue:1:411969260,github:GithubIssue:1:348630179,"""@huiwq1990
chinese ， chinese issue chinese
。""",github:GithubAccount:1:7496278,2018-08-10T04:06:04.000+00:00,2018-08-10T04:06:04.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3179,
+github:GithubIssue:1:418287926,github:GithubIssue:1:356703393,""" chinese ，
chinese cpu chinese
""",github:GithubAccount:1:7496278,2018-09-04T08:40:06.000+00:00,2018-09-04T08:40:06.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3184,
+github:GithubIssue:1:418290090,github:GithubIssue:1:356703393,""" chinese
goroutine chinese submit chinese
""",github:GithubAccount:1:11763614,2018-09-04T08:47:39.000+00:00,2018-09-04T08:47:39.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3185,
+github:GithubIssue:1:418293975,github:GithubIssue:1:356703393,""" chinese ，
chinese submit chinese goroutine chinese ， chinese
goroutine。""",github:GithubAccount:1:7496278,2018-09-04T09:00:55.000+00:00,2018-09-04T09:00:55.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3186,
+github:GithubIssue:1:418297020,github:GithubIssue:1:356703393,"""// Submit
submits a task to this pool.\r\nfunc (p *Pool) Submit(task f) error {\r\n\tif
len(p.release) > 0 {\r\n\t\treturn ErrPoolClosed\r\n\t}\r\n\tp.getWorker().task
<- task\r\n\treturn nil\r\n}\r\n chinese p.getWorker() chinese ， chinese
pool chinese
""",github:GithubAccount:1:11763614,2018-09-04T09:11:37.000+00:00,2018-09-04T09:11:37.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3187,
+github:GithubIssue:1:425014962,github:GithubIssue:1:364361014,""" chinese tag，
chinese \r\n\r\nedcismybrother <[email protected]> chinese 2018 chinese
9 chinese 27 chinese chinese 4:32 chinese ：\r\n\r\n> chinese dep chinese ，
chinese ants chinese ， chinese tag chinese 。 chinese tag\r\n> 3.6 chinese
ed55924 chinese ，git chinese af376f1b chinese ， chinese 5 chinese ， chinese ，
chinese tag chinese 。（ chinese ）\r\n>\r\n> —\r\n> You are receiving this
because you are subscribed to [...]
+github:GithubIssue:1:425018770,github:GithubIssue:1:356703393,""" chinese cpu
chinese 。 chinese Submit chinese ， chinese worker， chinese \r\n```\t\t\r\nfor
{\r\n\t\t\tp.lock.Lock()\r\n\t\t\tidleWorkers = p.workers\r\n\t\t\tl :=
len(idleWorkers) - 1\r\n\t\t\tif l < 0
{\r\n\t\t\t\tp.lock.Unlock()\r\n\t\t\t\tcontinue\r\n\t\t\t}\r\n\t\t\tw =
idleWorkers[l]\r\n\t\t\tidleWorkers[l] = nil\r\n\t\t\tp.workers =
idleWorkers[:l]\r\n\t\t\tp.lock.Unlock()\r\n\t\t\tbreak\r\n\t\t}\r\n```\r\n
chinese co [...]
+github:GithubIssue:1:425061837,github:GithubIssue:1:356703393,"""\r\n\r\ncpu
chinese
100%\r\n\r\n\r\n""",github:GithubAccount:1:12890888,2018-09-27T11:53:26.000+00:00,2018-09-27T11:53:26.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_g
[...]
+github:GithubIssue:1:425062926,github:GithubIssue:1:364361014,"""tag chinese
，v3.7\r\n\r\nAndy Pan <[email protected]> chinese 2018 chinese 9 chinese 27
chinese chinese 5:00 chinese ：\r\n\r\n> chinese tag， chinese \r\n>\r\n>
edcismybrother <[email protected]> chinese 2018 chinese 9 chinese 27
chinese chinese 4:32 chinese ：\r\n>\r\n>> chinese dep chinese ， chinese ants
chinese ， chinese tag chinese 。 chinese tag\r\n>> 3.6 chinese ed55924 chinese
，git chinese af376f1b chin [...]
+github:GithubIssue:1:425066089,github:GithubIssue:1:356703393,"""@liyonglion
chinese ， chinese ，pool chinese 1， chinese cpu chinese ， chinese block chinese
， chinese cpu chinese ， chinese ？ chinese ， chinese
。""",github:GithubAccount:1:7496278,2018-09-27T12:07:30.000+00:00,2018-09-27T12:07:30.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3193,
+github:GithubIssue:1:425288734,github:GithubIssue:1:356703393,"""@panjf2000
ants chinese “ chinese ” chinese ， chinese “ chinese ” chinese ， chinese 。
chinese block chinese Submit chinese “ chinese
”？""",github:GithubAccount:1:12890888,2018-09-28T01:09:40.000+00:00,2018-09-28T01:09:40.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3194,
+github:GithubIssue:1:425293042,github:GithubIssue:1:356703393,"""@liyonglion
chinese chan chinese ， chinese ：#6， chinese 。 chinese submit chinese cpu 100%
chinese ？ chinese ， chinese ， chinese ？ chinese
pr。""",github:GithubAccount:1:7496278,2018-09-28T01:37:17.000+00:00,2018-09-28T01:37:27.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3195,
+github:GithubIssue:1:425331360,github:GithubIssue:1:364361014,"""@panjf2000
chinese ， chinese
""",github:GithubAccount:1:29452204,2018-09-28T06:05:58.000+00:00,2018-09-28T06:05:58.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3196,
+github:GithubIssue:1:425409255,github:GithubIssue:1:356703393,"""@panjf2000
chinese pr， chinese ？ chinese ， chinese 。 chinese
。""",github:GithubAccount:1:12890888,2018-09-28T11:41:08.000+00:00,2018-09-28T11:41:08.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3197,
+github:GithubIssue:1:425423023,github:GithubIssue:1:356703393,"""@liyonglion
chinese ， chinese ：\r\n1. chinese pr， chinese ants_test.go chinese import ants
chinese ；\r\n2. chinese pool.go chinese ， chinese pool_func.go chinese
。""",github:GithubAccount:1:7496278,2018-09-28T12:41:27.000+00:00,2018-09-28T12:43:06.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3198,
+github:GithubIssue:1:439792581,github:GithubIssue:1:382039050,"""GOMAXPROCS
chinese G-P-M chinese M chinese ， chinese
。""",github:GithubAccount:1:7496278,2018-11-19T07:10:47.000+00:00,2018-11-19T07:10:47.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3229,
+github:GithubIssue:1:439793939,github:GithubIssue:1:381941219,"""release
chinese ， chinese ， chinese goroutine chinese ， chinese ， chinese
pr""",github:GithubAccount:1:7496278,2018-11-19T07:18:05.000+00:00,2018-11-19T07:18:05.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3231,
+github:GithubIssue:1:440207809,github:GithubIssue:1:382574800,"""https://github.com/panjf2000/ants/blob/711dbdb7a222771ce15aaee1bb7b7c6e9731f208/pool.go#L119""",github:GithubAccount:1:5668717,2018-11-20T09:41:24.000+00:00,2018-11-20T09:41:24.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3232,
+github:GithubIssue:1:440263871,github:GithubIssue:1:382574800,""" chinese ，
chinese ， chinese channel， chinese
？""",github:GithubAccount:1:7496278,2018-11-20T12:56:13.000+00:00,2018-11-20T12:56:13.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3233,
+github:GithubIssue:1:440500490,github:GithubIssue:1:382574800,"""> chinese ，
chinese ， chinese channel， chinese ？\r\n\r\n chinese 。 chinese ， chinese ，
chinese ❓ chinese
。""",github:GithubAccount:1:5668717,2018-11-21T02:00:22.000+00:00,2018-11-21T02:00:22.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3234,
+github:GithubIssue:1:440541883,github:GithubIssue:1:382574800,""" chinese
chan\r\n\r\ntype msg struct {\r\n……\r\nFailed chan<- *msg\r\n}\r\n\r\n//
payload == &msg\r\npool,_:= NewPoolWithFunc(10,func(payload interface{})
error{\r\n……\r\n// chinese payload chinese Failed
chan\r\n})\r\n\r\npool.Serve(msg)""",github:GithubAccount:1:7931755,2018-11-21T05:57:51.000+00:00,2018-11-21T06:06:47.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3235,
+github:GithubIssue:1:440605531,github:GithubIssue:1:382574800,"""> chinese
chan\r\n> \r\n> type msg struct {\r\n> ……\r\n> Failed chan<- *msg\r\n> }\r\n>
\r\n> // payload == &msg\r\n> pool,_:= NewPoolWithFunc(10,func(payload
interface{}) error{\r\n> ……\r\n> // chinese payload chinese Failed chan\r\n>
})\r\n> \r\n> pool.Serve(msg)\r\n\r\n chinese `NewPoolWithFunc()`， chinese
`ants.NewPool()`， chinese `pool`， chinese `pool` chinese ：\r\n\r\n```\r\nfunc
(w *Worker) Register(fn func() e [...]
+github:GithubIssue:1:440876192,github:GithubIssue:1:382574800,""" chinese ，
chinese ants chinese ， chinese ， chinese return error chinese ， chinese ；
chinese ，❓ chinese ：1. chinese ；2. chinese ( chinese channel chinese )， chinese
ants chinese ， chinese ， chinese pr， chinese
~~""",github:GithubAccount:1:7496278,2018-11-22T01:09:56.000+00:00,2018-11-22T01:09:56.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3237,
+github:GithubIssue:1:442366878,github:GithubIssue:1:381941219,""" chinese
pool chinese waitgroup， chinese chinese work， chinese waitgroup.Add()，
chinese waitgroup.Done()。 chinese release chinese waitgroup.Wait()。 chinese
worker。 chinese b chinese worker chinese func chinese ， chinese release
chinese
。""",github:GithubAccount:1:32898629,2018-11-28T08:48:17.000+00:00,2018-11-28T08:48:17.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3238,
+github:GithubIssue:1:445462719,github:GithubIssue:1:388907811,""" chinese go
chinese
？""",github:GithubAccount:1:7496278,2018-12-08T14:20:26.000+00:00,2018-12-08T14:20:26.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3239,
+github:GithubIssue:1:445496131,github:GithubIssue:1:388907811,"""go version
go1.11.1 darwin/amd64\r\n\r\n chinese ， chinese Semaphore chinese AntsPool
chinese
""",github:GithubAccount:1:720086,2018-12-08T22:56:54.000+00:00,2018-12-08T22:56:54.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3240,
+github:GithubIssue:1:445815378,github:GithubIssue:1:388907811,""" chinese ，
chinese 。\r\nants chinese ：\r\n1. chinese ( chinese )；\r\n2. goroutine chinese
（ chinese goroutine， chinese ， chinese goroutine chinese ， chinese ）；\r\n3.
ants pool chinese ， chinese pool size、 chinese pool；\r\n4. chinese goroutine
chinese 、 chinese goroutine chinese ， chinese
；\r\n......""",github:GithubAccount:1:7496278,2018-12-10T13:30:04.000+00:00,2018-12-11T02:52:18.000+00:00,"{""ConnectionId"":1,""Name"":
[...]
+github:GithubIssue:1:446447291,github:GithubIssue:1:388907811,""" chinese ，
chinese ？ chinese go routines chinese ， chinese ants chinese
？""",github:GithubAccount:1:720086,2018-12-12T03:18:44.000+00:00,2018-12-12T03:18:44.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3242,
+github:GithubIssue:1:446453643,github:GithubIssue:1:388907811,""" chinese
benchmem=true chinese ； chinese ， chinese pool chinese goroutines chinese ，
chinese goroutine chinese ， chinese sema chinese goroutine chinese ， chinese ，
chinese
goroutine。""",github:GithubAccount:1:7496278,2018-12-12T03:58:29.000+00:00,2018-12-12T03:58:29.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3243,
+github:GithubIssue:1:456022133,github:GithubIssue:1:401277739,""" chinese ，
chinese 。 chinese
。""",github:GithubAccount:1:7496278,2019-01-21T10:21:24.000+00:00,2019-01-21T10:22:58.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3244,
+github:GithubIssue:1:456022560,github:GithubIssue:1:401277739,""" chinese ，
chinese
PR。""",github:GithubAccount:1:7496278,2019-01-21T10:22:39.000+00:00,2019-01-21T10:22:39.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3245,
+github:GithubIssue:1:459948887,github:GithubIssue:1:405951301,"""@jiashiwen
\r\nIt works on my side, pls make sure that you run the example on top of the
latest ants code,
thanks.""",github:GithubAccount:1:7496278,2019-02-02T09:03:51.000+00:00,2019-02-02T09:04:50.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3252,
+github:GithubIssue:1:468919580,github:GithubIssue:1:413968505,""" chinese
，incRunning chinese
。""",github:GithubAccount:1:7496278,2019-03-02T13:14:05.000+00:00,2019-03-02T13:14:05.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3253,
+github:GithubIssue:1:471299071,github:GithubIssue:1:419183961,"""server
chinese
？""",github:GithubAccount:1:7496278,2019-03-10T13:18:01.000+00:00,2019-03-10T13:18:01.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3254,
+github:GithubIssue:1:471869506,github:GithubIssue:1:419268851,""" chinese ，
chinese ， chinese
？""",github:GithubAccount:1:29243953,2019-03-12T06:06:39.000+00:00,2019-03-12T06:06:39.000+00:00,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_comments,3255,
diff --git a/backend/plugins/github/tasks/issue_comment_convertor.go
b/backend/plugins/github/tasks/issue_comment_convertor.go
index d739502e4..d1d7f70e4 100644
--- a/backend/plugins/github/tasks/issue_comment_convertor.go
+++ b/backend/plugins/github/tasks/issue_comment_convertor.go
@@ -18,6 +18,8 @@ limitations under the License.
package tasks
import (
+ "reflect"
+
"github.com/apache/incubator-devlake/core/dal"
"github.com/apache/incubator-devlake/core/errors"
"github.com/apache/incubator-devlake/core/models/domainlayer"
@@ -26,7 +28,6 @@ import (
"github.com/apache/incubator-devlake/core/plugin"
"github.com/apache/incubator-devlake/helpers/pluginhelper/api"
"github.com/apache/incubator-devlake/plugins/github/models"
- "reflect"
)
var ConvertIssueCommentsMeta = plugin.SubTaskMeta{
@@ -78,6 +79,9 @@ func ConvertIssueComments(taskCtx plugin.SubTaskContext)
errors.Error {
AccountId:
accountIdGen.Generate(data.Options.ConnectionId,
githubIssueComment.AuthorUserId),
CreatedDate: githubIssueComment.GithubCreatedAt,
}
+ if !githubIssueComment.GithubUpdatedAt.IsZero() {
+ domainIssueComment.UpdatedDate =
&githubIssueComment.GithubUpdatedAt
+ }
return []interface{}{
domainIssueComment,
}, nil
diff --git a/backend/plugins/jira/tasks/issue_comment_convertor.go
b/backend/plugins/jira/tasks/issue_comment_convertor.go
index 753e6b390..8e5e08c8e 100644
--- a/backend/plugins/jira/tasks/issue_comment_convertor.go
+++ b/backend/plugins/jira/tasks/issue_comment_convertor.go
@@ -18,6 +18,8 @@ limitations under the License.
package tasks
import (
+ "reflect"
+
"github.com/apache/incubator-devlake/core/dal"
"github.com/apache/incubator-devlake/core/errors"
"github.com/apache/incubator-devlake/core/models/domainlayer"
@@ -26,7 +28,6 @@ import (
"github.com/apache/incubator-devlake/core/plugin"
"github.com/apache/incubator-devlake/helpers/pluginhelper/api"
"github.com/apache/incubator-devlake/plugins/jira/models"
- "reflect"
)
var ConvertIssueCommentsMeta = plugin.SubTaskMeta{
@@ -87,6 +88,9 @@ func ConvertIssueComments(taskCtx plugin.SubTaskContext)
errors.Error {
AccountId:
accountIdGen.Generate(data.Options.ConnectionId, issueComment.CreatorAccountId),
CreatedDate: issueComment.Created,
}
+ if !issueComment.Updated.IsZero() {
+ domainIssueComment.UpdatedDate =
&issueComment.Updated
+ }
result = append(result, domainIssueComment)
return result, nil
},
diff --git a/backend/plugins/teambition/e2e/snapshot_tables/issue_comments.csv
b/backend/plugins/teambition/e2e/snapshot_tables/issue_comments.csv
index 7a08cfb3d..33d221559 100644
--- a/backend/plugins/teambition/e2e/snapshot_tables/issue_comments.csv
+++ b/backend/plugins/teambition/e2e/snapshot_tables/issue_comments.csv
@@ -1,5 +1,5 @@
-id,created_at,updated_at,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark,issue_id,body,account_id,created_date
-teambition:TeambitionTaskActivity:1:64152beb2bde1652d0d59414,2023-03-23
14:24:53.038,2023-03-23
14:24:53.038,"{""ConnectionId"":1,""OrganizationId"":"""",""ProjectId"":""64132c94f0d59df1c9825ab8""}",_raw_teambition_api_task_activities,40,"",teambition:TeambitionTask:1:64132c945f3fd80070965938,test,teambition:TeambitionAccount:1:5f27709685e4266322e2690a,2023-03-18
03:11:39.513
-teambition:TeambitionTaskActivity:1:641535ee2bde1652d0d5d56a,2023-03-23
14:24:53.038,2023-03-23
14:24:53.038,"{""ConnectionId"":1,""OrganizationId"":"""",""ProjectId"":""64132c94f0d59df1c9825ab8""}",_raw_teambition_api_task_activities,27,"",teambition:TeambitionTask:1:64132c945f3fd80070965939,test,teambition:TeambitionAccount:1:5f27709685e4266322e2690a,2023-03-18
03:54:22.963
-teambition:TeambitionTaskActivity:1:6416742d875ec8661dc97f0c,2023-03-23
14:24:53.038,2023-03-23
14:24:53.038,"{""ConnectionId"":1,""OrganizationId"":"""",""ProjectId"":""64132c94f0d59df1c9825ab8""}",_raw_teambition_api_task_activities,50,"",teambition:TeambitionTask:1:64132c945f3fd80070965938,twst2,teambition:TeambitionAccount:1:5f27709685e4266322e2690a,2023-03-19
02:32:13.287
-teambition:TeambitionTaskActivity:1:64167724875ec8661dc98729,2023-03-23
14:24:53.038,2023-03-23
14:24:53.038,"{""ConnectionId"":1,""OrganizationId"":"""",""ProjectId"":""64132c94f0d59df1c9825ab8""}",_raw_teambition_api_task_activities,54,"",teambition:TeambitionTask:1:64132c945f3fd80070965938,423534,teambition:TeambitionAccount:1:5f27709685e4266322e2690a,2023-03-19
02:44:52.763
+id,issue_id,body,account_id,created_date,updated_date
+teambition:TeambitionTaskActivity:1:64152beb2bde1652d0d59414,teambition:TeambitionTask:1:64132c945f3fd80070965938,test,teambition:TeambitionAccount:1:5f27709685e4266322e2690a,2023-03-18T03:11:39.513+00:00,2023-03-18T03:11:39.513+00:00
+teambition:TeambitionTaskActivity:1:641535ee2bde1652d0d5d56a,teambition:TeambitionTask:1:64132c945f3fd80070965939,test,teambition:TeambitionAccount:1:5f27709685e4266322e2690a,2023-03-18T03:54:22.963+00:00,2023-03-18T03:54:22.963+00:00
+teambition:TeambitionTaskActivity:1:6416742d875ec8661dc97f0c,teambition:TeambitionTask:1:64132c945f3fd80070965938,twst2,teambition:TeambitionAccount:1:5f27709685e4266322e2690a,2023-03-19T02:32:13.287+00:00,2023-03-19T02:32:13.287+00:00
+teambition:TeambitionTaskActivity:1:64167724875ec8661dc98729,teambition:TeambitionTask:1:64132c945f3fd80070965938,423534,teambition:TeambitionAccount:1:5f27709685e4266322e2690a,2023-03-19T02:44:52.763+00:00,2023-03-19T02:44:52.763+00:00
diff --git a/backend/plugins/teambition/e2e/task_comment_test.go
b/backend/plugins/teambition/e2e/task_comment_test.go
index 0de7de0c9..a1ebb4c55 100644
--- a/backend/plugins/teambition/e2e/task_comment_test.go
+++ b/backend/plugins/teambition/e2e/task_comment_test.go
@@ -18,6 +18,8 @@ limitations under the License.
package e2e
import (
+ "testing"
+
"github.com/apache/incubator-devlake/core/models/common"
"github.com/apache/incubator-devlake/core/models/domainlayer"
"github.com/apache/incubator-devlake/core/models/domainlayer/ticket"
@@ -25,7 +27,6 @@ import (
"github.com/apache/incubator-devlake/plugins/teambition/impl"
"github.com/apache/incubator-devlake/plugins/teambition/models"
"github.com/apache/incubator-devlake/plugins/teambition/tasks"
- "testing"
)
func TestTeambitionTaskComment(t *testing.T) {
@@ -61,9 +62,8 @@ func TestTeambitionTaskComment(t *testing.T) {
dataflowTester.VerifyTableWithOptions(
ticket.IssueComment{},
e2ehelper.TableOptions{
- CSVRelPath: "./snapshot_tables/issue_comments.csv",
- IgnoreFields: []string{"created_date", "logged_date",
"started_date"},
- IgnoreTypes: []interface{}{domainlayer.DomainEntity{}},
+ CSVRelPath: "./snapshot_tables/issue_comments.csv",
+ IgnoreTypes: []interface{}{domainlayer.DomainEntity{}},
},
)
}
diff --git a/backend/plugins/teambition/tasks/task_comment_converter.go
b/backend/plugins/teambition/tasks/task_comment_converter.go
index e1bd59d04..1ee9a2864 100644
--- a/backend/plugins/teambition/tasks/task_comment_converter.go
+++ b/backend/plugins/teambition/tasks/task_comment_converter.go
@@ -19,6 +19,8 @@ package tasks
import (
"encoding/json"
+ "reflect"
+
"github.com/apache/incubator-devlake/core/dal"
"github.com/apache/incubator-devlake/core/errors"
"github.com/apache/incubator-devlake/core/models/domainlayer"
@@ -26,7 +28,6 @@ import (
"github.com/apache/incubator-devlake/core/plugin"
helper "github.com/apache/incubator-devlake/helpers/pluginhelper/api"
"github.com/apache/incubator-devlake/plugins/teambition/models"
- "reflect"
)
var ConvertTaskCommentsMeta = plugin.SubTaskMeta{
@@ -66,6 +67,10 @@ func ConvertTaskComments(taskCtx plugin.SubTaskContext)
errors.Error {
AccountId:
getAccountIdGen().Generate(userTool.ConnectionId, userTool.CreatorId),
CreatedDate: userTool.CreateTime.ToTime(),
}
+ if !userTool.UpdateTime.ToTime().IsZero() {
+ issueComment.UpdatedDate =
userTool.UpdateTime.ToNullableTime()
+ }
+
comment := &models.TeambitionTaskComment{}
err := json.Unmarshal([]byte(userTool.Content), comment)
if err != nil {
