This is an automated email from the ASF dual-hosted git repository. ka94 pushed a commit to branch release-v0.17 in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
commit abf1d3a26d225b201050ddf6264a7e8e63321980 Author: Alexis Vanier <[email protected]> AuthorDate: Wed May 17 17:07:44 2023 -0400 fix: Correct paging behaviour during PagerDuty service enumeration (#5213) This commit/PR fixes issue 5212 where when paging across PagerDuty services the offset is incremented by the number of pages, resulting in only one more new service being displayed along with 99 more other services that were already displayed. --- backend/plugins/pagerduty/api/remote.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/plugins/pagerduty/api/remote.go b/backend/plugins/pagerduty/api/remote.go index 4f2ef6edd..6cb4ab064 100644 --- a/backend/plugins/pagerduty/api/remote.go +++ b/backend/plugins/pagerduty/api/remote.go @@ -302,7 +302,7 @@ func DecodeFromPageToken(pageToken string) (*PageData, errors.Error) { func GetQueryFromPageData(pageData *PageData) (url.Values, errors.Error) { query := url.Values{} - query.Set("offset", fmt.Sprintf("%v", pageData.Page)) + query.Set("offset", fmt.Sprintf("%v", pageData.Page*pageData.PerPage)) query.Set("limit", fmt.Sprintf("%v", pageData.PerPage)) return query, nil }
