klesh commented on code in PR #5289:
URL: 
https://github.com/apache/incubator-devlake/pull/5289#discussion_r1206339396


##########
backend/server/services/project.go:
##########
@@ -254,6 +247,65 @@ func PatchProject(name string, body 
map[string]interface{}) (*models.ApiOutputPr
        return makeProjectOutput(&projectInput.BaseProject)
 }
 
+// DeleteProject FIXME ...
+func DeleteProject(name string) errors.Error {
+       // verify input
+       if name == "" {
+               return errors.BadInput.New("project name is missing")
+       }
+       var err errors.Error
+       tx := db.Begin()
+       defer func() {
+               if r := recover(); r != nil || err != nil {
+                       err = tx.Rollback()
+                       if err != nil {
+                               logger.Error(err, "DeleteProject: failed to 
rollback")
+                       }
+               }
+       }()
+       _, err = getProjectByName(tx, name)
+       if err != nil {
+               return err
+       }
+       err = tx.Delete(&models.Project{}, dal.Where("name = ?", name))
+       if err != nil {
+               return err
+       }
+       err = tx.Delete(&crossdomain.ProjectMapping{}, dal.Where("project_name 
= ?", name))
+       if err != nil {
+               return err
+       }
+       err = tx.Delete(&models.ProjectMetricSetting{}, dal.Where("project_name 
= ?", name))
+       if err != nil {
+               return err
+       }
+       err = tx.Delete(&crossdomain.ProjectPrMetric{}, dal.Where("project_name 
= ?", name))
+       if err != nil {
+               return err
+       }
+       err = tx.Delete(&crossdomain.ProjectIssueMetric{}, 
dal.Where("project_name = ?", name))
+       if err != nil {
+               return err
+       }
+       err = tx.Commit()

Review Comment:
   Let us delete the related `blueprint` as well. It is different than deleting 
related scopes, we are sure the bp is useless when the corresponding project is 
gone.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to