keon94 commented on code in PR #5345:
URL:
https://github.com/apache/incubator-devlake/pull/5345#discussion_r1219903006
##########
backend/test/helper/api.go:
##########
@@ -194,43 +194,43 @@ func (d *DevlakeClient) GetScope(pluginName string,
connectionId uint64, scopeId
}, http.MethodGet,
fmt.Sprintf("%s/plugins/%s/connections/%d/scopes/%s?blueprints=%v", d.Endpoint,
pluginName, connectionId, scopeId, listBlueprints), nil, nil)
}
-func (d *DevlakeClient) DeleteScope(pluginName string, connectionId uint64,
scopeId string, deleteDataOnly bool) []models.Blueprint {
- return sendHttpRequest[[]models.Blueprint](d.testCtx, d.timeout,
debugInfo{
+func (d *DevlakeClient) DeleteScope(pluginName string, connectionId uint64,
scopeId string, deleteDataOnly bool) any {
+ return sendHttpRequest[any](d.testCtx, d.timeout, debugInfo{
print: true,
inlineJson: false,
}, http.MethodDelete,
fmt.Sprintf("%s/plugins/%s/connections/%d/scopes/%s?delete_data_only=%v",
d.Endpoint, pluginName, connectionId, scopeId, deleteDataOnly), nil, nil)
}
-func (d *DevlakeClient) CreateTransformationRule(pluginName string,
connectionId uint64, rules any) any {
+func (d *DevlakeClient) CreateScopeConfig(pluginName string, connectionId
uint64, scopeConfig any) any {
return sendHttpRequest[any](d.testCtx, d.timeout, debugInfo{
print: true,
inlineJson: false,
- }, http.MethodPost,
fmt.Sprintf("%s/plugins/%s/connections/%d/transformation_rules",
- d.Endpoint, pluginName, connectionId), nil, rules)
+ }, http.MethodPost,
fmt.Sprintf("%s/plugins/%s/connections/%d/scope_configs",
+ d.Endpoint, pluginName, connectionId), nil, scopeConfig)
}
-func (d *DevlakeClient) PatchTransformationRule(pluginName string,
connectionId uint64, txRuleId uint64, rule any) any {
+func (d *DevlakeClient) PatchScopeConfig(pluginName string, connectionId
uint64, scopeConfigId uint64, scopeConfig any) any {
return sendHttpRequest[any](d.testCtx, d.timeout, debugInfo{
print: true,
inlineJson: false,
- }, http.MethodPatch,
fmt.Sprintf("%s/plugins/%s/connections/%d/transformation_rules/%d",
- d.Endpoint, pluginName, connectionId, txRuleId), nil, rule)
+ }, http.MethodPatch,
fmt.Sprintf("%s/plugins/%s/connections/%d/scope_configs/%d",
+ d.Endpoint, pluginName, connectionId, scopeConfigId), nil,
scopeConfig)
}
-func (d *DevlakeClient) ListTransformationRules(pluginName string,
connectionId uint64) []any {
+func (d *DevlakeClient) ListScopeConfigs(pluginName string, connectionId
uint64) []any {
return sendHttpRequest[[]any](d.testCtx, d.timeout, debugInfo{
print: true,
inlineJson: false,
- }, http.MethodGet,
fmt.Sprintf("%s/plugins/%s/connections/%d/transformation_rules?pageSize=20&page=1",
+ }, http.MethodGet,
fmt.Sprintf("%s/plugins/%s/connections/%d/scope_configs?pageSize=20&page=1",
d.Endpoint, pluginName, connectionId), nil, nil)
}
-func (d *DevlakeClient) GetTransformationRule(pluginName string, connectionId
uint64, txRuleId uint64) any {
+func (d *DevlakeClient) GetScopeConfig(pluginName string, connectionId uint64,
scopeConfigId uint64) any {
return sendHttpRequest[any](d.testCtx, d.timeout, debugInfo{
print: true,
inlineJson: false,
- }, http.MethodGet,
fmt.Sprintf("%s/plugins/%s/connections/%d/transformation_rules/%d",
- d.Endpoint, pluginName, connectionId, txRuleId), nil, nil)
+ }, http.MethodGet,
fmt.Sprintf("%s/plugins/%s/connections/%d/scope_configs/%d",
Review Comment:
I think this needs to be scope-config? I believe that's the convention other
plugins are going to use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
