CamilleTeruel commented on issue #5385:
URL:
https://github.com/apache/incubator-devlake/issues/5385#issuecomment-1584330232
> @hezyin @Startrekzky @mindlesscloud @likyh @keon94 @CamilleTeruel I think
we should ignore all 404 error for all secondary-data-collections (collectors
that rely on other entity, e.g. changelogs , comments, etcs)
We faced this kind of issue many times with different APIs, so it would be
great to have a generic solution for that.
Now, I'm not sure about ignoring 404:
- some APIs will return a 410 or a 204 instead in this situation
- we can get a 404 for other reasons, this would silent unrelated errors
I agree that we should continue collection in case of errors.
But then the question is about error reporting.
For each error we should decide whether to ignore or report it.
And answering this question seems API-specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
