mappjzc commented on code in PR #5468:
URL:
https://github.com/apache/incubator-devlake/pull/5468#discussion_r1229113536
##########
backend/plugins/jira/api/remote.go:
##########
@@ -58,14 +58,21 @@ func RemoteScopes(input *plugin.ApiResourceInput)
(*plugin.ApiResourceOutput, er
}
resBody := struct {
- Values []apiv2models.Board `json:"values"`
+ MaxResults int
`json:"maxResults"`
+ StartAt int `json:"startAt"`
+ Values []apiv2models.Board `json:"values"`
}{}
err = api.UnmarshalResponse(res, &resBody)
if err != nil {
return nil, err
}
+ if (queryData.PerPage != resBody.MaxResults) ||
Review Comment:
IsLast can not be used for this checking, because it only checks if
maxResult is reset by remote.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
