Marco-De-Stefani opened a new issue, #5486:
URL: https://github.com/apache/incubator-devlake/issues/5486

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   The fetching of the merge request information from GitLab APIs is not 
completely correct because the option "squash on merge" of GitLab is not 
managed correctly.
   To be more specific when a MR is squashed the related commit sha is not 
reported inside the field "merge_commit_sha" that we are fetching from GitLab 
APIs but is instead inside the "squash_commit_sha" field. The information about 
the squashing option enabled or disabled is inside the "squash" field.
   
   Gitlab docs: https://docs.gitlab.com/ee/api/merge_requests.html#response
   
   ### What do you expect to happen
   
   I would have expected to have the "merge_commit_sha" field in the 
"pull_requests" table be populated to proceed with the DORA metrics validation.
   
   ### How to reproduce
   
   - Have a working version of DevLake
   - Integrate it with a GitLab project
   - In the integrated Gitlab project set as "Required" the squash option 
(under Settings -> Merge Request ->  Squash commits when merging)
   - Create a Merge request in the project and merge it 
   
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   v0.17.0
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to