keon94 commented on code in PR #5506:
URL:
https://github.com/apache/incubator-devlake/pull/5506#discussion_r1232326919
##########
backend/helpers/pluginhelper/api/connection_helper.go:
##########
@@ -101,8 +104,16 @@ func (c *ConnectionApiHelper) List(connections
interface{}) errors.Error {
}
// Delete connection
-func (c *ConnectionApiHelper) Delete(connection interface{}) errors.Error {
- return CallDB(c.db.Delete, connection)
+func (c *ConnectionApiHelper) Delete(plugin string, connection interface{})
(*services.BlueprintProjectPairs, errors.Error) {
+ connectionId := reflectField(connection, "ID").Uint()
+ referencingBps, err := c.bpManager.GetBlueprintsByConnection(plugin,
connectionId)
+ if err != nil {
+ return nil, err
+ }
+ if len(referencingBps) > 0 {
+ return services.NewBlueprintProjectPairs(referencingBps),
errors.Conflict.New("Found one or more references to this connection")
+ }
+ return nil, CallDB(c.db.Delete, connection)
Review Comment:
See question 5:
https://github.com/apache/incubator-devlake/issues/5503#issuecomment-1593356778
The front-end has a references to the scopes and will delete this after
they've been removed.
@Startrekzky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
