keon94 commented on PR #5606: URL: https://github.com/apache/incubator-devlake/pull/5606#issuecomment-1614634329
@klesh Actually, as far as compilations, the Name() of the script contains the plugin name, meaning if we boot up the system with a new plugin it should detect the missing migration for that plugin based on the name. If you look at the migration history table, it is adding one record per plugin to it. Also, perhaps this logic could be moved to a different package and not live in core (e.g. in helper/). The only problem I am seeing here now is that for future plugins these sorts of migration end up getting executed as well, so yeah, sadly I think I might have to resort back to duplicated-code approach. ugh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
