keon94 commented on code in PR #5699:
URL:
https://github.com/apache/incubator-devlake/pull/5699#discussion_r1269650958
##########
backend/plugins/gitlab/api/init.go:
##########
@@ -44,7 +44,7 @@ func Init(br context.BasicRes, p plugin.PluginMeta) {
params := &api.ReflectionParameters{
ScopeIdFieldName: "GitlabId",
ScopeIdColumnName: "gitlab_id",
- RawScopeParamName: "ProjectId",
+ RawScopeParamName: "name",
Review Comment:
I don't think it's the same problem, but Github uses the "Name" field in its
ApiParams (Gitlab doesn't seem to though), and the way to handle that is to
"derive" the Name from the ScopeId, and for that you need to implement a
special function. See how it's done here:
https://github.com/apache/incubator-devlake/blob/166e0b7a36e1279cdc15df96b659518377c838b7/backend/plugins/github/api/init.go#L60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
