klesh commented on code in PR #5995:
URL:
https://github.com/apache/incubator-devlake/pull/5995#discussion_r1317029134
##########
backend/helpers/pluginhelper/api/connection.go:
##########
@@ -29,13 +30,23 @@ type BaseConnection struct {
common.Model
}
+func (c BaseConnection) GetHash() string {
+ return fmt.Sprintf("%d%v", c.ID, c.UpdatedAt)
+}
+
// RestConnection implements the ApiConnection interface
type RestConnection struct {
Endpoint string `mapstructure:"endpoint" validate:"required"
json:"endpoint"`
Proxy string `mapstructure:"proxy" json:"proxy"`
RateLimitPerHour int `comment:"api request rate limit per hour"
json:"rateLimitPerHour"`
}
+// GetHash returns the hash of the connection, returning empty string for no
connection reuse
+// no connection reuse by default, override this function to enable connection
reuse
+func (rc RestConnection) GetHash() string {
Review Comment:
Do we still need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
