d4x1 commented on code in PR #6114:
URL:
https://github.com/apache/incubator-devlake/pull/6114#discussion_r1329985439
##########
backend/plugins/bitbucket/api/remote.go:
##########
@@ -117,30 +117,38 @@ func SearchRemoteScopes(input *plugin.ApiResourceInput)
(*plugin.ApiResourceOutp
// create api client
apiClient, err :=
api.NewApiClientFromConnection(gocontext.TODO(), basicRes, &connection)
if err != nil {
- return nil, err
+ return nil, errors.BadInput.Wrap(err, "failed
to get create apiClient")
}
- query := initialQuery(queryData)
- s := queryData.Search[0]
// request search
+ query := initialQuery(queryData)
+ if len(queryData.Search) == 0 {
+ return nil, errors.BadInput.New("empty search
query")
+ }
+ s := queryData.Search[0]
query.Set("sort", "name")
- query.Set("fields",
"values.name,values.full_name,values.language,values.description,values.owner.username,values.created_on,values.updated_on,values.links.clone,values.links.self,pagelen,page,size")
+ query.Set("fields",
"values.name,values.full_name,values.language,values.description,values.owner.display_name,values.created_on,values.updated_on,values.links.clone,values.links.html,pagelen,page,size")
+
+ //list projects part
gid := ``
if strings.Contains(s, `/`) {
Review Comment:
L134~137, may be we can make it a function named like`GetSearch`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
