This is an automated email from the ASF dual-hosted git repository.
klesh pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
The following commit(s) were added to refs/heads/main by this push:
new 10c37eaea Fix 6112 (#6116)
10c37eaea is described below
commit 10c37eaea6adf1db8594143dfc332986bf5bc759
Author: Marco-De-Stefani <[email protected]>
AuthorDate: Wed Sep 20 12:05:36 2023 +0200
Fix 6112 (#6116)
* fixing issue 6112
* fix typo
* fix PR comment
---
backend/Makefile | 2 +-
backend/plugins/pagerduty/impl/impl.go | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/backend/Makefile b/backend/Makefile
index cccecdd88..b86c95348 100644
--- a/backend/Makefile
+++ b/backend/Makefile
@@ -26,7 +26,7 @@ PYTHON_DIR ?= "./python"
go-dep:
go install github.com/vektra/mockery/[email protected]
go install github.com/swaggo/swag/cmd/[email protected]
- go install github.com/golangci/golangci-lint/cmd/[email protected]
+ go install github.com/golangci/golangci-lint/cmd/[email protected]
go install github.com/atombender/go-jsonschema/cmd/gojsonschema@latest
python-dep:
diff --git a/backend/plugins/pagerduty/impl/impl.go
b/backend/plugins/pagerduty/impl/impl.go
index 273e578b3..b234b296a 100644
--- a/backend/plugins/pagerduty/impl/impl.go
+++ b/backend/plugins/pagerduty/impl/impl.go
@@ -108,9 +108,8 @@ func (p PagerDuty) PrepareTaskData(taskCtx
plugin.TaskContext, options map[strin
return nil, errors.Default.Wrap(err, "unable to get Pagerduty
connection by the given connection ID")
}
- client, err := helper.NewApiClient(taskCtx.GetContext(),
connection.Endpoint, map[string]string{
- "Authorization": fmt.Sprintf("Token %s", connection.Token),
- }, 0, connection.Proxy, taskCtx)
+ client, err := helper.NewApiClientFromConnection(taskCtx.GetContext(),
taskCtx, connection)
+
if err != nil {
return nil, err
}