keon94 commented on PR #6116: URL: https://github.com/apache/incubator-devlake/pull/6116#issuecomment-1727169840
> > @Marco-De-Stefani very odd. I tried running the pagerduty tests under `test/e2e/manual/pagerduty` with and without this change and it works for me, so I don't know what's going on. Either way, there's a better fix for this which I've pointed out in the file changes. > > I noticed that as well, it works cause at line 125 of the pagerduty_test.go file it's calling "PagerDutyAccessToken" which sets the token in the correct way :) That token object doesn't have an influence [here](https://github.com/apache/incubator-devlake/blob/73883730362d16148cee167cb0cd5f13edc28f62/backend/plugins/pagerduty/impl/impl.go#L111) though. The test still passes without "token=". Here's what my debugger captures - connection.Token is just the raw token.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
