keon94 commented on code in PR #6154: URL: https://github.com/apache/incubator-devlake/pull/6154#discussion_r1348160073
########## backend/plugins/opsgenie/tasks/incidents_collector.go: ########## @@ -0,0 +1,89 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package tasks + +import ( + "encoding/json" + "fmt" + "net/http" + "net/url" + + "github.com/apache/incubator-devlake/core/errors" + "github.com/apache/incubator-devlake/core/plugin" + "github.com/apache/incubator-devlake/helpers/pluginhelper/api" +) + +const RAW_INCIDENTS_TABLE = "opsgenie_incidents" + +var _ plugin.SubTaskEntryPoint = CollectIncidents + +type ( + collectedIncidents struct { + TotalCount int `json:"totalCount"` + Data []json.RawMessage `json:"data"` + } +) + +var CollectIncidentsMeta = plugin.SubTaskMeta{ + Name: "collectIncidents", + EntryPoint: CollectIncidents, + EnabledByDefault: true, + Description: "Collect Opsgenie incidents", + DomainTypes: []string{plugin.DOMAIN_TYPE_TICKET}, +} + +func CollectIncidents(taskCtx plugin.SubTaskContext) errors.Error { + data := taskCtx.GetData().(*OpsgenieTaskData) + + collectorWithState, err := api.NewStatefulApiCollector(api.RawDataSubTaskArgs{ + Ctx: taskCtx, + Options: data.Options, + Table: RAW_INCIDENTS_TABLE, + }) + if err != nil { + return err + } + + err = collectorWithState.InitCollector(api.ApiCollectorArgs{ Review Comment: CollectUnfinishedDetails is something that runs when you already have existing unresolved incidents from the previous run. The purpose of it is to grab those incidents from the DB and check them against the API and pull down their newest state. It is pretty important to implement this otherwise the collected incidents will remain "stuck" in whatever state they were initially collected with and never get updated. Have you looked at the PagerDuty implementation of it as reference? https://github.com/apache/incubator-devlake/blob/62a1e93a2dab358af6b0e2b1eecd21ad70208941/backend/plugins/pagerduty/tasks/incidents_collector.go#L111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
