d4x1 commented on code in PR #6188: URL: https://github.com/apache/incubator-devlake/pull/6188#discussion_r1349635047
########## backend/core/models/common/string_float64.go: ########## @@ -0,0 +1,85 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package common + +import ( + "database/sql/driver" + "encoding/json" + "fmt" + "github.com/spf13/cast" +) + +type StringFloat64 struct { + v float64 + t string Review Comment: The original type is useless if we just want codes to run correctly, but if we define a new custom type, the original type is the basic component. I tend to keep type info in order to make the custom `StringFloat64` "unbroken". ########## backend/core/models/common/string_float64.go: ########## @@ -0,0 +1,85 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package common + +import ( + "database/sql/driver" + "encoding/json" + "fmt" + "github.com/spf13/cast" +) + +type StringFloat64 struct { + v float64 + t string Review Comment: @klesh The original type is useless if we just want codes to run correctly, but if we define a new custom type, the original type is the basic component. I tend to keep type info in order to make the custom `StringFloat64` "unbroken". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
