klesh commented on code in PR #6234:
URL:
https://github.com/apache/incubator-devlake/pull/6234#discussion_r1356666922
##########
backend/plugins/gitlab/tasks/deployment_collector.go:
##########
@@ -60,8 +60,11 @@ func CollectDeployment(taskCtx plugin.SubTaskContext)
errors.Error {
if err != nil {
return query, err
}
+
if collectorWithState.Since != nil {
query.Set("updated_after",
collectorWithState.Since.Format(time.RFC3339))
+ //
https://gitlab.com/gitlab-org/gitlab/-/issues/328500
+ query.Set("order_by", "created_at")
Review Comment:
Should not be nested in the condition consider `collectorWithState.Since`
could be `nil` for the very first collection and we still need the records to
be sorted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
