This is an automated email from the ASF dual-hosted git repository. mintsweet pushed a commit to branch fix-bugs in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
commit 687917a55a2732510dd3024ea3c6499b27757bb0 Author: mintsweet <[email protected]> AuthorDate: Fri Oct 20 15:59:14 2023 +1300 fix(config-ui): hidden edit scope config when plugin doesn't have it --- config-ui/src/pages/blueprint/connection-detail/index.tsx | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/config-ui/src/pages/blueprint/connection-detail/index.tsx b/config-ui/src/pages/blueprint/connection-detail/index.tsx index bae6b58f8..bb13c4b05 100644 --- a/config-ui/src/pages/blueprint/connection-detail/index.tsx +++ b/config-ui/src/pages/blueprint/connection-detail/index.tsx @@ -24,7 +24,7 @@ import { Popover2 } from '@blueprintjs/popover2'; import API from '@/api'; import { PageLoading, PageHeader, ExternalLink, Message, Buttons, Table, Dialog } from '@/components'; import { useRefreshData, useTips } from '@/hooks'; -import { DataScopeSelect, getPluginScopeId } from '@/plugins'; +import { DataScopeSelect, getPluginScopeId, PluginConfig, PluginConfigType } from '@/plugins'; import { operator } from '@/utils'; import { encodeName } from '../../project/utils'; @@ -50,8 +50,11 @@ export const BlueprintConnectionDetailPage = () => { return API.blueprint.get(bid as any); }; + const [plugin, connectionId] = unique.split('-'); + + const pluginConfig = PluginConfig.find((p) => p.plugin === plugin) as PluginConfigType; + const { ready, data } = useRefreshData(async () => { - const [plugin, connectionId] = unique.split('-'); const [blueprint, connection] = await Promise.all([ getBlueprint(pname, bid), API.connection.get(plugin, connectionId), @@ -205,9 +208,11 @@ export const BlueprintConnectionDetailPage = () => { </S.Top> <Buttons position="top"> <Button intent={Intent.PRIMARY} icon="annotation" text="Manage Data Scope" onClick={handleShowDataScope} /> - <ExternalLink style={{ marginLeft: 8 }} link={`/connections/${connection.plugin}/${connection.id}`}> - <Button intent={Intent.PRIMARY} icon="annotation" text="Edit Scope Config" /> - </ExternalLink> + {pluginConfig.scopeConfig && ( + <ExternalLink style={{ marginLeft: 8 }} link={`/connections/${connection.plugin}/${connection.id}`}> + <Button intent={Intent.PRIMARY} icon="annotation" text="Edit Scope Config" /> + </ExternalLink> + )} </Buttons> <Table columns={[
