d4x1 commented on code in PR #6333:
URL: 
https://github.com/apache/incubator-devlake/pull/6333#discussion_r1371512905


##########
backend/plugins/bitbucket/tasks/deployment_convertor.go:
##########
@@ -106,6 +107,13 @@ func ConvertDeployments(taskCtx plugin.SubTaskContext) 
errors.Error {
                                RepoId:       repoId,
                                RepoUrl:      repo.HTMLUrl,
                        }
+                       if domainDeployCommit.Environment == devops.TEST {
+                               // Theoretically, environment cannot be "Test" 
according to
+                               // 
https://developer.atlassian.com/server/bitbucket/rest/v814/api-group-builds-and-deployments/#api-api-latest-projects-projectkey-repos-repositoryslug-commits-commitid-deployments-get
+                               // but in practice, we found environment is 
"Test".
+                               // So convert it to devlake's definition.
+                               domainDeployCommit.Environment = devops.TESTING

Review Comment:
   @Startrekzky Should we ignore other environments except PRODUCTION?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to